Re: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

2015-04-28 Thread Matthew Wilcox
On Tue, Apr 28, 2015 at 06:01:04AM -0700, Christoph Hellwig wrote: > Please don't add any of the nd-specific hacks into the pmem driver. > The rw_bytes functionality already is provided by the existing block > level ->rw_page method which pmem already implements, and any sort > of bus locking for

Re: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

2015-04-28 Thread Christoph Hellwig
On Fri, Apr 17, 2015 at 09:36:55PM -0400, Dan Williams wrote: > Block devices from an nd bus, in addition to accepting "struct bio" > based requests, also have the capability to perform byte-aligned > accesses. By default only the bio/block interface is used. However, if > another driver can

Re: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

2015-04-28 Thread Christoph Hellwig
On Fri, Apr 17, 2015 at 09:36:55PM -0400, Dan Williams wrote: Block devices from an nd bus, in addition to accepting struct bio based requests, also have the capability to perform byte-aligned accesses. By default only the bio/block interface is used. However, if another driver can make

Re: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

2015-04-28 Thread Matthew Wilcox
On Tue, Apr 28, 2015 at 06:01:04AM -0700, Christoph Hellwig wrote: Please don't add any of the nd-specific hacks into the pmem driver. The rw_bytes functionality already is provided by the existing block level -rw_page method which pmem already implements, and any sort of bus locking for

Re: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

2015-04-22 Thread Dan Williams
.org >> Subject: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices >> > ... >> +/* >> + * btt_sb_checksum: compute checksum for btt info block >> + * >> + * Returns a fletcher64 checksum of everything in the given info block >> + * exc

RE: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

2015-04-22 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > Dan Williams > Sent: Friday, April 17, 2015 8:37 PM > To: linux-nvd...@lists.01.org > Subject: [Linux-nvdimm] [PATCH 19/21] nd: infrastructu

Re: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

2015-04-22 Thread Dan Williams
-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices ... +/* + * btt_sb_checksum: compute checksum for btt info block + * + * Returns a fletcher64 checksum of everything in the given info block + * except the last field (since that's where the checksum lives). + */ +u64 btt_sb_checksum

RE: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

2015-04-22 Thread Elliott, Robert (Server Storage)
-Original Message- From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of Dan Williams Sent: Friday, April 17, 2015 8:37 PM To: linux-nvd...@lists.01.org Subject: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices ... +/* + * btt_sb_checksum

[PATCH 19/21] nd: infrastructure for btt devices

2015-04-17 Thread Dan Williams
Block devices from an nd bus, in addition to accepting "struct bio" based requests, also have the capability to perform byte-aligned accesses. By default only the bio/block interface is used. However, if another driver can make effective use of the byte-aligned capability it can claim/disable

[PATCH 19/21] nd: infrastructure for btt devices

2015-04-17 Thread Dan Williams
Block devices from an nd bus, in addition to accepting struct bio based requests, also have the capability to perform byte-aligned accesses. By default only the bio/block interface is used. However, if another driver can make effective use of the byte-aligned capability it can claim/disable the