Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-10-08 Thread Jason Cooper
On Tue, Oct 08, 2013 at 07:59:49PM +0200, Jean-Francois Moine wrote: > On Tue, 8 Oct 2013 12:11:45 -0400 > Jason Cooper wrote: > > > Jean-Francois, > > > > On Thu, Oct 03, 2013 at 06:17:16PM +0200, Jean-Francois Moine wrote: > > > It seems that my patch about adding s/pdif to the kirkwood audio

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-10-08 Thread Jean-Francois Moine
On Tue, 8 Oct 2013 12:11:45 -0400 Jason Cooper wrote: > Jean-Francois, > > On Thu, Oct 03, 2013 at 06:17:16PM +0200, Jean-Francois Moine wrote: > > It seems that my patch about adding s/pdif to the kirkwood audio driver > > has not been accepted yet... > > Looking over that conversation does

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-10-08 Thread Jason Cooper
Jean-Francois, On Thu, Oct 03, 2013 at 06:17:16PM +0200, Jean-Francois Moine wrote: > It seems that my patch about adding s/pdif to the kirkwood audio driver > has not been accepted yet... Looking over that conversation does not give the impression that concerns were resolved. I'm a little

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-10-08 Thread Jason Cooper
Jean-Francois, On Thu, Oct 03, 2013 at 06:17:16PM +0200, Jean-Francois Moine wrote: It seems that my patch about adding s/pdif to the kirkwood audio driver has not been accepted yet... Looking over that conversation does not give the impression that concerns were resolved. I'm a little short

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-10-08 Thread Jean-Francois Moine
On Tue, 8 Oct 2013 12:11:45 -0400 Jason Cooper ja...@lakedaemon.net wrote: Jean-Francois, On Thu, Oct 03, 2013 at 06:17:16PM +0200, Jean-Francois Moine wrote: It seems that my patch about adding s/pdif to the kirkwood audio driver has not been accepted yet... Looking over that

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-10-08 Thread Jason Cooper
On Tue, Oct 08, 2013 at 07:59:49PM +0200, Jean-Francois Moine wrote: On Tue, 8 Oct 2013 12:11:45 -0400 Jason Cooper ja...@lakedaemon.net wrote: Jean-Francois, On Thu, Oct 03, 2013 at 06:17:16PM +0200, Jean-Francois Moine wrote: It seems that my patch about adding s/pdif to the

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-10-03 Thread Jean-Francois Moine
On Sat, 28 Sep 2013 16:27:19 +0200 Sebastian Hesselbarth wrote: > Jean-Francois, > > I can confirm the following for CuBox: > > AU1_EXTCLK is connected to si5351 clkout 2. For the _current_ > (v3.12-rc1) dove-cubox.dts that means that you'll have to exchange > the properties for

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-10-03 Thread Jean-Francois Moine
On Sat, 28 Sep 2013 16:27:19 +0200 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: Jean-Francois, I can confirm the following for CuBox: AU1_EXTCLK is connected to si5351 clkout 2. For the _current_ (v3.12-rc1) dove-cubox.dts that means that you'll have to exchange the

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-28 Thread Sebastian Hesselbarth
On 09/26/2013 01:28 PM, Jean-Francois Moine wrote: On Thu, 26 Sep 2013 10:31:10 +0200 Sebastian Hesselbarth wrote: On 09/26/2013 10:11 AM, Jean-Francois Moine wrote: In the Cubox, I changed the audio DT to: { status = "okay"; clocks = <_clk 13>, < 1>; Jean-Francois, I can

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-28 Thread Sebastian Hesselbarth
On 09/26/2013 01:28 PM, Jean-Francois Moine wrote: On Thu, 26 Sep 2013 10:31:10 +0200 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 09/26/2013 10:11 AM, Jean-Francois Moine wrote: In the Cubox, I changed the audio DT to: i2s1 { status = okay; clocks =

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-26 Thread Sebastian Hesselbarth
On 09/26/2013 01:28 PM, Jean-Francois Moine wrote: On Thu, 26 Sep 2013 10:31:10 +0200 Sebastian Hesselbarth wrote: On 09/26/2013 10:11 AM, Jean-Francois Moine wrote: In the Cubox, I changed the audio DT to: { status = "okay"; clocks = <_clk 13>, < 1>; clock-names =

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-26 Thread Jean-Francois Moine
On Thu, 26 Sep 2013 10:31:10 +0200 Sebastian Hesselbarth wrote: > On 09/26/2013 10:11 AM, Jean-Francois Moine wrote: > > In the Cubox, I changed the audio DT to: > > > > { > > status = "okay"; > > clocks = <_clk 13>, < 1>; > > clock-names = "internal", "extclk"; > > pinctrl-0 =

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-26 Thread Sebastian Hesselbarth
On 09/26/2013 10:11 AM, Jean-Francois Moine wrote: In the Cubox, I changed the audio DT to: { status = "okay"; clocks = <_clk 13>, < 1>; clock-names = "internal", "extclk"; pinctrl-0 = <_audio1_i2s1_spdifo _gpio_13_audio1>; Have you checked that pinmux was

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-26 Thread Jean-Francois Moine
On Sun, 01 Sep 2013 11:26:54 +0200 Sebastian Hesselbarth wrote: > Jean-Francois, > Sorry for the messy reply, posting from mobile. > > Can you please try < 1>, iirc audio ist connected to it. I will also > look it up later. Sebastian, In the Cubox, I changed the audio DT to: {

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-26 Thread Jean-Francois Moine
On Sun, 01 Sep 2013 11:26:54 +0200 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: Jean-Francois, Sorry for the messy reply, posting from mobile. Can you please try si5351 1, iirc audio ist connected to it. I will also look it up later. Sebastian, In the Cubox, I changed the

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-26 Thread Sebastian Hesselbarth
On 09/26/2013 10:11 AM, Jean-Francois Moine wrote: In the Cubox, I changed the audio DT to: i2s1 { status = okay; clocks = gate_clk 13, si5351 1; clock-names = internal, extclk; pinctrl-0 = pmx_audio1_i2s1_spdifo pmx_gpio_13_audio1; Have you checked that pinmux

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-26 Thread Jean-Francois Moine
On Thu, 26 Sep 2013 10:31:10 +0200 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 09/26/2013 10:11 AM, Jean-Francois Moine wrote: In the Cubox, I changed the audio DT to: i2s1 { status = okay; clocks = gate_clk 13, si5351 1; clock-names = internal,

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-26 Thread Sebastian Hesselbarth
On 09/26/2013 01:28 PM, Jean-Francois Moine wrote: On Thu, 26 Sep 2013 10:31:10 +0200 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 09/26/2013 10:11 AM, Jean-Francois Moine wrote: In the Cubox, I changed the audio DT to: i2s1 { status = okay; clocks =

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-01 Thread Sebastian Hesselbarth
Jean-Francois, Sorry for the messy reply, posting from mobile. Can you please try < 1>, iirc audio ist connected to it. I will also look it up later. Sebastian On August 31, 2013 12:51:28 PM Jean-Francois Moine wrote: On Wed, 28 Aug 2013 12:14:24 +0200 Sebastian Hesselbarth wrote: > >

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-09-01 Thread Sebastian Hesselbarth
Jean-Francois, Sorry for the messy reply, posting from mobile. Can you please try si5351 1, iirc audio ist connected to it. I will also look it up later. Sebastian On August 31, 2013 12:51:28 PM Jean-Francois Moine moin...@free.fr wrote: On Wed, 28 Aug 2013 12:14:24 +0200 Sebastian

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-31 Thread Russell King - ARM Linux
On Sat, Aug 31, 2013 at 01:55:19PM +0200, Jean-Francois Moine wrote: > The last case was "when using the two audio controllers with different > sample rates" (I should have added "in the set [44.1, 48, 96 kHz]"). > Then, with or without the availability of external clocks, both > controllers will

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-31 Thread Jean-Francois Moine
On Sat, 31 Aug 2013 12:24:31 +0100 Russell King - ARM Linux wrote: > > According to the Dove specification, the audio controller works with > > the samples rates 44.1, 48 and 96 kHz, so, I don't see the usage of the > > external clock, except when using the two audio controllers with > >

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-31 Thread Russell King - ARM Linux
On Sat, Aug 31, 2013 at 12:51:28PM +0200, Jean-Francois Moine wrote: > Hi Sebastian and Russell, > > I tried it on my Cubox (< 2>), and I have problems with HDMI > output and some audio streams like webradios with sample rates 32 or > 22.05 kHz. Some TVs will only accept certain sample rates -

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-31 Thread Jean-Francois Moine
On Wed, 28 Aug 2013 12:14:24 +0200 Sebastian Hesselbarth wrote: > > + { > > + status = "okay"; > > + pinctrl-0 = <_audio1_i2s1_spdifo>; > > + pinctrl-names = "default"; > > +}; > > Please also add the external clock connected from si5351. Hi Sebastian and Russell, I tried it on my

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-31 Thread Jean-Francois Moine
On Wed, 28 Aug 2013 12:14:24 +0200 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: +i2s1 { + status = okay; + pinctrl-0 = pmx_audio1_i2s1_spdifo; + pinctrl-names = default; +}; Please also add the external clock connected from si5351. Hi Sebastian and Russell,

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-31 Thread Russell King - ARM Linux
On Sat, Aug 31, 2013 at 12:51:28PM +0200, Jean-Francois Moine wrote: Hi Sebastian and Russell, I tried it on my Cubox (si5351 2), and I have problems with HDMI output and some audio streams like webradios with sample rates 32 or 22.05 kHz. Some TVs will only accept certain sample rates - my

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-31 Thread Jean-Francois Moine
On Sat, 31 Aug 2013 12:24:31 +0100 Russell King - ARM Linux li...@arm.linux.org.uk wrote: According to the Dove specification, the audio controller works with the samples rates 44.1, 48 and 96 kHz, so, I don't see the usage of the external clock, except when using the two audio controllers

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-31 Thread Russell King - ARM Linux
On Sat, Aug 31, 2013 at 01:55:19PM +0200, Jean-Francois Moine wrote: The last case was when using the two audio controllers with different sample rates (I should have added in the set [44.1, 48, 96 kHz]). Then, with or without the availability of external clocks, both controllers will set the

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-28 Thread Sebastian Hesselbarth
On 08/28/2013 11:35 AM, Jean-Francois Moine wrote: This patch activates the audio device of the Cubox and sets the i2s and S/PDIF pins. Signed-off-by: Jean-Francois Moine --- arch/arm/boot/dts/dove-cubox.dts | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-28 Thread Jean-Francois Moine
This patch activates the audio device of the Cubox and sets the i2s and S/PDIF pins. Signed-off-by: Jean-Francois Moine --- arch/arm/boot/dts/dove-cubox.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/dove-cubox.dts

[PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-28 Thread Jean-Francois Moine
This patch activates the audio device of the Cubox and sets the i2s and S/PDIF pins. Signed-off-by: Jean-Francois Moine moin...@free.fr --- arch/arm/boot/dts/dove-cubox.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/dove-cubox.dts

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-28 Thread Sebastian Hesselbarth
On 08/28/2013 11:35 AM, Jean-Francois Moine wrote: This patch activates the audio device of the Cubox and sets the i2s and S/PDIF pins. Signed-off-by: Jean-Francois Moine moin...@free.fr --- arch/arm/boot/dts/dove-cubox.dts | 13 + 1 file changed, 13