Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-10 Thread Linus Walleij
On Tue, Apr 8, 2014 at 8:39 PM, Bjorn Andersson wrote: > On Tue, Apr 8, 2014 at 7:18 AM, Timur Tabi wrote: >> Back in July, Qualcomm submitted a patch that added this information into >> the device tree: >> >> http://marc.info/?t=13718516613=1=2 >> >> However, this was rejected. Now it

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-10 Thread Linus Walleij
On Tue, Apr 8, 2014 at 8:39 PM, Bjorn Andersson bj...@kryo.se wrote: On Tue, Apr 8, 2014 at 7:18 AM, Timur Tabi ti...@codeaurora.org wrote: Back in July, Qualcomm submitted a patch that added this information into the device tree: http://marc.info/?t=13718516613r=1w=2 However, this was

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Bjorn Andersson
On Tue, Apr 8, 2014 at 7:18 AM, Timur Tabi wrote: > On 04/08/2014 08:46 AM, Ivan T. Ivanov wrote: >>> >>> >This patch adds that same exact information into the device tree. Why >>> >are we duplicating that information? Why add it to the device tree when >>> >it's already in the driver (and

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Timur Tabi
On 04/08/2014 09:18 AM, Timur Tabi wrote: Back in July, Qualcomm submitted a patch that added this information into the device tree: http://marc.info/?t=13718516613=1=2 However, this was rejected. Now it appears that this information is again being added to the device tree, but it's

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Timur Tabi
On 04/08/2014 08:46 AM, Ivan T. Ivanov wrote: >This patch adds that same exact information into the device tree. Why >are we duplicating that information? Why add it to the device tree when >it's already in the driver (and already working). Probably. It was my natural way of thinking. Pin

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Ivan T. Ivanov
On Tue, 2014-04-08 at 07:33 -0500, Timur Tabi wrote: > Ivan T. Ivanov wrote: > >> >I'm confused by this. Isn't this information already defined in the > >> >pinctrl-msm8x74.c driver? > >> > > >> >static const char * const blsp_spi8_groups[] = { > >> > "gpio45", "gpio46", "gpio47", "gpio48" >

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Timur Tabi
Ivan T. Ivanov wrote: >I'm confused by this. Isn't this information already defined in the >pinctrl-msm8x74.c driver? > >static const char * const blsp_spi8_groups[] = { > "gpio45", "gpio46", "gpio47", "gpio48" >}; I am not sure that I understand the question. This is one of possible ways

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Ivan T. Ivanov
Hi, On Mon, 2014-04-07 at 18:53 -0500, Timur Tabi wrote: > On Thu, Feb 6, 2014 at 9:28 AM, Ivan T. Ivanov wrote: > > + spi8_default: spi8_default { > > + mosi { > > + pins = "gpio45"; > > +

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Timur Tabi
On Thu, Feb 6, 2014 at 9:28 AM, Ivan T. Ivanov wrote: > + msmgpio: pinctrl@fd51 { > + compatible = "qcom,msm8974-pinctrl"; > + reg = <0xfd51 0x4000>; > + gpio-controller; > + #gpio-cells

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Timur Tabi
On Thu, Feb 6, 2014 at 9:28 AM, Ivan T. Ivanov iiva...@mm-sol.com wrote: + msmgpio: pinctrl@fd51 { + compatible = qcom,msm8974-pinctrl; + reg = 0xfd51 0x4000; + gpio-controller; +

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Ivan T. Ivanov
Hi, On Mon, 2014-04-07 at 18:53 -0500, Timur Tabi wrote: On Thu, Feb 6, 2014 at 9:28 AM, Ivan T. Ivanov iiva...@mm-sol.com wrote: + spi8_default: spi8_default { + mosi { + pins = gpio45; +

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Timur Tabi
Ivan T. Ivanov wrote: I'm confused by this. Isn't this information already defined in the pinctrl-msm8x74.c driver? static const char * const blsp_spi8_groups[] = { gpio45, gpio46, gpio47, gpio48 }; I am not sure that I understand the question. This is one of possible ways to describe

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Ivan T. Ivanov
On Tue, 2014-04-08 at 07:33 -0500, Timur Tabi wrote: Ivan T. Ivanov wrote: I'm confused by this. Isn't this information already defined in the pinctrl-msm8x74.c driver? static const char * const blsp_spi8_groups[] = { gpio45, gpio46, gpio47, gpio48 }; I am not sure that I

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Timur Tabi
On 04/08/2014 08:46 AM, Ivan T. Ivanov wrote: This patch adds that same exact information into the device tree. Why are we duplicating that information? Why add it to the device tree when it's already in the driver (and already working). Probably. It was my natural way of thinking. Pin have

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Timur Tabi
On 04/08/2014 09:18 AM, Timur Tabi wrote: Back in July, Qualcomm submitted a patch that added this information into the device tree: http://marc.info/?t=13718516613r=1w=2 However, this was rejected. Now it appears that this information is again being added to the device tree, but it's

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-08 Thread Bjorn Andersson
On Tue, Apr 8, 2014 at 7:18 AM, Timur Tabi ti...@codeaurora.org wrote: On 04/08/2014 08:46 AM, Ivan T. Ivanov wrote: This patch adds that same exact information into the device tree. Why are we duplicating that information? Why add it to the device tree when it's already in the driver (and

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-07 Thread Timur Tabi
On Thu, Feb 6, 2014 at 9:28 AM, Ivan T. Ivanov wrote: > + spi8_default: spi8_default { > + mosi { > + pins = "gpio45"; > + function = "blsp_spi8"; > +

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-04-07 Thread Timur Tabi
On Thu, Feb 6, 2014 at 9:28 AM, Ivan T. Ivanov iiva...@mm-sol.com wrote: + spi8_default: spi8_default { + mosi { + pins = gpio45; + function = blsp_spi8; +

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-25 Thread Kumar Gala
On Feb 24, 2014, at 3:57 AM, Linus Walleij wrote: > On Thu, Feb 6, 2014 at 4:28 PM, Ivan T. Ivanov wrote: > >> From: "Ivan T. Ivanov" >> >> Add the pin control node and pin definitions of SPI8. >> >> Signed-off-by: Ivan T. Ivanov > > Acked-by: Linus Walleij > > Kumar, please take this

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-25 Thread Kumar Gala
On Feb 24, 2014, at 3:57 AM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Feb 6, 2014 at 4:28 PM, Ivan T. Ivanov iiva...@mm-sol.com wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Add the pin control node and pin definitions of SPI8. Signed-off-by: Ivan T. Ivanov

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-24 Thread Linus Walleij
On Thu, Feb 6, 2014 at 4:28 PM, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Add the pin control node and pin definitions of SPI8. > > Signed-off-by: Ivan T. Ivanov Acked-by: Linus Walleij Kumar, please take this through your qcom tree. Yours, Linus Walleij -- To unsubscribe from

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-24 Thread Linus Walleij
On Thu, Feb 6, 2014 at 4:28 PM, Ivan T. Ivanov iiva...@mm-sol.com wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Add the pin control node and pin definitions of SPI8. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com Acked-by: Linus Walleij linus.wall...@linaro.org Kumar, please take this

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-11 Thread Kumar Gala
On Feb 10, 2014, at 12:55 PM, Bjorn Andersson wrote: > On Thu, Feb 6, 2014 at 7:28 AM, Ivan T. Ivanov wrote: >> From: "Ivan T. Ivanov" >> >> Add the pin control node and pin definitions of SPI8. >> >> Signed-off-by: Ivan T. Ivanov >> --- >> arch/arm/boot/dts/qcom-msm8974.dtsi | 29

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-11 Thread Kumar Gala
On Feb 10, 2014, at 12:55 PM, Bjorn Andersson bj...@kryo.se wrote: On Thu, Feb 6, 2014 at 7:28 AM, Ivan T. Ivanov iiva...@mm-sol.com wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Add the pin control node and pin definitions of SPI8. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-10 Thread Bjorn Andersson
On Thu, Feb 6, 2014 at 7:28 AM, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Add the pin control node and pin definitions of SPI8. > > Signed-off-by: Ivan T. Ivanov > --- > arch/arm/boot/dts/qcom-msm8974.dtsi | 29 + > 1 file changed, 29 insertions(+) > >

Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-10 Thread Bjorn Andersson
On Thu, Feb 6, 2014 at 7:28 AM, Ivan T. Ivanov iiva...@mm-sol.com wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Add the pin control node and pin definitions of SPI8. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- arch/arm/boot/dts/qcom-msm8974.dtsi | 29

[PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-06 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Add the pin control node and pin definitions of SPI8. Signed-off-by: Ivan T. Ivanov --- arch/arm/boot/dts/qcom-msm8974.dtsi | 29 + 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi

[PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

2014-02-06 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Add the pin control node and pin definitions of SPI8. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- arch/arm/boot/dts/qcom-msm8974.dtsi | 29 + 1 file changed, 29 insertions(+) diff --git