Re: [PATCH 2/2] ASoC: rt5677: make ACPI property names match _DSD

2019-04-02 Thread Mark Brown
On Tue, Apr 02, 2019 at 09:52:56AM -0600, Fletcher Woodruff wrote: > On Mon, Apr 1, 2019 at 11:06 PM Mark Brown wrote: > > It'd be fine to add your new DT style properties but this > > might break existing systems. > That said, I agree it would be safer to use the idiomatic ACPI names, and then

Re: [PATCH 2/2] ASoC: rt5677: make ACPI property names match _DSD

2019-04-02 Thread Fletcher Woodruff
On Mon, Apr 1, 2019 at 11:06 PM Mark Brown wrote: > On Mon, Apr 01, 2019 at 02:55:19PM -0600, Fletcher Woodruff wrote: > > The rt5677 driver is using the wrong property names to read from ACPI. > > Update the property names to match those from _DSD, so that the correct > > GPIO pin numbers are rea

Re: [PATCH 2/2] ASoC: rt5677: make ACPI property names match _DSD

2019-04-01 Thread Mark Brown
On Mon, Apr 01, 2019 at 02:55:19PM -0600, Fletcher Woodruff wrote: > The rt5677 driver is using the wrong property names to read from ACPI. > Update the property names to match those from _DSD, so that the correct > GPIO pin numbers are read and that plug-detection works. > With this patch, pluggi

[PATCH 2/2] ASoC: rt5677: make ACPI property names match _DSD

2019-04-01 Thread Fletcher Woodruff
The rt5677 driver is using the wrong property names to read from ACPI. Update the property names to match those from _DSD, so that the correct GPIO pin numbers are read and that plug-detection works. With this patch, plugging and unplugging the headphone jack switches between headphones and speake