Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-18 Thread Andy Shevchenko
On Mon, Feb 18, 2019 at 01:08:51AM -0800, Life is hard, and then you die wrote: > On Sat, Feb 16, 2019 at 02:44:26AM +0200, Andy Shevchenko wrote: > > On Sun, Feb 10, 2019 at 03:18:34AM -0800, Life is hard, and then you die > > wrote: > > > On Wed, Feb 06, 2019 at 10:22:56PM +0200, Andy

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-18 Thread Life is hard, and then you die
On Sat, Feb 16, 2019 at 02:44:26AM +0200, Andy Shevchenko wrote: > On Sun, Feb 10, 2019 at 03:18:34AM -0800, Life is hard, and then you die > wrote: > > On Wed, Feb 06, 2019 at 10:22:56PM +0200, Andy Shevchenko wrote: > > > On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote: > > >

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-15 Thread Andy Shevchenko
On Sun, Feb 10, 2019 at 03:18:34AM -0800, Life is hard, and then you die wrote: > On Wed, Feb 06, 2019 at 10:22:56PM +0200, Andy Shevchenko wrote: > > On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote: > > > +#define debug_print(mask, fmt, ...) \ > > > + do { \ > > > + if

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-10 Thread Life is hard, and then you die
Hi Andy, On Wed, Feb 06, 2019 at 10:22:56PM +0200, Andy Shevchenko wrote: > On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB,

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-06 Thread Andy Shevchenko
On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote: > The keyboard and trackpad on recent MacBook's (since 8,1) and > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > of USB, as previously. The higher level protocol is not publicly > documented and hence has

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-05 Thread Andy Shevchenko
On Tue, Feb 5, 2019 at 4:21 PM Life is hard, and then you die wrote: > > > +config KEYBOARD_APPLESPI > > > + tristate "Apple SPI keyboard and trackpad" > > > > > + depends on (X86 && ACPI && SPI) || COMPILE_TEST > > > > COMPILE_TEST more or less makes sense in conjunction with architecture

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-05 Thread Life is hard, and then you die
Hi Andy, On Tue, Feb 05, 2019 at 01:45:22PM +0200, Andy Shevchenko wrote: > On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB,

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-05 Thread Life is hard, and then you die
Hi Dan, On Tue, Feb 05, 2019 at 01:21:10PM +0300, Dan Carpenter wrote: > Hi Ronald, > > Thank you for the patch! Perhaps something to improve: > > url: >

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-05 Thread Andy Shevchenko
On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote: > The keyboard and trackpad on recent MacBook's (since 8,1) and > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > of USB, as previously. The higher level protocol is not publicly > documented and hence has

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-05 Thread Dan Carpenter
Hi Ronald, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Ronald-Tschal-r/drm-bridge-sil_sii8620-depend-on-INPUT-instead-of-selecting-it/20190205-003319 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next smatch

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-04 Thread kbuild test robot
Hi Ronald, Thank you for the patch! Yet something to improve: [auto build test ERROR on input/next] [also build test ERROR on v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-04 Thread kbuild test robot
Hi Ronald, Thank you for the patch! Yet something to improve: [auto build test ERROR on input/next] [also build test ERROR on v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-04 Thread Ronald Tschalär
The keyboard and trackpad on recent MacBook's (since 8,1) and MacBookPro's (13,* and 14,*) are attached to an SPI controller instead of USB, as previously. The higher level protocol is not publicly documented and hence has been reverse engineered. As a consequence there are still a number of