Re: Thoughts on sharing KVM tracepoints [was:Re: [PATCH 2/2] KVM: nVMX: trace nested vm entry]

2021-01-27 Thread Paolo Bonzini
On 25/01/21 22:01, Sean Christopherson wrote: I 100% think that VMX and SVM should share the bulk of the code. Improvements to VMX almost always apply in some way to SVM, and vice versa. I agree. IMO, after debugging a few times, associating error_code with the event being injected is

Re: Thoughts on sharing KVM tracepoints [was:Re: [PATCH 2/2] KVM: nVMX: trace nested vm entry]

2021-01-25 Thread Sean Christopherson
On Mon, Jan 25, 2021, Maxim Levitsky wrote: > On Thu, 2021-01-21 at 14:27 -0800, Sean Christopherson wrote: > > I still don't see why VMX can't share this with SVM. "npt' can easily be > > "tdp", > > differentiating between VMCB and VMCS can be down with ISA, and VMX can > > give 0 > > for

Thoughts on sharing KVM tracepoints [was:Re: [PATCH 2/2] KVM: nVMX: trace nested vm entry]

2021-01-25 Thread Maxim Levitsky
On Thu, 2021-01-21 at 14:27 -0800, Sean Christopherson wrote: > On Thu, Jan 21, 2021, Maxim Levitsky wrote: > > This is very helpful to debug nested VMX issues. > > > > Signed-off-by: Maxim Levitsky > > --- > > arch/x86/kvm/trace.h | 30 ++ > >

Re: [PATCH 2/2] KVM: nVMX: trace nested vm entry

2021-01-21 Thread Sean Christopherson
On Thu, Jan 21, 2021, Maxim Levitsky wrote: > This is very helpful to debug nested VMX issues. > > Signed-off-by: Maxim Levitsky > --- > arch/x86/kvm/trace.h | 30 ++ > arch/x86/kvm/vmx/nested.c | 5 + > arch/x86/kvm/x86.c| 3 ++- > 3 files

[PATCH 2/2] KVM: nVMX: trace nested vm entry

2021-01-21 Thread Maxim Levitsky
This is very helpful to debug nested VMX issues. Signed-off-by: Maxim Levitsky --- arch/x86/kvm/trace.h | 30 ++ arch/x86/kvm/vmx/nested.c | 5 + arch/x86/kvm/x86.c| 3 ++- 3 files changed, 37 insertions(+), 1 deletion(-) diff --git