Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 05:59 AM, Christian Ruppert wrote: > On Fri, Jun 21, 2013 at 03:17:33PM -0600, Stephen Warren wrote: ... > To define some terminology, let's call a set of pins affected by the > same register / bit field a "port". Well, the terminology "group" already exists for this really, but I

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Tue, Jun 25, 2013 at 5:39 PM, Stephen Warren wrote: > On 06/25/2013 09:28 AM, Linus Walleij wrote: >> But I do seem to recall some endless discussions about this, >> I think we need to agree to disagree. > > But the whole point of a subsystem is to provide clear common semantics > across all

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Tue, Jun 25, 2013 at 5:31 PM, Stephen Warren wrote: > On 06/25/2013 08:56 AM, Linus Walleij wrote: >> On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren >> wrote: >>> On 06/20/2013 05:57 AM, Christian Ruppert wrote: >> Your remark seems to reflect one of the following two hardware

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 08:56 AM, Linus Walleij wrote: > On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren > wrote: >> On 06/20/2013 05:57 AM, Christian Ruppert wrote: > >>> Your remark seems to reflect one of the following two hardware >>> architectures: >>> >>>

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 09:28 AM, Linus Walleij wrote: > On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren > wrote: > >> And finally, I don't really like using pin groups for the purpose of >> defining these mappings, since I intended them to purely represent the >> mapping from register fields to the set

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren wrote: > And finally, I don't really like using pin groups for the purpose of > defining these mappings, since I intended them to purely represent the > mapping from register fields to the set of affected pins. However, I can > see an argument for

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 08:32 AM, Linus Walleij wrote: > On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren > wrote: >> On 06/20/2013 05:57 AM, Christian Ruppert wrote: > >> The Linux pinctrl subsystem specifically doesn't provide mutual >> exclusion between "mux function" and GPIO usage within a pin

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 08:27 AM, Linus Walleij wrote: > On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren > wrote: > >> When I pushed for the concept of groups, I intended it to mean precisely >> one single thing. The points below describe this. >> >> 1) A pin is a single pin/ball/pad on the package. >>

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren wrote: > On 06/20/2013 05:57 AM, Christian Ruppert wrote: >> Your remark seems to reflect one of the following two hardware >> architectures: >> >> +- SPI >> Physical pins ---

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren wrote: > On 06/20/2013 05:57 AM, Christian Ruppert wrote: > The Linux pinctrl subsystem specifically doesn't provide mutual > exclusion between "mux function" and GPIO usage within a pin group, > although perhaps a driver could internally. It

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren wrote: > When I pushed for the concept of groups, I intended it to mean precisely > one single thing. The points below describe this. > > 1) A pin is a single pin/ball/pad on the package. > > 2) Some register fields affect just a single pin. For

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Christian Ruppert
On Fri, Jun 21, 2013 at 03:17:33PM -0600, Stephen Warren wrote: > On 06/20/2013 05:57 AM, Christian Ruppert wrote: > > Hello Stephen, > > > > On Wed, Jun 19, 2013 at 12:27:56PM -0600, Stephen Warren wrote: > >> On 06/19/2013 12:10 PM, Stephen Warren wrote: > >>> On 06/14/2013 03:12 AM, Christian

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Christian Ruppert
On Fri, Jun 21, 2013 at 03:17:33PM -0600, Stephen Warren wrote: On 06/20/2013 05:57 AM, Christian Ruppert wrote: Hello Stephen, On Wed, Jun 19, 2013 at 12:27:56PM -0600, Stephen Warren wrote: On 06/19/2013 12:10 PM, Stephen Warren wrote: On 06/14/2013 03:12 AM, Christian Ruppert wrote:

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren swar...@wwwdotorg.org wrote: When I pushed for the concept of groups, I intended it to mean precisely one single thing. The points below describe this. 1) A pin is a single pin/ball/pad on the package. 2) Some register fields affect just a

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 06/20/2013 05:57 AM, Christian Ruppert wrote: The Linux pinctrl subsystem specifically doesn't provide mutual exclusion between mux function and GPIO usage within a pin group, although perhaps a driver could

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 06/20/2013 05:57 AM, Christian Ruppert wrote: Your remark seems to reflect one of the following two hardware architectures: +- SPI Physical

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 08:27 AM, Linus Walleij wrote: On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren swar...@wwwdotorg.org wrote: When I pushed for the concept of groups, I intended it to mean precisely one single thing. The points below describe this. 1) A pin is a single pin/ball/pad on the

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 08:32 AM, Linus Walleij wrote: On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 06/20/2013 05:57 AM, Christian Ruppert wrote: The Linux pinctrl subsystem specifically doesn't provide mutual exclusion between mux function and GPIO usage within a

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren swar...@wwwdotorg.org wrote: And finally, I don't really like using pin groups for the purpose of defining these mappings, since I intended them to purely represent the mapping from register fields to the set of affected pins. However, I can

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 09:28 AM, Linus Walleij wrote: On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren swar...@wwwdotorg.org wrote: And finally, I don't really like using pin groups for the purpose of defining these mappings, since I intended them to purely represent the mapping from register

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 08:56 AM, Linus Walleij wrote: On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 06/20/2013 05:57 AM, Christian Ruppert wrote: Your remark seems to reflect one of the following two hardware architectures:

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Tue, Jun 25, 2013 at 5:31 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 06/25/2013 08:56 AM, Linus Walleij wrote: On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 06/20/2013 05:57 AM, Christian Ruppert wrote: Your remark seems to reflect one of the

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Linus Walleij
On Tue, Jun 25, 2013 at 5:39 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 06/25/2013 09:28 AM, Linus Walleij wrote: But I do seem to recall some endless discussions about this, I think we need to agree to disagree. But the whole point of a subsystem is to provide clear common semantics

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-25 Thread Stephen Warren
On 06/25/2013 05:59 AM, Christian Ruppert wrote: On Fri, Jun 21, 2013 at 03:17:33PM -0600, Stephen Warren wrote: ... To define some terminology, let's call a set of pins affected by the same register / bit field a port. Well, the terminology group already exists for this really, but I suppose

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-21 Thread Stephen Warren
On 06/20/2013 05:57 AM, Christian Ruppert wrote: > Hello Stephen, > > On Wed, Jun 19, 2013 at 12:27:56PM -0600, Stephen Warren wrote: >> On 06/19/2013 12:10 PM, Stephen Warren wrote: >>> On 06/14/2013 03:12 AM, Christian Ruppert wrote: On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-21 Thread Stephen Warren
On 06/20/2013 05:57 AM, Christian Ruppert wrote: Hello Stephen, On Wed, Jun 19, 2013 at 12:27:56PM -0600, Stephen Warren wrote: On 06/19/2013 12:10 PM, Stephen Warren wrote: On 06/14/2013 03:12 AM, Christian Ruppert wrote: On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: On

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-20 Thread Christian Ruppert
Hello Stephen, On Wed, Jun 19, 2013 at 12:27:56PM -0600, Stephen Warren wrote: > On 06/19/2013 12:10 PM, Stephen Warren wrote: > > On 06/14/2013 03:12 AM, Christian Ruppert wrote: > >> On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: > >>> On 06/13/2013 06:55 AM, Christian Ruppert

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-20 Thread Christian Ruppert
Hello Stephen, On Wed, Jun 19, 2013 at 12:27:56PM -0600, Stephen Warren wrote: On 06/19/2013 12:10 PM, Stephen Warren wrote: On 06/14/2013 03:12 AM, Christian Ruppert wrote: On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: On 06/13/2013 06:55 AM, Christian Ruppert wrote:

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-19 Thread Stephen Warren
On 06/19/2013 12:10 PM, Stephen Warren wrote: > On 06/14/2013 03:12 AM, Christian Ruppert wrote: >> On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: >>> On 06/13/2013 06:55 AM, Christian Ruppert wrote: This patch adds the infrastructure required to register non-linear gpio

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-19 Thread Stephen Warren
On 06/14/2013 03:12 AM, Christian Ruppert wrote: > On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: >> On 06/13/2013 06:55 AM, Christian Ruppert wrote: >>> This patch adds the infrastructure required to register non-linear gpio >>> ranges through gpiolib and the standard GPIO device

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-19 Thread Stephen Warren
On 06/14/2013 03:12 AM, Christian Ruppert wrote: On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: On 06/13/2013 06:55 AM, Christian Ruppert wrote: This patch adds the infrastructure required to register non-linear gpio ranges through gpiolib and the standard GPIO device tree

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-19 Thread Stephen Warren
On 06/19/2013 12:10 PM, Stephen Warren wrote: On 06/14/2013 03:12 AM, Christian Ruppert wrote: On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: On 06/13/2013 06:55 AM, Christian Ruppert wrote: This patch adds the infrastructure required to register non-linear gpio ranges

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-17 Thread Christian Ruppert
On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: > On 06/13/2013 06:55 AM, Christian Ruppert wrote: > [...] > > diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt > > b/Documentation/devicetree/bindings/gpio/gpio.txt > > > +In addition, named groups of pins can be mapped

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-17 Thread Christian Ruppert
On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: On 06/13/2013 06:55 AM, Christian Ruppert wrote: [...] diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt +In addition, named groups of pins can be mapped to pin

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-14 Thread Christian Ruppert
On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: > On 06/13/2013 06:55 AM, Christian Ruppert wrote: > > This patch adds the infrastructure required to register non-linear gpio > > ranges through gpiolib and the standard GPIO device tree bindings. > > That's not exactly true. The

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-14 Thread Christian Ruppert
On Thu, Jun 13, 2013 at 03:38:09PM -0600, Stephen Warren wrote: On 06/13/2013 06:55 AM, Christian Ruppert wrote: This patch adds the infrastructure required to register non-linear gpio ranges through gpiolib and the standard GPIO device tree bindings. That's not exactly true. The existing

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-13 Thread Stephen Warren
On 06/13/2013 06:55 AM, Christian Ruppert wrote: > This patch adds the infrastructure required to register non-linear gpio > ranges through gpiolib and the standard GPIO device tree bindings. That's not exactly true. The existing gpio-ranges property already allows non-linear ranges to be

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 2:55 PM, Christian Ruppert wrote: > This patch adds the infrastructure required to register non-linear gpio > ranges through gpiolib and the standard GPIO device tree bindings. > > Signed-off-by: Christian Ruppert Splendid. I'll just wait some more time before applying

[PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-13 Thread Christian Ruppert
This patch adds the infrastructure required to register non-linear gpio ranges through gpiolib and the standard GPIO device tree bindings. Signed-off-by: Christian Ruppert --- Documentation/devicetree/bindings/gpio/gpio.txt | 37 ++ drivers/gpio/gpiolib-of.c

[PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-13 Thread Christian Ruppert
This patch adds the infrastructure required to register non-linear gpio ranges through gpiolib and the standard GPIO device tree bindings. Signed-off-by: Christian Ruppert christian.rupp...@abilis.com --- Documentation/devicetree/bindings/gpio/gpio.txt | 37 ++

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 2:55 PM, Christian Ruppert christian.rupp...@abilis.com wrote: This patch adds the infrastructure required to register non-linear gpio ranges through gpiolib and the standard GPIO device tree bindings. Signed-off-by: Christian Ruppert christian.rupp...@abilis.com

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-13 Thread Stephen Warren
On 06/13/2013 06:55 AM, Christian Ruppert wrote: This patch adds the infrastructure required to register non-linear gpio ranges through gpiolib and the standard GPIO device tree bindings. That's not exactly true. The existing gpio-ranges property already allows non-linear ranges to be