Re: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-11 Thread Herbert Xu
Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> wrote: > > True, but the assignment for "dev" above also casts this void * to > struct net_device *: > >dev = (struct net_device *) >(((long)p + NETDEV_ALIGN_CONST) & ~NETDEV_ALIGN_CONST); >dev->padded = (char *)dev -

Re: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-11 Thread Herbert Xu
Waskiewicz Jr, Peter P [EMAIL PROTECTED] wrote: True, but the assignment for dev above also casts this void * to struct net_device *: dev = (struct net_device *) (((long)p + NETDEV_ALIGN_CONST) ~NETDEV_ALIGN_CONST); dev-padded = (char *)dev - (char *)p;

Re: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-10 Thread Evgeniy Polyakov
On Tue, Apr 10, 2007 at 08:41:49AM -0700, Waskiewicz Jr, Peter P ([EMAIL PROTECTED]) wrote: > > On Mon, Apr 09, 2007 at 02:28:41PM -0700, Peter P Waskiewicz > > Jr ([EMAIL PROTECTED]) wrote: > > > + alloc_size = (sizeof(struct net_device_subqueue) * queue_count); > > > + > > > +

RE: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-10 Thread Waskiewicz Jr, Peter P
> On Mon, Apr 09, 2007 at 02:28:41PM -0700, Peter P Waskiewicz > Jr ([EMAIL PROTECTED]) wrote: > > + alloc_size = (sizeof(struct net_device_subqueue) * queue_count); > > + > > + p = kzalloc(alloc_size, GFP_KERNEL); > > + if (!p) { > > + printk(KERN_ERR "alloc_netdev: Unable to >

Re: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-10 Thread Herbert Xu
Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> wrote: > >> >@@ -3356,6 +3370,7 @@ void free_netdev(struct net_device *dev) >> > /* will free via device release */ >> > put_device(>dev); >> > #else >> >+kfree((char *)dev->egress_subqueue); >> > kfree((char *)dev - dev->padded); >> >

Re: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-10 Thread Evgeniy Polyakov
On Mon, Apr 09, 2007 at 02:28:41PM -0700, Peter P Waskiewicz Jr ([EMAIL PROTECTED]) wrote: > + alloc_size = (sizeof(struct net_device_subqueue) * queue_count); > + > + p = kzalloc(alloc_size, GFP_KERNEL); > + if (!p) { > + printk(KERN_ERR "alloc_netdev: Unable to allocate

Re: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-10 Thread Evgeniy Polyakov
On Mon, Apr 09, 2007 at 02:28:41PM -0700, Peter P Waskiewicz Jr ([EMAIL PROTECTED]) wrote: + alloc_size = (sizeof(struct net_device_subqueue) * queue_count); + + p = kzalloc(alloc_size, GFP_KERNEL); + if (!p) { + printk(KERN_ERR alloc_netdev: Unable to allocate

Re: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-10 Thread Herbert Xu
Waskiewicz Jr, Peter P [EMAIL PROTECTED] wrote: @@ -3356,6 +3370,7 @@ void free_netdev(struct net_device *dev) /* will free via device release */ put_device(dev-dev); #else +kfree((char *)dev-egress_subqueue); kfree((char *)dev - dev-padded); #endif } Ahem.

RE: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-10 Thread Waskiewicz Jr, Peter P
On Mon, Apr 09, 2007 at 02:28:41PM -0700, Peter P Waskiewicz Jr ([EMAIL PROTECTED]) wrote: + alloc_size = (sizeof(struct net_device_subqueue) * queue_count); + + p = kzalloc(alloc_size, GFP_KERNEL); + if (!p) { + printk(KERN_ERR alloc_netdev: Unable to allocate

Re: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-10 Thread Evgeniy Polyakov
On Tue, Apr 10, 2007 at 08:41:49AM -0700, Waskiewicz Jr, Peter P ([EMAIL PROTECTED]) wrote: On Mon, Apr 09, 2007 at 02:28:41PM -0700, Peter P Waskiewicz Jr ([EMAIL PROTECTED]) wrote: + alloc_size = (sizeof(struct net_device_subqueue) * queue_count); + + p =

RE: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-09 Thread Waskiewicz Jr, Peter P
> Hi, > > > On Apr 9 2007 14:28, Peter P Waskiewicz Jr wrote: > >@@ -3345,6 +3358,7 @@ void free_netdev(struct net_device *dev) { > >#ifdef CONFIG_SYSFS > > /* Compatibility with error handling in drivers */ > >+kfree((char *)dev->egress_subqueue); > > if (dev->reg_state ==

Re: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-09 Thread Jan Engelhardt
Hi, On Apr 9 2007 14:28, Peter P Waskiewicz Jr wrote: >@@ -3345,6 +3358,7 @@ void free_netdev(struct net_device *dev) > { > #ifdef CONFIG_SYSFS > /* Compatibility with error handling in drivers */ >+ kfree((char *)dev->egress_subqueue); > if (dev->reg_state ==

[PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-09 Thread Peter P Waskiewicz Jr
From: Peter P Waskiewicz Jr <[EMAIL PROTECTED]> Added an API and associated supporting routines for multiqueue network devices. This allows network devices supporting multiple TX queues to configure each queue within the netdevice and manage each queue independantly. Changes to the PRIO Qdisc

Re: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Mon, 9 Apr 2007 13:47:58 -0700 > Will do. On a side note, I don't see my patches landing on vger again. > Did they get munched, or is majordomo lagging a bit? I forwarded you one of the bounces. - To unsubscribe from this list: send the

RE: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread Waskiewicz Jr, Peter P
bject: Re: [PATCH 2/2] NET: Multiqueue network device support. > > From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> > Date: Mon, 9 Apr 2007 13:43:11 -0700 > > > True, but the assignment for "dev" above also casts this void * to &

Re: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Mon, 9 Apr 2007 13:43:11 -0700 > True, but the assignment for "dev" above also casts this void * to > struct net_device *: > > dev = (struct net_device *) > (((long)p + NETDEV_ALIGN_CONST) & ~NETDEV_ALIGN_CONST); >

RE: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread Waskiewicz Jr, Peter P
bject: Re: [PATCH 2/2] NET: Multiqueue network device support. > > From: Peter P.Waskiewicz Jr. <[EMAIL PROTECTED]> > Date: Mon, 09 Apr 2007 13:50:52 -0700 > > > From: Peter P. Waskiewicz Jr. <[EMAIL PROTECTED]> > > > > Added an API and associated support

Re: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread David Miller
From: Peter P.Waskiewicz Jr. <[EMAIL PROTECTED]> Date: Mon, 09 Apr 2007 13:50:52 -0700 > From: Peter P. Waskiewicz Jr. <[EMAIL PROTECTED]> > > Added an API and associated supporting routines for multiqueue network > devices. > This allows network devices supporting multiple TX queues to

Re: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread David Miller
From: Peter P.Waskiewicz Jr. [EMAIL PROTECTED] Date: Mon, 09 Apr 2007 13:50:52 -0700 From: Peter P. Waskiewicz Jr. [EMAIL PROTECTED] Added an API and associated supporting routines for multiqueue network devices. This allows network devices supporting multiple TX queues to configure each

RE: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread Waskiewicz Jr, Peter P
: Multiqueue network device support. From: Peter P.Waskiewicz Jr. [EMAIL PROTECTED] Date: Mon, 09 Apr 2007 13:50:52 -0700 From: Peter P. Waskiewicz Jr. [EMAIL PROTECTED] Added an API and associated supporting routines for multiqueue network devices. This allows network devices

Re: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 9 Apr 2007 13:43:11 -0700 True, but the assignment for dev above also casts this void * to struct net_device *: dev = (struct net_device *) (((long)p + NETDEV_ALIGN_CONST) ~NETDEV_ALIGN_CONST);

RE: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread Waskiewicz Jr, Peter P
: Multiqueue network device support. From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 9 Apr 2007 13:43:11 -0700 True, but the assignment for dev above also casts this void * to struct net_device *: dev = (struct net_device *) (((long)p

Re: [PATCH 2/2] NET: Multiqueue network device support.

2007-04-09 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 9 Apr 2007 13:47:58 -0700 Will do. On a side note, I don't see my patches landing on vger again. Did they get munched, or is majordomo lagging a bit? I forwarded you one of the bounces. - To unsubscribe from this list: send the line

[PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-09 Thread Peter P Waskiewicz Jr
From: Peter P Waskiewicz Jr [EMAIL PROTECTED] Added an API and associated supporting routines for multiqueue network devices. This allows network devices supporting multiple TX queues to configure each queue within the netdevice and manage each queue independantly. Changes to the PRIO Qdisc also

Re: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-09 Thread Jan Engelhardt
Hi, On Apr 9 2007 14:28, Peter P Waskiewicz Jr wrote: @@ -3345,6 +3358,7 @@ void free_netdev(struct net_device *dev) { #ifdef CONFIG_SYSFS /* Compatibility with error handling in drivers */ + kfree((char *)dev-egress_subqueue); if (dev-reg_state == NETREG_UNINITIALIZED) {

RE: [PATCH 2/2] NET: Multiqueue network device support implementation.

2007-04-09 Thread Waskiewicz Jr, Peter P
Hi, On Apr 9 2007 14:28, Peter P Waskiewicz Jr wrote: @@ -3345,6 +3358,7 @@ void free_netdev(struct net_device *dev) { #ifdef CONFIG_SYSFS /* Compatibility with error handling in drivers */ +kfree((char *)dev-egress_subqueue); if (dev-reg_state == NETREG_UNINITIALIZED)