Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-07-31 Thread Michal Hocko
On Tue 30-07-19 11:05:44, Andrew Morton wrote: > On Tue, 30 Jul 2019 15:11:27 +0200 Michal Hocko wrote: > > > On Thu 23-05-19 17:57:37, Andrew Morton wrote: > > [...] > > > It does appear to me that this patch does more good than harm for the > > > totality of kernel users, so I'm inclined to

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-07-30 Thread Andrew Morton
On Tue, 30 Jul 2019 15:11:27 +0200 Michal Hocko wrote: > On Thu 23-05-19 17:57:37, Andrew Morton wrote: > [...] > > It does appear to me that this patch does more good than harm for the > > totality of kernel users, so I'm inclined to push it through and to try > > to talk Linus out of reverting

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-07-30 Thread Michal Hocko
On Thu 23-05-19 17:57:37, Andrew Morton wrote: [...] > It does appear to me that this patch does more good than harm for the > totality of kernel users, so I'm inclined to push it through and to try > to talk Linus out of reverting it again. What is the status here? I do not see the patch

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-06-21 Thread David Rientjes
On Thu, 6 Jun 2019, David Rientjes wrote: > The idea that I had was snipped from this, however, and it would be nice > to get some feedback on it: I've suggested that direct reclaim for the > purposes of hugepage allocation on the local node is never worthwhile > unless and until memory

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-06-13 Thread David Rientjes
On Fri, 7 Jun 2019, Michal Hocko wrote: > > So my proposed change would be: > > - give the page allocator a consistent indicator that compaction failed > >because we are low on memory (make COMPACT_SKIPPED really mean this), > > - if we get this in the page allocator and we are allocating

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-06-07 Thread Michal Hocko
On Thu 06-06-19 15:12:40, David Rientjes wrote: > On Wed, 5 Jun 2019, Michal Hocko wrote: > > > > That's fine, but we also must be mindful of users who have used > > > MADV_HUGEPAGE over the past four years based on its hard-coded behavior > > > that would now regress as a result. > > > >

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-06-06 Thread David Rientjes
On Wed, 5 Jun 2019, Michal Hocko wrote: > > That's fine, but we also must be mindful of users who have used > > MADV_HUGEPAGE over the past four years based on its hard-coded behavior > > that would now regress as a result. > > Absolutely, I am all for helping those usecases. First of all we

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-06-05 Thread Michal Hocko
On Fri 31-05-19 14:53:35, David Rientjes wrote: > On Fri, 31 May 2019, Michal Hocko wrote: > > > > The problem which this patch addresses has apparently gone unreported for > > > 4+ years since > > > > Can we finaly stop considering the time and focus on the what is the > > most reasonable

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-31 Thread David Rientjes
On Fri, 31 May 2019, Michal Hocko wrote: > > The problem which this patch addresses has apparently gone unreported for > > 4+ years since > > Can we finaly stop considering the time and focus on the what is the > most reasonable behavior in general case please? Conserving mistakes > based on an

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-31 Thread Michal Hocko
On Wed 29-05-19 14:24:33, David Rientjes wrote: > On Thu, 23 May 2019, Andrew Morton wrote: > > > > We are going in circles, *yes* there is a problem for potential swap > > > storms today because of the poor interaction between memory compaction > > > and > > > directed reclaim but this is a

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-29 Thread David Rientjes
On Thu, 23 May 2019, Andrew Morton wrote: > > We are going in circles, *yes* there is a problem for potential swap > > storms today because of the poor interaction between memory compaction and > > directed reclaim but this is a result of a poor API that does not allow > > userspace to specify

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-28 Thread David Rientjes
On Fri, 24 May 2019, Andrea Arcangeli wrote: > > > We are going in circles, *yes* there is a problem for potential swap > > > storms today because of the poor interaction between memory compaction > > > and > > > directed reclaim but this is a result of a poor API that does not allow > > >

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-24 Thread Andrea Arcangeli
Hello everyone, On Thu, May 23, 2019 at 05:57:37PM -0700, Andrew Morton wrote: > On Mon, 20 May 2019 10:54:16 -0700 (PDT) David Rientjes > wrote: > > > We are going in circles, *yes* there is a problem for potential swap > > storms today because of the poor interaction between memory

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-24 Thread Mel Gorman
On Mon, May 20, 2019 at 10:54:16AM -0700, David Rientjes wrote: > On Mon, 20 May 2019, Mel Gorman wrote: > > > > There was exhausting discussion subsequent to this that caused Linus to > > > have to revert the offending commit late in an rc series that is not > > > described here. > > > >

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-23 Thread Andrew Morton
On Mon, 20 May 2019 10:54:16 -0700 (PDT) David Rientjes wrote: > We are going in circles, *yes* there is a problem for potential swap > storms today because of the poor interaction between memory compaction and > directed reclaim but this is a result of a poor API that does not allow >

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-20 Thread David Rientjes
On Mon, 20 May 2019, Mel Gorman wrote: > > There was exhausting discussion subsequent to this that caused Linus to > > have to revert the offending commit late in an rc series that is not > > described here. > > Yes, at the crux of that matter was which regression introduced was more >

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-20 Thread Mel Gorman
On Wed, May 15, 2019 at 01:26:26PM -0700, David Rientjes wrote: > On Fri, 3 May 2019, Andrea Arcangeli wrote: > > > This reverts commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2. > > > > commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2 was rightfully applied > > to avoid the risk of a severe

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-15 Thread David Rientjes
On Fri, 3 May 2019, Andrea Arcangeli wrote: > This reverts commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2. > > commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2 was rightfully applied > to avoid the risk of a severe regression that was reported by the > kernel test robot at the end of the merge

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-09 Thread Mel Gorman
On Fri, May 03, 2019 at 06:31:46PM -0400, Andrea Arcangeli wrote: > This reverts commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2. > > commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2 was rightfully applied > to avoid the risk of a severe regression that was reported by the > kernel test robot at

Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-04 Thread Michal Hocko
On Fri 03-05-19 18:31:46, Andrea Arcangeli wrote: > This reverts commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2. > > commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2 was rightfully applied > to avoid the risk of a severe regression that was reported by the > kernel test robot at the end of the

[PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-03 Thread Andrea Arcangeli
This reverts commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2. commit 2f0799a0ffc033bf3cc82d5032acc3ec633464c2 was rightfully applied to avoid the risk of a severe regression that was reported by the kernel test robot at the end of the merge window. Now we understood the regression was a false