Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-04 Thread Hemant
On 09/04/2013 01:40 PM, Masami Hiramatsu wrote: > (2013/09/04 16:00), Namhyung Kim wrote: >> On Tue, 03 Sep 2013 13:07:03 +0530, Hemant Kumar wrote: >>> This patch enables perf to probe on the marker name specified on the >>> command line. >> It looks like you didn't consider prelinked libraries.

Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-04 Thread Hemant
On 09/04/2013 12:30 PM, Namhyung Kim wrote: On Tue, 03 Sep 2013 13:07:03 +0530, Hemant Kumar wrote: This patch enables perf to probe on the marker name specified on the command line. It looks like you didn't consider prelinked libraries. You need to check the address of .stapsdt.base section

Re: Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-04 Thread Masami Hiramatsu
(2013/09/04 16:00), Namhyung Kim wrote: > On Tue, 03 Sep 2013 13:07:03 +0530, Hemant Kumar wrote: >> This patch enables perf to probe on the marker name specified on the command >> line. > > It looks like you didn't consider prelinked libraries. You need to check > the address of .stapsdt.base

Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-04 Thread Namhyung Kim
On Tue, 03 Sep 2013 13:07:03 +0530, Hemant Kumar wrote: > This patch enables perf to probe on the marker name specified on the command > line. It looks like you didn't consider prelinked libraries. You need to check the address of .stapsdt.base section too. And obviously this patch ignores any

Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-04 Thread Namhyung Kim
On Tue, 03 Sep 2013 13:07:03 +0530, Hemant Kumar wrote: This patch enables perf to probe on the marker name specified on the command line. It looks like you didn't consider prelinked libraries. You need to check the address of .stapsdt.base section too. And obviously this patch ignores any

Re: Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-04 Thread Masami Hiramatsu
(2013/09/04 16:00), Namhyung Kim wrote: On Tue, 03 Sep 2013 13:07:03 +0530, Hemant Kumar wrote: This patch enables perf to probe on the marker name specified on the command line. It looks like you didn't consider prelinked libraries. You need to check the address of .stapsdt.base section

Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-04 Thread Hemant
On 09/04/2013 12:30 PM, Namhyung Kim wrote: On Tue, 03 Sep 2013 13:07:03 +0530, Hemant Kumar wrote: This patch enables perf to probe on the marker name specified on the command line. It looks like you didn't consider prelinked libraries. You need to check the address of .stapsdt.base section

Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-04 Thread Hemant
On 09/04/2013 01:40 PM, Masami Hiramatsu wrote: (2013/09/04 16:00), Namhyung Kim wrote: On Tue, 03 Sep 2013 13:07:03 +0530, Hemant Kumar wrote: This patch enables perf to probe on the marker name specified on the command line. It looks like you didn't consider prelinked libraries. You need

Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-03 Thread Masami Hiramatsu
(2013/09/03 16:37), Hemant Kumar wrote: > This patch enables perf to probe on the marker name specified on the command > line. At least you must show how this works, and how to use in the comment. Thank you, > --- > tools/perf/builtin-probe.c|7 +++ > tools/perf/util/probe-event.c |

[PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-03 Thread Hemant Kumar
This patch enables perf to probe on the marker name specified on the command line. --- tools/perf/builtin-probe.c|7 +++ tools/perf/util/probe-event.c | 11 tools/perf/util/symbol-elf.c | 112 + tools/perf/util/symbol.h |5 ++ 4

[PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-03 Thread Hemant Kumar
This patch enables perf to probe on the marker name specified on the command line. --- tools/perf/builtin-probe.c|7 +++ tools/perf/util/probe-event.c | 11 tools/perf/util/symbol-elf.c | 112 + tools/perf/util/symbol.h |5 ++ 4

Re: [PATCH 2/2] Support to perf to probe on SDT markers:

2013-09-03 Thread Masami Hiramatsu
(2013/09/03 16:37), Hemant Kumar wrote: This patch enables perf to probe on the marker name specified on the command line. At least you must show how this works, and how to use in the comment. Thank you, --- tools/perf/builtin-probe.c|7 +++ tools/perf/util/probe-event.c | 11