On Fri, May 24, 2019 at 8:07 AM Souptick Joarder wrote:
>
> > > Taking a quick look now, by the way, why does vm_map_pages_zero() (and
> > > __vm_map_pages() etc.) get a pointer to an array instead of a pointer
> > > to the first element?
>
> For this particular driver, one page is getting mapped
While using mmap, the incorrect values of length and vm_pgoff are
ignored and this driver goes ahead with mapping fbdev.buffer
to user vma.
Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
"fix" these drivers to behave according to the normal vm_pgoff
offsetting simply by
On Thu, May 23, 2019 at 6:53 PM Miguel Ojeda
wrote:
>
> On Mon, May 20, 2019 at 5:26 PM Souptick Joarder wrote:
> >
> > While using mmap, the incorrect value of length and vm_pgoff are
> > ignored and this driver go ahead with mapping fbdev.buffer
> > to user vma.
>
> Typos: values*, goes* (same
On Fri, May 24, 2019 at 9:52 AM Miguel Ojeda
wrote:
>
> On Thu, May 23, 2019 at 2:58 PM Miguel Ojeda
> wrote:
> >
> > Taking a quick look now, by the way, why does vm_map_pages_zero() (and
> > __vm_map_pages() etc.) get a pointer to an array instead of a pointer
> > to the first element?
For
On Thu, May 23, 2019 at 2:58 PM Miguel Ojeda
wrote:
>
> Taking a quick look now, by the way, why does vm_map_pages_zero() (and
> __vm_map_pages() etc.) get a pointer to an array instead of a pointer
> to the first element?
Also, in __vm_map_pages(), semantically w.r.t. to the comment,
shouldn't
On Mon, May 20, 2019 at 5:26 PM Souptick Joarder wrote:
>
> While using mmap, the incorrect value of length and vm_pgoff are
> ignored and this driver go ahead with mapping fbdev.buffer
> to user vma.
Typos: values*, goes* (same for the other patch)
> Convert vm_insert_pages() to use
On Thu, May 23, 2019 at 10:18 AM Souptick Joarder wrote:
>
> Miguel, Ack from Robin is missing in linux-next-20190523 when applied.
Thanks for the warning! I wanted to review first but didn't get to it yet.
Taking a quick look now, by the way, why does vm_map_pages_zero() (and
__vm_map_pages()
On Tue, May 21, 2019 at 12:24 PM Robin van der Gracht wrote:
>
> On Mon, 20 May 2019 21:00:58 +0530
> Souptick Joarder wrote:
>
> > While using mmap, the incorrect value of length and vm_pgoff are
> > ignored and this driver go ahead with mapping fbdev.buffer
> > to user vma.
> >
> > Convert
On Mon, 20 May 2019 21:00:58 +0530
Souptick Joarder wrote:
> While using mmap, the incorrect value of length and vm_pgoff are
> ignored and this driver go ahead with mapping fbdev.buffer
> to user vma.
>
> Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
> "fix" these
While using mmap, the incorrect value of length and vm_pgoff are
ignored and this driver go ahead with mapping fbdev.buffer
to user vma.
Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
"fix" these drivers to behave according to the normal vm_pgoff
offsetting simply by
10 matches
Mail list logo
