Re: [PATCH 2/2] blk-mq: remove unnecessary blk_clear_rq_complete()

2014-09-18 Thread Christoph Hellwig
On Thu, Sep 18, 2014 at 09:33:35AM +0800, Ming Lei wrote: > > Why yo you think it's not nessecary? The request is not in the drivers > > The COMPLETED flag will be cleared in blk_mq_start_request(), so > it needn't to be cleared here, and it is a bit early and might cause > a tiny race window. >

Re: [PATCH 2/2] blk-mq: remove unnecessary blk_clear_rq_complete()

2014-09-18 Thread Christoph Hellwig
On Thu, Sep 18, 2014 at 09:33:35AM +0800, Ming Lei wrote: Why yo you think it's not nessecary? The request is not in the drivers The COMPLETED flag will be cleared in blk_mq_start_request(), so it needn't to be cleared here, and it is a bit early and might cause a tiny race window.

Re: [PATCH 2/2] blk-mq: remove unnecessary blk_clear_rq_complete()

2014-09-17 Thread Ming Lei
On Thu, Sep 18, 2014 at 12:48 AM, Christoph Hellwig wrote: > On Wed, Sep 17, 2014 at 05:47:58PM +0800, Ming Lei wrote: >> From: Ming Lei >> >> This patch removes two unnecessary blk_clear_rq_complete(), >> the REQ_ATOM_COMPLETE flag is cleared inside blk_mq_start_request(), >> so: >> >> -

Re: [PATCH 2/2] blk-mq: remove unnecessary blk_clear_rq_complete()

2014-09-17 Thread Christoph Hellwig
On Wed, Sep 17, 2014 at 05:47:58PM +0800, Ming Lei wrote: > From: Ming Lei > > This patch removes two unnecessary blk_clear_rq_complete(), > the REQ_ATOM_COMPLETE flag is cleared inside blk_mq_start_request(), > so: > > - The blk_clear_rq_complete() in blk_flush_restore_request() >

[PATCH 2/2] blk-mq: remove unnecessary blk_clear_rq_complete()

2014-09-17 Thread Ming Lei
From: Ming Lei This patch removes two unnecessary blk_clear_rq_complete(), the REQ_ATOM_COMPLETE flag is cleared inside blk_mq_start_request(), so: - The blk_clear_rq_complete() in blk_flush_restore_request() needn't because the request will be freed later, and clearing

[PATCH 2/2] blk-mq: remove unnecessary blk_clear_rq_complete()

2014-09-17 Thread Ming Lei
From: Ming Lei ming@canoical.com This patch removes two unnecessary blk_clear_rq_complete(), the REQ_ATOM_COMPLETE flag is cleared inside blk_mq_start_request(), so: - The blk_clear_rq_complete() in blk_flush_restore_request() needn't because the request will be freed later,

Re: [PATCH 2/2] blk-mq: remove unnecessary blk_clear_rq_complete()

2014-09-17 Thread Christoph Hellwig
On Wed, Sep 17, 2014 at 05:47:58PM +0800, Ming Lei wrote: From: Ming Lei ming@canoical.com This patch removes two unnecessary blk_clear_rq_complete(), the REQ_ATOM_COMPLETE flag is cleared inside blk_mq_start_request(), so: - The blk_clear_rq_complete() in

Re: [PATCH 2/2] blk-mq: remove unnecessary blk_clear_rq_complete()

2014-09-17 Thread Ming Lei
On Thu, Sep 18, 2014 at 12:48 AM, Christoph Hellwig h...@lst.de wrote: On Wed, Sep 17, 2014 at 05:47:58PM +0800, Ming Lei wrote: From: Ming Lei ming@canoical.com This patch removes two unnecessary blk_clear_rq_complete(), the REQ_ATOM_COMPLETE flag is cleared inside