Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-11 Thread Vinod
On 11-10-18, 00:19, Stephen Boyd wrote: > Quoting Vinod (2018-10-07 20:51:44) > > On 07-10-18, 19:38, Stephen Boyd wrote: > > > Quoting Vinod (2018-10-02 23:21:03) > > > > Hi Stephen, > > > > > > > > Thanks for the comments, > > > > > > > > On 01-10-18, 10:19, Stephen Boyd wrote: > > > > > Quotin

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-11 Thread Stephen Boyd
Quoting Vinod (2018-10-07 20:51:44) > On 07-10-18, 19:38, Stephen Boyd wrote: > > Quoting Vinod (2018-10-02 23:21:03) > > > Hi Stephen, > > > > > > Thanks for the comments, > > > > > > On 01-10-18, 10:19, Stephen Boyd wrote: > > > > Quoting Vinod Koul (2018-09-21 11:59:36) > > > > > From: Shefali

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-07 Thread Taniya Das
On 10/7/2018 7:01 PM, Vinod wrote: Hi Taniya, Thanks for the review, It would be great if you can strip the irrelevant context while replying, makes it easier for people to follow. On 06-10-18, 23:28, Taniya Das wrote: +static struct clk_rcg2 pclk0_clk_src = { + .cmd_rcgr = 0x4d000,

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-07 Thread Vinod
On 07-10-18, 19:38, Stephen Boyd wrote: > Quoting Vinod (2018-10-02 23:21:03) > > Hi Stephen, > > > > Thanks for the comments, > > > > On 01-10-18, 10:19, Stephen Boyd wrote: > > > Quoting Vinod Koul (2018-09-21 11:59:36) > > > > From: Shefali Jain > > > > > > > > Add the clocks supported in gl

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-07 Thread Stephen Boyd
Quoting Vinod (2018-10-02 23:21:03) > Hi Stephen, > > Thanks for the comments, > > On 01-10-18, 10:19, Stephen Boyd wrote: > > Quoting Vinod Koul (2018-09-21 11:59:36) > > > From: Shefali Jain > > > > > > Add the clocks supported in global clock controller which clock the > > > peripherals like

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-07 Thread Vinod
Hi Taniya, Thanks for the review, It would be great if you can strip the irrelevant context while replying, makes it easier for people to follow. On 06-10-18, 23:28, Taniya Das wrote: > > +static struct clk_rcg2 pclk0_clk_src = { > > + .cmd_rcgr = 0x4d000, > > + .mnd_width = 8, > > + .hid_

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-07 Thread Vinod
Hi Tanya, On 06-10-18, 23:19, Taniya Das wrote: > > > > +static struct clk_branch gcc_pwm1_xo512_clk = { > > > > + .halt_reg = 0x49004, > > > > + .halt_check = BRANCH_HALT, > > > > + .clkr = { > > > > + .enable_reg = 0x49004, > > > > + .enable_mask =

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-06 Thread Taniya Das
On 9/22/2018 12:29 AM, Vinod Koul wrote: From: Shefali Jain Add the clocks supported in global clock controller which clock the peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks to the clock framework for the clients to be able to request for them. Signed-off-by: Shefali

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-06 Thread Taniya Das
Hello Vinod, On 10/3/2018 11:51 AM, Vinod wrote: Hi Stephen, Thanks for the comments, On 01-10-18, 10:19, Stephen Boyd wrote: Quoting Vinod Koul (2018-09-21 11:59:36) From: Shefali Jain Add the clocks supported in global clock controller which clock the peripherals like BLSPs, SDCC, USB, M

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-02 Thread Vinod
Hi Stephen, Thanks for the comments, On 01-10-18, 10:19, Stephen Boyd wrote: > Quoting Vinod Koul (2018-09-21 11:59:36) > > From: Shefali Jain > > > > Add the clocks supported in global clock controller which clock the > > peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks > >

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-10-01 Thread Stephen Boyd
Quoting Vinod Koul (2018-09-21 11:59:36) > From: Shefali Jain > > Add the clocks supported in global clock controller which clock the > peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks > to the clock framework for the clients to be able to request for them. > > Signed-off-by:

[PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-09-21 Thread Vinod Koul
From: Shefali Jain Add the clocks supported in global clock controller which clock the peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks to the clock framework for the clients to be able to request for them. Signed-off-by: Shefali Jain Signed-off-by: Taniya Das Co-developed-