Re: [PATCH 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-09-12 Thread Bill Huang
On Thu, 2013-09-12 at 18:14 +0800, Peter De Schrijver wrote: > On Wed, Sep 11, 2013 at 01:19:14PM +0200, Bill Huang wrote: > > > +static inline int tegra_cpufreq_init(void) > > +{ > > + retrun EOPNOTSUPP; > > This should be -EOPNOTSUPP at least. I think -EINVAL might be better. Yeah thanks

Re: [PATCH 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-09-12 Thread Peter De Schrijver
On Wed, Sep 11, 2013 at 01:19:14PM +0200, Bill Huang wrote: > +static inline int tegra_cpufreq_init(void) > +{ > + retrun EOPNOTSUPP; This should be -EOPNOTSUPP at least. I think -EINVAL might be better. Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-09-11 Thread Bill Huang
On Thu, 2013-09-12 at 03:33 +0800, Stephen Warren wrote: > On 09/11/2013 05:19 AM, Bill Huang wrote: > > diff --git a/drivers/cpufreq/tegra20-cpufreq.c > > b/drivers/cpufreq/tegra20-cpufreq.c > > > +static struct cpufreq_frequency_table freq_table[] = { > > + { .frequency = 216000 }, > > + {

Re: [PATCH 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-09-11 Thread Stephen Warren
On 09/11/2013 05:19 AM, Bill Huang wrote: > Re-model Tegra cpufreq driver to support all Tegra series of SoCs. > > * Make tegra-cpufreq.c a generic Tegra cpufreq driver. > * Move Tegra20 specific codes into tegra20-cpufreq.c. > * Bind Tegra cpufreq dirver with a fake device so defer probe would wo

[PATCH 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-09-11 Thread Bill Huang
Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into tegra20-cpufreq.c. * Bind Tegra cpufreq dirver with a fake device so defer probe would work when we're going to get regulator in the driver