Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-09-21 Thread Horia Geantă
On 9/16/2020 12:50 AM, Richard Weinberger wrote: > - Ursprüngliche Mail - >> Von: "horia geanta" How to use it with cryptsetup? I'm asking because it is not clear to me why you are not implementing a new kernel key type (KEYS subsystem) to utilize tagged keys.

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-09-15 Thread Horia Geantă
On 9/14/2020 9:38 AM, Richard Weinberger wrote: > On Thu, Jul 16, 2020 at 4:12 PM Richard Weinberger > wrote: >> >> On Mon, Jul 13, 2020 at 12:09 AM Iuliana Prodan >> wrote: >>> >>> Tagged keys are keys that contain metadata indicating what >>> they are and how to handle them using tag_object

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-09-15 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "horia geanta" >>> How to use it with cryptsetup? >>> I'm asking because it is not clear to me why you are not implementing >>> a new kernel key type (KEYS subsystem) >>> to utilize tagged keys. >>> Many tools already support the keyctl userspace interface

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-09-14 Thread Richard Weinberger
On Thu, Jul 16, 2020 at 4:12 PM Richard Weinberger wrote: > > On Mon, Jul 13, 2020 at 12:09 AM Iuliana Prodan > wrote: > > > > Tagged keys are keys that contain metadata indicating what > > they are and how to handle them using tag_object API. > > > > Add support, for tagged keys, to skcipher

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-16 Thread Richard Weinberger
On Mon, Jul 13, 2020 at 12:09 AM Iuliana Prodan wrote: > > Tagged keys are keys that contain metadata indicating what > they are and how to handle them using tag_object API. > > Add support, for tagged keys, to skcipher algorithms by > adding new transformations, with _tk_ prefix to distinguish >

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-16 Thread Herbert Xu
On Thu, Jul 16, 2020 at 12:24:49PM +, Van Leeuwen, Pascal wrote: > > That would make no sense though, as sha512 does not involve any keys ... > It's the HMAC part that needs the keys. So phmac(sha512) then? You're right, that would be phmac(...). But the point is we don't want each driver to

RE: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-16 Thread Van Leeuwen, Pascal
inux-cry...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher > algorithms > > <<< External Email >>> > On Thu, Jul 16, 2020 at 03:07:50PM +0300, Horia Geantă wrote: > > &g

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-16 Thread Herbert Xu
On Thu, Jul 16, 2020 at 03:07:50PM +0300, Horia Geantă wrote: > > So instead of tk(cbc(aes)) use paes(cbc(aes) or cbc(paes)? Well if we're following the existing paes model then it'd be cbc(paes). > How would this work for hmac(sha512), > paes(hmac(sha512)) or hmac(psha512), or even

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-16 Thread Horia Geantă
On 7/16/2020 2:53 PM, Herbert Xu wrote: > On Thu, Jul 16, 2020 at 01:35:51PM +0300, Horia Geantă wrote: >> >> This patch set adds support only for some AES-based algorithms. >> However, going further the plan is to add all keyed algorithms >> supported by caam. >> >> Thus I wouldn't tie the name

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-16 Thread Herbert Xu
On Thu, Jul 16, 2020 at 01:35:51PM +0300, Horia Geantă wrote: > > This patch set adds support only for some AES-based algorithms. > However, going further the plan is to add all keyed algorithms > supported by caam. > > Thus I wouldn't tie the name to AES. Yes but it's still exactly the same

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-16 Thread Horia Geantă
On 7/16/2020 10:36 AM, Herbert Xu wrote: > On Mon, Jul 13, 2020 at 01:05:36AM +0300, Iuliana Prodan wrote: >> Tagged keys are keys that contain metadata indicating what >> they are and how to handle them using tag_object API. >> >> Add support, for tagged keys, to skcipher algorithms by >> adding

Re: [PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-16 Thread Herbert Xu
On Mon, Jul 13, 2020 at 01:05:36AM +0300, Iuliana Prodan wrote: > Tagged keys are keys that contain metadata indicating what > they are and how to handle them using tag_object API. > > Add support, for tagged keys, to skcipher algorithms by > adding new transformations, with _tk_ prefix to

[PATCH 2/2] crypto: caam - support tagged keys for skcipher algorithms

2020-07-12 Thread Iuliana Prodan
Tagged keys are keys that contain metadata indicating what they are and how to handle them using tag_object API. Add support, for tagged keys, to skcipher algorithms by adding new transformations, with _tk_ prefix to distinguish between plaintext and tagged keys. For job descriptors a new option