Re: [PATCH 2/2] dFrom: Max Kellermann <m...@cm4all.com>

2018-01-16 Thread Trond Myklebust
On Mon, 2018-01-15 at 18:30 +0100, Max Kellermann wrote: > nfs/super: set MS_POSIXACL only if ACL support is enabled > > The code comment says "We will [apply the umask] ourselves", but that > happens in posix_acl_create() only if the kernel has POSIX ACL > support. Without it,

Re: [PATCH 2/2] dFrom: Max Kellermann

2018-01-16 Thread Trond Myklebust
On Mon, 2018-01-15 at 18:30 +0100, Max Kellermann wrote: > nfs/super: set MS_POSIXACL only if ACL support is enabled > > The code comment says "We will [apply the umask] ourselves", but that > happens in posix_acl_create() only if the kernel has POSIX ACL > support. Without it,

Re: [PATCH 2/2] dFrom: Max Kellermann <m...@cm4all.com>

2018-01-15 Thread Max Kellermann
On 2018/01/15 18:41, Greg KH wrote: > Your subject line is a bit odd :( True, I already repaired & resent it. Sorry for the hiccup.

Re: [PATCH 2/2] dFrom: Max Kellermann

2018-01-15 Thread Max Kellermann
On 2018/01/15 18:41, Greg KH wrote: > Your subject line is a bit odd :( True, I already repaired & resent it. Sorry for the hiccup.

Re: [PATCH 2/2] dFrom: Max Kellermann <m...@cm4all.com>

2018-01-15 Thread Greg KH
On Mon, Jan 15, 2018 at 06:30:51PM +0100, Max Kellermann wrote: > nfs/super: set MS_POSIXACL only if ACL support is enabled > > The code comment says "We will [apply the umask] ourselves", but that > happens in posix_acl_create() only if the kernel has POSIX ACL > support. Without it,

Re: [PATCH 2/2] dFrom: Max Kellermann

2018-01-15 Thread Greg KH
On Mon, Jan 15, 2018 at 06:30:51PM +0100, Max Kellermann wrote: > nfs/super: set MS_POSIXACL only if ACL support is enabled > > The code comment says "We will [apply the umask] ourselves", but that > happens in posix_acl_create() only if the kernel has POSIX ACL > support. Without it,

[PATCH 2/2] dFrom: Max Kellermann <m...@cm4all.com>

2018-01-15 Thread Max Kellermann
nfs/super: set MS_POSIXACL only if ACL support is enabled The code comment says "We will [apply the umask] ourselves", but that happens in posix_acl_create() only if the kernel has POSIX ACL support. Without it, posix_acl_create() is a is an empty dummy function. So let's not pretend we will

[PATCH 2/2] dFrom: Max Kellermann

2018-01-15 Thread Max Kellermann
nfs/super: set MS_POSIXACL only if ACL support is enabled The code comment says "We will [apply the umask] ourselves", but that happens in posix_acl_create() only if the kernel has POSIX ACL support. Without it, posix_acl_create() is a is an empty dummy function. So let's not pretend we will