Re: [PATCH 2/2] dma: mv_xor: do not sync the DMA buffer after being deallocated

2013-01-17 Thread Lubomir Rintel
On Sun, 2013-01-13 at 14:18 +0100, Lubomir Rintel wrote: > On Fri, 2013-01-04 at 17:10 +0100, Thomas Petazzoni wrote: > > Dear Lubomir Rintel, > > > > On Thu, 27 Dec 2012 20:23:48 +0100, Lubomir Rintel wrote: > > > > > dma_sync_single_for_cpu(dma_chan->device->dev, dest_dma, > > >

Re: [PATCH 2/2] dma: mv_xor: do not sync the DMA buffer after being deallocated

2013-01-17 Thread Lubomir Rintel
On Sun, 2013-01-13 at 14:18 +0100, Lubomir Rintel wrote: On Fri, 2013-01-04 at 17:10 +0100, Thomas Petazzoni wrote: Dear Lubomir Rintel, On Thu, 27 Dec 2012 20:23:48 +0100, Lubomir Rintel wrote: dma_sync_single_for_cpu(dma_chan-device-dev, dest_dma,

Re: [PATCH 2/2] dma: mv_xor: do not sync the DMA buffer after being deallocated

2013-01-13 Thread Lubomir Rintel
On Fri, 2013-01-04 at 17:10 +0100, Thomas Petazzoni wrote: > Dear Lubomir Rintel, > > On Thu, 27 Dec 2012 20:23:48 +0100, Lubomir Rintel wrote: > > > dma_sync_single_for_cpu(dma_chan->device->dev, dest_dma, > > MV_XOR_TEST_SIZE, DMA_FROM_DEVICE); > > +

Re: [PATCH 2/2] dma: mv_xor: do not sync the DMA buffer after being deallocated

2013-01-13 Thread Lubomir Rintel
On Fri, 2013-01-04 at 17:10 +0100, Thomas Petazzoni wrote: Dear Lubomir Rintel, On Thu, 27 Dec 2012 20:23:48 +0100, Lubomir Rintel wrote: dma_sync_single_for_cpu(dma_chan-device-dev, dest_dma, MV_XOR_TEST_SIZE, DMA_FROM_DEVICE); +

Re: [PATCH 2/2] dma: mv_xor: do not sync the DMA buffer after being deallocated

2013-01-04 Thread Thomas Petazzoni
Dear Lubomir Rintel, On Thu, 27 Dec 2012 20:23:48 +0100, Lubomir Rintel wrote: > dma_sync_single_for_cpu(dma_chan->device->dev, dest_dma, > MV_XOR_TEST_SIZE, DMA_FROM_DEVICE); > + dma_unmap_single(dma_chan->device->dev, dest_dma, MV_XOR_TEST_SIZE, > +

Re: [PATCH 2/2] dma: mv_xor: do not sync the DMA buffer after being deallocated

2013-01-04 Thread Thomas Petazzoni
Dear Lubomir Rintel, On Thu, 27 Dec 2012 20:23:48 +0100, Lubomir Rintel wrote: dma_sync_single_for_cpu(dma_chan-device-dev, dest_dma, MV_XOR_TEST_SIZE, DMA_FROM_DEVICE); + dma_unmap_single(dma_chan-device-dev, dest_dma, MV_XOR_TEST_SIZE, +

[PATCH 2/2] dma: mv_xor: do not sync the DMA buffer after being deallocated

2012-12-27 Thread Lubomir Rintel
DMA_CHECK was unhappy: mv_xor mv_xor.0: DMA-API: device driver tries to sync DMA memory it has not Also, the xor test was causing the mv_xor_slot_cleanup() to incorrectly dealocate the destination buffer. This is fixed as well, since the deallocation is done in mv_xor_probe() (with correct flags)

[PATCH 2/2] dma: mv_xor: do not sync the DMA buffer after being deallocated

2012-12-27 Thread Lubomir Rintel
DMA_CHECK was unhappy: mv_xor mv_xor.0: DMA-API: device driver tries to sync DMA memory it has not Also, the xor test was causing the mv_xor_slot_cleanup() to incorrectly dealocate the destination buffer. This is fixed as well, since the deallocation is done in mv_xor_probe() (with correct flags)