Re: [PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-25 Thread Chen Yu
On Sun, May 24, 2020 at 11:06:53PM +0200, Michal Kubecek wrote: > On Sat, May 23, 2020 at 05:09:50PM +0800, Chen Yu wrote: > > Hi Michal, > > Thanks for reviewing, > > and sorry for late reply. > > On Thu, May 21, 2020 at 09:23:42PM +0200, Michal Kubecek wrote: > > > On Fri, May 22, 2020 at 01:59:1

Re: [PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-24 Thread Michal Kubecek
On Sat, May 23, 2020 at 05:09:50PM +0800, Chen Yu wrote: > Hi Michal, > Thanks for reviewing, > and sorry for late reply. > On Thu, May 21, 2020 at 09:23:42PM +0200, Michal Kubecek wrote: > > On Fri, May 22, 2020 at 01:59:13AM +0800, Chen Yu wrote: > > > Currently the ethtool shows that WOL(Wake On

Re: [PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-23 Thread Chen Yu
Hi Michal, Thanks for reviewing, and sorry for late reply. On Thu, May 21, 2020 at 09:23:42PM +0200, Michal Kubecek wrote: > On Fri, May 22, 2020 at 01:59:13AM +0800, Chen Yu wrote: > > Currently the ethtool shows that WOL(Wake On Lan) is enabled > > even if the device wakeup ability has been disab

Re: [PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-21 Thread Michal Kubecek
On Fri, May 22, 2020 at 01:59:13AM +0800, Chen Yu wrote: > Currently the ethtool shows that WOL(Wake On Lan) is enabled > even if the device wakeup ability has been disabled via sysfs: > cat /sys/devices/pci:00/:00:1f.6/power/wakeup >disabled > > ethtool eno1 > ... > Wake-on: g

[PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-21 Thread Chen Yu
Currently the ethtool shows that WOL(Wake On Lan) is enabled even if the device wakeup ability has been disabled via sysfs: cat /sys/devices/pci:00/:00:1f.6/power/wakeup disabled ethtool eno1 ... Wake-on: g Fix this in ethtool to check if the user has explicitly disabled the wa