Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, 2015-09-23 at 16:48 -0400, Theodore Ts'o wrote: > On Wed, Sep 23, 2015 at 10:47:16PM +0300, Artem Bityutskiy wrote: > > And, by the way, I forgot this detail - I cut AC power off at the > > end, then put it back on after a 20 seconds delay. I mean, this is > > a > > clean reboot, but with

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, 2015-09-23 at 16:48 -0400, Theodore Ts'o wrote: > On Wed, Sep 23, 2015 at 10:47:16PM +0300, Artem Bityutskiy wrote: > > And, by the way, I forgot this detail - I cut AC power off at the > > end, then put it back on after a 20 seconds delay. I mean, this is > > a > > clean reboot, but with

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 10:47:16PM +0300, Artem Bityutskiy wrote: > And, by the way, I forgot this detail - I cut AC power off at the > end, then put it back on after a 20 seconds delay. I mean, this is a > clean reboot, but with power cut at the end. Is this reproducible without the power cut?

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 9:24 PM, Theodore Ts'o wrote: > Artem, > > Can you (or someone on the cgroups list, perhaps) give more details > about how Fedora 22 sets up groups? > > Unfortunately apparently no one has gotten an official Fedora image > for Google Compute Engine so it's a bit of a pain

Re: [PATCH 2/2] ext4: implement cgroup writeback support

Hello, Artem. On Wed, Sep 23, 2015 at 08:41:25PM +0300, Artem Bityutskiy wrote: > $ sync > $ reboot > > is exactly the sequence. Can you please test with 4.3-rc2 and see whether the issue is reproducible? The multi-wb wait logic rewrite was merged during rc1 and I'm wondering whether this is a

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 02:09:34PM -0400, Tejun Heo wrote: > Hello, Artem. > > On Wed, Sep 23, 2015 at 03:49:12PM +0300, Artem Bityutskiy wrote: > > I use Fedora 22 with all the latest package updates, and I only change > > the kernel there. > > What's your cgroup setup like? Are you trying out

Re: [PATCH 2/2] ext4: implement cgroup writeback support

Artem, Can you (or someone on the cgroups list, perhaps) give more details about how Fedora 22 sets up groups? Unfortunately apparently no one has gotten an official Fedora image for Google Compute Engine so it's a bit of a pain for me to reproduce the problem. (I suppose I could use AWS, but

Re: [PATCH 2/2] ext4: implement cgroup writeback support

Hello, Artem. On Wed, Sep 23, 2015 at 03:49:12PM +0300, Artem Bityutskiy wrote: > I use Fedora 22 with all the latest package updates, and I only change > the kernel there. What's your cgroup setup like? Are you trying out the unified hierarchy? Given that you didn't mention that, I'm guessing

Re: [PATCH 2/2] ext4: implement cgroup writeback support

Hello, Ted. On Wed, Sep 23, 2015 at 01:02:38PM -0400, Theodore Ts'o wrote: > Also note this performance regression reported by Dexuan Cui > > https://lkml.org/lkml/2015/9/23/333 > > I didn't notice these problems since I my userspace doesn't enable the > writeback cgroup. (In fact I

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 08:41:25PM +0300, Artem Bityutskiy wrote: >Hi > >$ sync >$ reboot If this is case, it should be possible to reproduce with: cp a bunch of stuff to /ext4 unmount /ext4 mount ext4 compare data If you're not getting a clean unmount of the test FS during the

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 03:49:12PM +0300, Artem Bityutskiy wrote: > On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > > > Signed-off-by: Tejun Heo > > > Cc: "Theodore Ts'o" > > > Cc: Andreas Dilger > > > Cc:

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 04:50:53PM +0300, Artem Bityutskiy wrote: > On Wed, 2015-09-23 at 15:49 +0300, Artem Bityutskiy wrote: > > On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > > > > > Signed-off-by: Tejun Heo > > > > Cc:

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, 2015-09-23 at 15:49 +0300, Artem Bityutskiy wrote: > On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > > > Signed-off-by: Tejun Heo > > > Cc: "Theodore Ts'o" > > > Cc: Andreas Dilger > > > Cc: linux-e...@vger.kernel.org

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > Signed-off-by: Tejun Heo > > Cc: "Theodore Ts'o" > > Cc: Andreas Dilger > > Cc: linux-e...@vger.kernel.org > > Thanks, applied. Hi, this patch introduces a regression - a major

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > Signed-off-by: Tejun Heo > > Cc: "Theodore Ts'o" > > Cc: Andreas Dilger > > Cc: linux-e...@vger.kernel.org > > Thanks,

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, 2015-09-23 at 15:49 +0300, Artem Bityutskiy wrote: > On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > > > Signed-off-by: Tejun Heo > > > Cc: "Theodore Ts'o" > > > Cc: Andreas Dilger

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 04:50:53PM +0300, Artem Bityutskiy wrote: > On Wed, 2015-09-23 at 15:49 +0300, Artem Bityutskiy wrote: > > On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > > > > > Signed-off-by: Tejun Heo

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 03:49:12PM +0300, Artem Bityutskiy wrote: > On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > > > Signed-off-by: Tejun Heo > > > Cc: "Theodore Ts'o" > > > Cc: Andreas Dilger

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 02:09:34PM -0400, Tejun Heo wrote: > Hello, Artem. > > On Wed, Sep 23, 2015 at 03:49:12PM +0300, Artem Bityutskiy wrote: > > I use Fedora 22 with all the latest package updates, and I only change > > the kernel there. > > What's your cgroup setup like? Are you trying out

Re: [PATCH 2/2] ext4: implement cgroup writeback support

Hello, Artem. On Wed, Sep 23, 2015 at 08:41:25PM +0300, Artem Bityutskiy wrote: > $ sync > $ reboot > > is exactly the sequence. Can you please test with 4.3-rc2 and see whether the issue is reproducible? The multi-wb wait logic rewrite was merged during rc1 and I'm wondering whether this is a

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 08:41:25PM +0300, Artem Bityutskiy wrote: >Hi > >$ sync >$ reboot If this is case, it should be possible to reproduce with: cp a bunch of stuff to /ext4 unmount /ext4 mount ext4 compare data If you're not getting a clean unmount of the test FS during the

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 9:24 PM, Theodore Ts'o wrote: > Artem, > > Can you (or someone on the cgroups list, perhaps) give more details > about how Fedora 22 sets up groups? > > Unfortunately apparently no one has gotten an official Fedora image > for Google Compute Engine so it's a

Re: [PATCH 2/2] ext4: implement cgroup writeback support

Hello, Ted. On Wed, Sep 23, 2015 at 01:02:38PM -0400, Theodore Ts'o wrote: > Also note this performance regression reported by Dexuan Cui > > https://lkml.org/lkml/2015/9/23/333 > > I didn't notice these problems since I my userspace doesn't enable the > writeback cgroup. (In fact I

Re: [PATCH 2/2] ext4: implement cgroup writeback support

Hello, Artem. On Wed, Sep 23, 2015 at 03:49:12PM +0300, Artem Bityutskiy wrote: > I use Fedora 22 with all the latest package updates, and I only change > the kernel there. What's your cgroup setup like? Are you trying out the unified hierarchy? Given that you didn't mention that, I'm guessing

Re: [PATCH 2/2] ext4: implement cgroup writeback support

Artem, Can you (or someone on the cgroups list, perhaps) give more details about how Fedora 22 sets up groups? Unfortunately apparently no one has gotten an official Fedora image for Google Compute Engine so it's a bit of a pain for me to reproduce the problem. (I suppose I could use AWS, but

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 10:47:16PM +0300, Artem Bityutskiy wrote: > And, by the way, I forgot this detail - I cut AC power off at the > end, then put it back on after a 20 seconds delay. I mean, this is a > clean reboot, but with power cut at the end. Is this reproducible without the power cut?

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Tue, Jun 16, 2015 at 06:53:13PM -0400, Tejun Heo wrote: > For ordered and writeback data modes, all data IOs go through > ext4_io_submit. This patch adds cgroup writeback support by invoking > wbc_init_bio() from io_submit_init_bio() and wbc_account_io() in > io_submit_add_bh(). Journal data

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Tue, Jun 16, 2015 at 06:53:13PM -0400, Tejun Heo wrote: For ordered and writeback data modes, all data IOs go through ext4_io_submit. This patch adds cgroup writeback support by invoking wbc_init_bio() from io_submit_init_bio() and wbc_account_io() in io_submit_add_bh(). Journal data

[PATCH 2/2] ext4: implement cgroup writeback support

For ordered and writeback data modes, all data IOs go through ext4_io_submit. This patch adds cgroup writeback support by invoking wbc_init_bio() from io_submit_init_bio() and wbc_account_io() in io_submit_add_bh(). Journal data which is written by jbd2 worker is left alone by this patch and

[PATCH 2/2] ext4: implement cgroup writeback support

For ordered and writeback data modes, all data IOs go through ext4_io_submit. This patch adds cgroup writeback support by invoking wbc_init_bio() from io_submit_init_bio() and wbc_account_io() in io_submit_add_bh(). Journal data which is written by jbd2 worker is left alone by this patch and

[PATCH 2/2] ext4: implement cgroup writeback support

For ordered and writeback data modes, all data IOs go through ext4_io_submit. This patch adds cgroup writeback support by invoking wbc_init_bio() from io_submit_init_bio() and wbc_account_io() in io_submit_add_bh(). Journal data which is written by jbd2 worker is left alone by this patch and

[PATCH 2/2] ext4: implement cgroup writeback support

For ordered and writeback data modes, all data IOs go through ext4_io_submit. This patch adds cgroup writeback support by invoking wbc_init_bio() from io_submit_init_bio() and wbc_account_io() in io_submit_add_bh(). Journal data which is written by jbd2 worker is left alone by this patch and