Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Andy Shevchenko
On Thu, Feb 1, 2018 at 2:22 PM, Marcus Folkesson wrote: > On Thu, Feb 01, 2018 at 11:08:46AM +0800, Baolin Wang wrote: > Then you could replace > +subsys_initcall(sprd_gpio_init); > module_platform_driver(sprd_gpio_driver); It's not an equivalent when built-in --

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Andy Shevchenko
On Thu, Feb 1, 2018 at 2:22 PM, Marcus Folkesson wrote: > On Thu, Feb 01, 2018 at 11:08:46AM +0800, Baolin Wang wrote: > Then you could replace > +subsys_initcall(sprd_gpio_init); > module_platform_driver(sprd_gpio_driver); It's not an equivalent when built-in -- With Best Regards, Andy

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Baolin Wang
On 1 February 2018 at 20:22, Marcus Folkesson wrote: > On Thu, Feb 01, 2018 at 11:08:46AM +0800, Baolin Wang wrote: >> On 31 January 2018 at 22:23, Andy Shevchenko >> wrote: >> > On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Baolin Wang
On 1 February 2018 at 20:22, Marcus Folkesson wrote: > On Thu, Feb 01, 2018 at 11:08:46AM +0800, Baolin Wang wrote: >> On 31 January 2018 at 22:23, Andy Shevchenko >> wrote: >> > On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang >> > wrote: >> >> On 31 January 2018 at 00:48, Andy Shevchenko >>

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Baolin Wang
Hi Markus, On 1 February 2018 at 20:17, Marcus Folkesson wrote: > Hi Baolin, > > On Tue, Jan 30, 2018 at 08:07:43PM +0800, Baolin Wang wrote: >> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and >> each group contains 16 GPIOs. Each GPIO can set

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Baolin Wang
Hi Markus, On 1 February 2018 at 20:17, Marcus Folkesson wrote: > Hi Baolin, > > On Tue, Jan 30, 2018 at 08:07:43PM +0800, Baolin Wang wrote: >> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and >> each group contains 16 GPIOs. Each GPIO can set input/output and has >> the

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Marcus Folkesson
On Thu, Feb 01, 2018 at 11:08:46AM +0800, Baolin Wang wrote: > On 31 January 2018 at 22:23, Andy Shevchenko > wrote: > > On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang wrote: > >> On 31 January 2018 at 00:48, Andy Shevchenko

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Marcus Folkesson
On Thu, Feb 01, 2018 at 11:08:46AM +0800, Baolin Wang wrote: > On 31 January 2018 at 22:23, Andy Shevchenko > wrote: > > On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang wrote: > >> On 31 January 2018 at 00:48, Andy Shevchenko > >> wrote: > >>> On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang > >>>

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Marcus Folkesson
Hi Baolin, On Tue, Jan 30, 2018 at 08:07:43PM +0800, Baolin Wang wrote: > The Spreadtrum SC9860 platform GPIO controller contains 16 groups and > each group contains 16 GPIOs. Each GPIO can set input/output and has > the interrupt capability. > > Signed-off-by: Baolin Wang

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-02-01 Thread Marcus Folkesson
Hi Baolin, On Tue, Jan 30, 2018 at 08:07:43PM +0800, Baolin Wang wrote: > The Spreadtrum SC9860 platform GPIO controller contains 16 groups and > each group contains 16 GPIOs. Each GPIO can set input/output and has > the interrupt capability. > > Signed-off-by: Baolin Wang > --- > diff --git

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-31 Thread Baolin Wang
On 31 January 2018 at 22:23, Andy Shevchenko wrote: > On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang wrote: >> On 31 January 2018 at 00:48, Andy Shevchenko >> wrote: >>> On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-31 Thread Baolin Wang
On 31 January 2018 at 22:23, Andy Shevchenko wrote: > On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang wrote: >> On 31 January 2018 at 00:48, Andy Shevchenko >> wrote: >>> On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang wrote: The Spreadtrum SC9860 platform GPIO controller contains 16 groups

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-31 Thread Andy Shevchenko
On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang wrote: > On 31 January 2018 at 00:48, Andy Shevchenko > wrote: >> On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang wrote: >>> The Spreadtrum SC9860 platform GPIO controller

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-31 Thread Andy Shevchenko
On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang wrote: > On 31 January 2018 at 00:48, Andy Shevchenko > wrote: >> On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang wrote: >>> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and >>> each group contains 16 GPIOs. Each GPIO can set

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-30 Thread Baolin Wang
Hi Andy, On 31 January 2018 at 00:48, Andy Shevchenko wrote: > On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang wrote: >> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and >> each group contains 16 GPIOs. Each GPIO can set

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-30 Thread Baolin Wang
Hi Andy, On 31 January 2018 at 00:48, Andy Shevchenko wrote: > On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang wrote: >> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and >> each group contains 16 GPIOs. Each GPIO can set input/output and has >> the interrupt capability. > >>

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-30 Thread Andy Shevchenko
On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang wrote: > The Spreadtrum SC9860 platform GPIO controller contains 16 groups and > each group contains 16 GPIOs. Each GPIO can set input/output and has > the interrupt capability. > +config GPIO_SPRD > + bool "Spreadtrum

Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-30 Thread Andy Shevchenko
On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang wrote: > The Spreadtrum SC9860 platform GPIO controller contains 16 groups and > each group contains 16 GPIOs. Each GPIO can set input/output and has > the interrupt capability. > +config GPIO_SPRD > + bool "Spreadtrum GPIO support" Either you

[PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-30 Thread Baolin Wang
The Spreadtrum SC9860 platform GPIO controller contains 16 groups and each group contains 16 GPIOs. Each GPIO can set input/output and has the interrupt capability. Signed-off-by: Baolin Wang --- drivers/gpio/Kconfig |7 ++ drivers/gpio/Makefile|1 +

[PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

2018-01-30 Thread Baolin Wang
The Spreadtrum SC9860 platform GPIO controller contains 16 groups and each group contains 16 GPIOs. Each GPIO can set input/output and has the interrupt capability. Signed-off-by: Baolin Wang --- drivers/gpio/Kconfig |7 ++ drivers/gpio/Makefile|1 + drivers/gpio/gpio-sprd.c |