Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-23 Thread Wolfram Sang
> > Should it (ACPI walk) be done in PCI case as well? If so, then it needs > > to be done up to i2c-core. There you may adjust the bus speed whenever > > slave device is enumerated. > > > I think the "ACPI walk for bus speed" also works for PCI case. It'll > be good to do this in i2c-core. > By

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-23 Thread Wolfram Sang
> > Should it (ACPI walk) be done in PCI case as well? If so, then it needs > > to be done up to i2c-core. There you may adjust the bus speed whenever > > slave device is enumerated. > > > I think the "ACPI walk for bus speed" also works for PCI case. It'll > be good to do this in i2c-core. > By

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-21 Thread Xiang Wang
2015-10-15 17:40 GMT+08:00 Andy Shevchenko : > On Thu, 2015-10-15 at 11:32 +0300, Jarkko Nikula wrote: >> On 10/15/2015 08:46 AM, Xiang Wang wrote: >> > >> > In conclusion, we have 2 solutions to set the i2c controller speed >> > mode (pci driver): >> > 1) use hardcode value in pci driver >> > 2)

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-21 Thread Xiang Wang
2015-10-15 17:40 GMT+08:00 Andy Shevchenko : > On Thu, 2015-10-15 at 11:32 +0300, Jarkko Nikula wrote: >> On 10/15/2015 08:46 AM, Xiang Wang wrote: >> > >> > In conclusion, we have 2 solutions to set the i2c controller speed >> > mode (pci driver): >> > 1) use

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-15 Thread Andy Shevchenko
On Thu, 2015-10-15 at 11:32 +0300, Jarkko Nikula wrote: > On 10/15/2015 08:46 AM, Xiang Wang wrote: > > > > In conclusion, we have 2 solutions to set the i2c controller speed > > mode (pci driver): > > 1) use hardcode value in pci driver > > 2) use frequency setting of "i2c device" in ACPI table

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-15 Thread Jarkko Nikula
On 10/15/2015 08:46 AM, Xiang Wang wrote: 1. "bus speed mode" is a bit different from other parameters. Actually it can be determined by the speed setting of "i2c devices" in ACPI (I2CSerialBus). E.g. If i2c device uses 3MHz, we use High-speed mode for this i2c bus. 2. If we hardcode speed

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-15 Thread Jarkko Nikula
On 10/15/2015 08:46 AM, Xiang Wang wrote: 1. "bus speed mode" is a bit different from other parameters. Actually it can be determined by the speed setting of "i2c devices" in ACPI (I2CSerialBus). E.g. If i2c device uses 3MHz, we use High-speed mode for this i2c bus. 2. If we hardcode speed

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-15 Thread Andy Shevchenko
On Thu, 2015-10-15 at 11:32 +0300, Jarkko Nikula wrote: > On 10/15/2015 08:46 AM, Xiang Wang wrote: > > > > In conclusion, we have 2 solutions to set the i2c controller speed > > mode (pci driver): > > 1) use hardcode value in pci driver > > 2) use frequency setting of "i2c device" in ACPI table

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-14 Thread Xiang Wang
2015-10-12 16:31 GMT+08:00 Andy Shevchenko : > On Mon, 2015-10-12 at 15:41 +0800, Xiang Wang wrote: >> Hi, Andy >> Thanks for your comments. >> >> [Andy] Don't see a relationship between PCI driver and this ACPI >> stuff. >> Although this is a pci driver, we may enumerate the i2c devices from >>

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-14 Thread Xiang Wang
2015-10-12 16:31 GMT+08:00 Andy Shevchenko : > On Mon, 2015-10-12 at 15:41 +0800, Xiang Wang wrote: >> Hi, Andy >> Thanks for your comments. >> >> [Andy] Don't see a relationship between PCI driver and this ACPI >> stuff. >> Although this is a pci driver, we may

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-12 Thread Andy Shevchenko
On Mon, 2015-10-12 at 15:41 +0800, Xiang Wang wrote: > Hi, Andy > Thanks for your comments. > > [Andy] Don't see a relationship between PCI driver and this ACPI > stuff. > Although this is a pci driver, we may enumerate the i2c devices from > DSDT table while i2c controllers are enumerated via

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-12 Thread Xiang Wang
Hi, Andy Thanks for your comments. [Andy] Don't see a relationship between PCI driver and this ACPI stuff. Although this is a pci driver, we may enumerate the i2c devices from DSDT table while i2c controllers are enumerated via PCI. In this scenario, in DSDT, there are descriptions of i2c devices

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-12 Thread Xiang Wang
Hi, Andy Thanks for your comments. [Andy] Don't see a relationship between PCI driver and this ACPI stuff. Although this is a pci driver, we may enumerate the i2c devices from DSDT table while i2c controllers are enumerated via PCI. In this scenario, in DSDT, there are descriptions of i2c devices

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-12 Thread Andy Shevchenko
On Mon, 2015-10-12 at 15:41 +0800, Xiang Wang wrote: > Hi, Andy > Thanks for your comments. > > [Andy] Don't see a relationship between PCI driver and this ACPI > stuff. > Although this is a pci driver, we may enumerate the i2c devices from > DSDT table while i2c controllers are enumerated via

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-09 Thread Andy Shevchenko
On Fri, 2015-10-09 at 16:47 +0800, wangx...@gmail.com wrote: > From: Xiang Wang > > 1. Support setting hs_hcnt and hs_lcnt > 2. Get bus speed mode from ACPI companion of the > i2c controller. > > Signed-off-by: Xiang Wang > --- > drivers/i2c/busses/i2c-designware-pcidrv.c | 7 +++ > 1

[PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-09 Thread wangxfdu
From: Xiang Wang 1. Support setting hs_hcnt and hs_lcnt 2. Get bus speed mode from ACPI companion of the i2c controller. Signed-off-by: Xiang Wang --- drivers/i2c/busses/i2c-designware-pcidrv.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-09 Thread wangxfdu
From: Xiang Wang 1. Support setting hs_hcnt and hs_lcnt 2. Get bus speed mode from ACPI companion of the i2c controller. Signed-off-by: Xiang Wang --- drivers/i2c/busses/i2c-designware-pcidrv.c | 7 +++ 1 file changed, 7 insertions(+) diff

Re: [PATCH 2/2] i2c: designware: enable High-speed mode for pcidrv

2015-10-09 Thread Andy Shevchenko
On Fri, 2015-10-09 at 16:47 +0800, wangx...@gmail.com wrote: > From: Xiang Wang > > 1. Support setting hs_hcnt and hs_lcnt > 2. Get bus speed mode from ACPI companion of the > i2c controller. > > Signed-off-by: Xiang Wang > --- >