Re: [PATCH 2/2] iio: light: bh1750: Add device tree support

2018-09-22 Thread Jonathan Cameron
On Mon, 17 Sep 2018 21:57:33 -0400 r yang wrote: > On Sun, Sep 16, 2018 at 10:45:26AM +0100, Jonathan Cameron wrote: > > On Sat, 15 Sep 2018 13:42:14 -0400 > > ryang wrote: > > > > > Add device tree support for ROHM BH1750 series ambient light sensors. > > > > > > Signed-off-by: ryang > >

Re: [PATCH 2/2] iio: light: bh1750: Add device tree support

2018-09-22 Thread Jonathan Cameron
On Fri, 21 Sep 2018 17:34:21 +0200 Tomasz Duszynski wrote: > On Thu, Sep 20, 2018 at 09:37:21PM -0400, r yang wrote: > > On Wed, Sep 19, 2018 at 09:22:39PM +0200, Tomasz Duszynski wrote: > > > Comments inline. > > > > > > On Sat, Sep 15, 2018 at 01:42:14PM -0400, ryang wrote: > > > > Add devi

Re: [PATCH 2/2] iio: light: bh1750: Add device tree support

2018-09-21 Thread Tomasz Duszynski
On Thu, Sep 20, 2018 at 09:37:21PM -0400, r yang wrote: > On Wed, Sep 19, 2018 at 09:22:39PM +0200, Tomasz Duszynski wrote: > > Comments inline. > > > > On Sat, Sep 15, 2018 at 01:42:14PM -0400, ryang wrote: > > > Add device tree support for ROHM BH1750 series ambient light sensors. > > > > > > Sig

Re: [PATCH 2/2] iio: light: bh1750: Add device tree support

2018-09-20 Thread r yang
On Wed, Sep 19, 2018 at 09:22:39PM +0200, Tomasz Duszynski wrote: > Comments inline. > > On Sat, Sep 15, 2018 at 01:42:14PM -0400, ryang wrote: > > Add device tree support for ROHM BH1750 series ambient light sensors. > > > > Signed-off-by: ryang > > --- > > drivers/iio/light/bh1750.c | 10 +

Re: [PATCH 2/2] iio: light: bh1750: Add device tree support

2018-09-19 Thread Tomasz Duszynski
Comments inline. On Sat, Sep 15, 2018 at 01:42:14PM -0400, ryang wrote: > Add device tree support for ROHM BH1750 series ambient light sensors. > > Signed-off-by: ryang > --- > drivers/iio/light/bh1750.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/iio/light/bh175

Re: [PATCH 2/2] iio: light: bh1750: Add device tree support

2018-09-17 Thread r yang
On Sun, Sep 16, 2018 at 10:45:26AM +0100, Jonathan Cameron wrote: > On Sat, 15 Sep 2018 13:42:14 -0400 > ryang wrote: > > > Add device tree support for ROHM BH1750 series ambient light sensors. > > > > Signed-off-by: ryang > Just to check, how is it picking up on the enum value which is provide

Re: [PATCH 2/2] iio: light: bh1750: Add device tree support

2018-09-16 Thread Jonathan Cameron
On Sat, 15 Sep 2018 13:42:14 -0400 ryang wrote: > Add device tree support for ROHM BH1750 series ambient light sensors. > > Signed-off-by: ryang Just to check, how is it picking up on the enum value which is provided in the i2c_device_id entries? i.e. What is setting id->driver_data in the pro

[PATCH 2/2] iio: light: bh1750: Add device tree support

2018-09-15 Thread ryang
Add device tree support for ROHM BH1750 series ambient light sensors. Signed-off-by: ryang --- drivers/iio/light/bh1750.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c index a814828e69f5..50b599abb383 100644 --- a/drivers/