Hi,
Le 21/07/2015 00:40, Greg KH a écrit :
On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote:
On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote:
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
Signed-off-by: Yann Cantin
+
+ /* sysfs setup */
+
Hi,
Le 21/07/2015 10:19, Oliver Neukum a écrit :
On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote:
diff --git a/drivers/input/misc/ebeam.c b/drivers/input/misc/ebeam.c
new file mode 100644
index 000..79cac51
--- /dev/null
+++ b/drivers/input/misc/ebeam.c
+/* Electronics For
Hi,
Le 20/07/2015 23:59, Greg KH a écrit :
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
diff --git a/Documentation/ABI/testing/sysfs-driver-ebeam
b/Documentation/ABI/testing/sysfs-driver-ebeam
+++ b/Documentation/ABI/testing/sysfs-driver-ebeam
@@ -0,0 +1,53 @@
+What:
On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote:
> Signed-off-by: Yann Cantin
> ---
> Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
> drivers/input/misc/Kconfig | 22 +
> drivers/input/misc/Makefile | 1 +
> drivers/input/misc/ebeam.c
On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote:
Signed-off-by: Yann Cantin yann.can...@laposte.net
---
Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
drivers/input/misc/Kconfig | 22 +
drivers/input/misc/Makefile | 1 +
Hi,
Le 20/07/2015 23:59, Greg KH a écrit :
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
diff --git a/Documentation/ABI/testing/sysfs-driver-ebeam
b/Documentation/ABI/testing/sysfs-driver-ebeam
+++ b/Documentation/ABI/testing/sysfs-driver-ebeam
@@ -0,0 +1,53 @@
+What:
Hi,
Le 21/07/2015 00:40, Greg KH a écrit :
On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote:
On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote:
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
Signed-off-by: Yann Cantin yann.can...@laposte.net
+
+ /*
Hi,
Le 21/07/2015 10:19, Oliver Neukum a écrit :
On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote:
diff --git a/drivers/input/misc/ebeam.c b/drivers/input/misc/ebeam.c
new file mode 100644
index 000..79cac51
--- /dev/null
+++ b/drivers/input/misc/ebeam.c
+/* Electronics For
On Mon, Jul 20, 2015 at 03:40:33PM -0700, Greg KH wrote:
> On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote:
> > On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote:
> > > On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
> > > > Signed-off-by: Yann Cantin
> > >
> >
On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote:
> On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote:
> > On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
> > > Signed-off-by: Yann Cantin
> >
> > > +
> > > + /* sysfs setup */
> > > + err =
On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote:
> On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
> > Signed-off-by: Yann Cantin
>
> > +
> > + /* sysfs setup */
> > + err = sysfs_create_group(>dev.kobj, _attr_group);
>
> Ick, you just added the sysfs files to the USB
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
> Signed-off-by: Yann Cantin
You need some kind of text in the changelog here...
> ---
> Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
> drivers/input/misc/Kconfig | 22 +
> drivers/input/misc/Makefile
Signed-off-by: Yann Cantin
---
Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
drivers/input/misc/Kconfig | 22 +
drivers/input/misc/Makefile | 1 +
drivers/input/misc/ebeam.c | 777 +++
4 files changed, 853
Signed-off-by: Yann Cantin yann.can...@laposte.net
---
Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
drivers/input/misc/Kconfig | 22 +
drivers/input/misc/Makefile | 1 +
drivers/input/misc/ebeam.c | 777 +++
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
Signed-off-by: Yann Cantin yann.can...@laposte.net
You need some kind of text in the changelog here...
---
Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
drivers/input/misc/Kconfig | 22 +
On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote:
On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote:
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
Signed-off-by: Yann Cantin yann.can...@laposte.net
+
+ /* sysfs setup */
+ err =
On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote:
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
Signed-off-by: Yann Cantin yann.can...@laposte.net
+
+ /* sysfs setup */
+ err = sysfs_create_group(intf-dev.kobj, ebeam_attr_group);
Ick, you just added the
On Mon, Jul 20, 2015 at 03:40:33PM -0700, Greg KH wrote:
On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote:
On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote:
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote:
Signed-off-by: Yann Cantin
Hi,
All issues addressed. Just a point :
>> +
>> +/* input final setup */
>> +ebeam_setup_input(ebeam, input_dev);
>> +
>> +err = input_register_device(ebeam->input);
>> +if (err) {
>> +dev_dbg(>dev,
>> +"%s - input_register_device failed, err:
On Fri, 2013-08-16 at 22:25 +0200, Yann Cantin wrote:
> +/* IRQ */
> +static int ebeam_read_data(struct ebeam_device *ebeam, unsigned char *pkt)
> +{
> +
> +/*
> + * Packet description : 8 bytes
> + *
> + * nop packet : FF FF FF FF FF FF FF FF
> + *
> + * pkt[0] : Sensors
> + * bit 1 :
On Fri, 2013-08-16 at 22:25 +0200, Yann Cantin wrote:
+/* IRQ */
+static int ebeam_read_data(struct ebeam_device *ebeam, unsigned char *pkt)
+{
+
+/*
+ * Packet description : 8 bytes
+ *
+ * nop packet : FF FF FF FF FF FF FF FF
+ *
+ * pkt[0] : Sensors
+ * bit 1 : ultrasound signal
Hi,
All issues addressed. Just a point :
+
+/* input final setup */
+ebeam_setup_input(ebeam, input_dev);
+
+err = input_register_device(ebeam-input);
+if (err) {
+dev_dbg(intf-dev,
+%s - input_register_device failed, err: %d\n,
+
Signed-off-by: Yann Cantin
---
Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
drivers/input/misc/Kconfig | 22 +
drivers/input/misc/Makefile | 1 +
drivers/input/misc/ebeam.c | 763 +++
4 files changed, 839
Signed-off-by: Yann Cantin yann.can...@laposte.net
---
Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
drivers/input/misc/Kconfig | 22 +
drivers/input/misc/Makefile | 1 +
drivers/input/misc/ebeam.c | 763 +++
Signed-off-by: Yann Cantin
---
Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
drivers/input/misc/Kconfig | 22 +
drivers/input/misc/Makefile | 1 +
drivers/input/misc/ebeam.c | 763 +++
4 files changed, 839
Signed-off-by: Yann Cantin yann.can...@laposte.net
---
Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++
drivers/input/misc/Kconfig | 22 +
drivers/input/misc/Makefile | 1 +
drivers/input/misc/ebeam.c | 763 +++
On Wednesday 05 September 2012 21:58:06 Yann Cantin wrote:
> As ebeams are the only devices to my knowledge that work that way, i don't
> think
> a common API can be common, unless we mean an in-kernel generic purpose
> calibration
> API for input devices (stellar away for me), or a userland
Hi,
Le 05/09/2012 09:29, Oliver Neukum a écrit :
> before we add yet another sysfs interface, we should ask whether calibration
> isn't a problem that should be solved with a common API.
Short answer : no.
##
Long answer (may be oot) :
Existing calibration tools or procedures (in kernel
On Sunday 02 September 2012 00:52:03 Yann Cantin wrote:
Hi,
before we add yet another sysfs interface, we should ask whether calibration
isn't a problem that should be solved with a common API.
Regards
Oliver
> +static ssize_t ebeam_calibrated_set(struct device *dev,
>
On Sunday 02 September 2012 00:52:03 Yann Cantin wrote:
Hi,
before we add yet another sysfs interface, we should ask whether calibration
isn't a problem that should be solved with a common API.
Regards
Oliver
+static ssize_t ebeam_calibrated_set(struct device *dev,
+
Hi,
Le 05/09/2012 09:29, Oliver Neukum a écrit :
before we add yet another sysfs interface, we should ask whether calibration
isn't a problem that should be solved with a common API.
Short answer : no.
##
Long answer (may be oot) :
Existing calibration tools or procedures (in kernel modules
On Wednesday 05 September 2012 21:58:06 Yann Cantin wrote:
As ebeams are the only devices to my knowledge that work that way, i don't
think
a common API can be common, unless we mean an in-kernel generic purpose
calibration
API for input devices (stellar away for me), or a userland one
Signed-off-by: Yann Cantin
---
drivers/input/misc/Kconfig | 22 ++
drivers/input/misc/Makefile |1 +
drivers/input/misc/ebeam.c | 750 +++
3 files changed, 773 insertions(+)
create mode 100644 drivers/input/misc/ebeam.c
diff --git
Signed-off-by: Yann Cantin yann.can...@laposte.net
---
drivers/input/misc/Kconfig | 22 ++
drivers/input/misc/Makefile |1 +
drivers/input/misc/ebeam.c | 750 +++
3 files changed, 773 insertions(+)
create mode 100644 drivers/input/misc/ebeam.c
34 matches
Mail list logo
