Re: [PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

Hi, On Wed, Aug 15, 2012 at 09:34:21AM +0300, Hiroshi Doyu wrote: > > > @@ -892,6 +909,164 @@ static struct iommu_ops smmu_iommu_ops = { > > > .pgsize_bitmap = SMMU_IOMMU_PGSIZES, > > > }; > > > > > > +/* Should be in the order of enum */ > > > +static const char * const smmu_debugfs_mc[]

Re: [PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

Hi, Thank you for review. Already sent the another version of patch(v2: *1), but I tried to answer the remaining questions inlined. On Wed, 8 Aug 2012 17:31:02 +0200 Felipe Balbi wrote: > * PGP Signed by an unknown key > > Hi, > > On Wed, Aug 08, 2012 at 06:11:29PM +0300, Felipe Balbi

Re: [PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

Hi, Thank you for review. Already sent the another version of patch(v2: *1), but I tried to answer the remaining questions inlined. On Wed, 8 Aug 2012 17:31:02 +0200 Felipe Balbi ba...@ti.com wrote: * PGP Signed by an unknown key Hi, On Wed, Aug 08, 2012 at 06:11:29PM +0300, Felipe

Re: [PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

Hi, On Wed, Aug 15, 2012 at 09:34:21AM +0300, Hiroshi Doyu wrote: @@ -892,6 +909,164 @@ static struct iommu_ops smmu_iommu_ops = { .pgsize_bitmap = SMMU_IOMMU_PGSIZES, }; +/* Should be in the order of enum */ +static const char * const smmu_debugfs_mc[] = { mc, };

Re: [PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

Hi, On Wed, Aug 08, 2012 at 06:11:29PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Aug 08, 2012 at 09:24:33AM +0300, Hiroshi Doyu wrote: > > The commit c3b1a35 "debugfs: make sure that debugfs_create_file() gets > > used only for regulars" doesn't allow to use debugfs_create_file() for > > dir.

Re: [PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

Hi, On Wed, Aug 08, 2012 at 09:24:33AM +0300, Hiroshi Doyu wrote: > The commit c3b1a35 "debugfs: make sure that debugfs_create_file() gets > used only for regulars" doesn't allow to use debugfs_create_file() for > dir. Use the version with "data", __debugfs_create_dir(). > > Signed-off-by:

[PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

The commit c3b1a35 "debugfs: make sure that debugfs_create_file() gets used only for regulars" doesn't allow to use debugfs_create_file() for dir. Use the version with "data", __debugfs_create_dir(). Signed-off-by: Hiroshi Doyu Reported-by: Laxman Dewangan --- drivers/iommu/tegra-smmu.c |4

[PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

The commit c3b1a35 debugfs: make sure that debugfs_create_file() gets used only for regulars doesn't allow to use debugfs_create_file() for dir. Use the version with data, __debugfs_create_dir(). Signed-off-by: Hiroshi Doyu hd...@nvidia.com Reported-by: Laxman Dewangan ldewan...@nvidia.com ---

Re: [PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

Hi, On Wed, Aug 08, 2012 at 09:24:33AM +0300, Hiroshi Doyu wrote: The commit c3b1a35 debugfs: make sure that debugfs_create_file() gets used only for regulars doesn't allow to use debugfs_create_file() for dir. Use the version with data, __debugfs_create_dir(). Signed-off-by: Hiroshi Doyu

Re: [PATCH 2/2] iommu/tegra: smmu: Use __debugfs_create_dir

Hi, On Wed, Aug 08, 2012 at 06:11:29PM +0300, Felipe Balbi wrote: Hi, On Wed, Aug 08, 2012 at 09:24:33AM +0300, Hiroshi Doyu wrote: The commit c3b1a35 debugfs: make sure that debugfs_create_file() gets used only for regulars doesn't allow to use debugfs_create_file() for dir. Use the