Re: [PATCH 2/2] lib: Remove module auto-unloading which encourages inconsistent behaviour

2018-01-01 Thread Pravin Shedge
On Fri, Dec 29, 2017 at 10:17 PM, Andy Shevchenko wrote: > On Sat, Dec 23, 2017 at 5:28 PM, Pravin Shedge > wrote: >> The module auto-unload might seem like a nice optimization, but >> it encourages inconsistent behaviour. And behaviour that is >> different from all other normal modules. >> >> rb

Re: [PATCH 2/2] lib: Remove module auto-unloading which encourages inconsistent behaviour

2017-12-29 Thread Andy Shevchenko
On Sat, Dec 23, 2017 at 5:28 PM, Pravin Shedge wrote: > The module auto-unload might seem like a nice optimization, but > it encourages inconsistent behaviour. And behaviour that is > different from all other normal modules. > > rbtree_test.c and percpu_test.c returns -EAGAIN from module_init() >

[PATCH 2/2] lib: Remove module auto-unloading which encourages inconsistent behaviour

2017-12-23 Thread Pravin Shedge
The module auto-unload might seem like a nice optimization, but it encourages inconsistent behaviour. And behaviour that is different from all other normal modules. rbtree_test.c and percpu_test.c returns -EAGAIN from module_init() on successful completion. Normal module return 0 on success but re