Re: [PATCH 2/2] media: v4l2-mem2mem: simplify poll logic a bit

2020-08-26 Thread Hans Verkuil
On 26/08/2020 16:32, Ezequiel Garcia wrote: > On Wed, 26 Aug 2020 at 08:19, Alexandre Courbot wrote: >> >> Hi Ezequiel, thanks for the review! >> >> On Wed, Aug 26, 2020 at 1:15 PM Ezequiel Garcia >> wrote: >>> >>> Hi Alexandre, >>> >>> On Tue, 25 Aug 2020 at 11:56, Alexandre Courbot wrote:

Re: [PATCH 2/2] media: v4l2-mem2mem: simplify poll logic a bit

2020-08-26 Thread Ezequiel Garcia
On Wed, 26 Aug 2020 at 08:19, Alexandre Courbot wrote: > > Hi Ezequiel, thanks for the review! > > On Wed, Aug 26, 2020 at 1:15 PM Ezequiel Garcia > wrote: > > > > Hi Alexandre, > > > > On Tue, 25 Aug 2020 at 11:56, Alexandre Courbot wrote: > > > > > > Factorize redundant checks into a single co

Re: [PATCH 2/2] media: v4l2-mem2mem: simplify poll logic a bit

2020-08-26 Thread Hans Verkuil
On 25/08/2020 16:55, Alexandre Courbot wrote: > Factorize redundant checks into a single code block, remove the early > return, and declare variables in their innermost block. Hopefully this > makes this code a little bit easier to follow. > > Signed-off-by: Alexandre Courbot > --- > drivers/med

Re: [PATCH 2/2] media: v4l2-mem2mem: simplify poll logic a bit

2020-08-26 Thread Alexandre Courbot
Hi Ezequiel, thanks for the review! On Wed, Aug 26, 2020 at 1:15 PM Ezequiel Garcia wrote: > > Hi Alexandre, > > On Tue, 25 Aug 2020 at 11:56, Alexandre Courbot wrote: > > > > Factorize redundant checks into a single code block, remove the early > > return, and declare variables in their innermo

Re: [PATCH 2/2] media: v4l2-mem2mem: simplify poll logic a bit

2020-08-25 Thread Ezequiel Garcia
Hi Alexandre, On Tue, 25 Aug 2020 at 11:56, Alexandre Courbot wrote: > > Factorize redundant checks into a single code block, remove the early > return, and declare variables in their innermost block. Hopefully this > makes this code a little bit easier to follow. > This _definitely_ makes the p

[PATCH 2/2] media: v4l2-mem2mem: simplify poll logic a bit

2020-08-25 Thread Alexandre Courbot
Factorize redundant checks into a single code block, remove the early return, and declare variables in their innermost block. Hopefully this makes this code a little bit easier to follow. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-mem2mem.c | 35 +++---