Re: [PATCH 2/2] mwifiex: use 'total_ie_len' in mwifiex_update_bss_desc_with_ie()

2019-10-01 Thread Kalle Valo
Brian Norris wrote: > This is clearer than copy/pasting the magic number '+ 2' around, and it > even saves the need for one existing comment. > > Cc: Takashi Iwai > Signed-off-by: Brian Norris > Reviewed-by: Takashi Iwai Patch applied to wireless-drivers-next.git, thanks. 0a3ce169476f

Re: [PATCH 2/2] mwifiex: use 'total_ie_len' in mwifiex_update_bss_desc_with_ie()

2019-06-24 Thread Kalle Valo
Brian Norris wrote: > This is clearer than copy/pasting the magic number '+ 2' around, and it > even saves the need for one existing comment. > > Cc: Takashi Iwai > Signed-off-by: Brian Norris > Reviewed-by: Takashi Iwai This depends on: 63d7ef36103d mwifiex: Don't abort on small,

Re: [PATCH 2/2] mwifiex: use 'total_ie_len' in mwifiex_update_bss_desc_with_ie()

2019-06-17 Thread Takashi Iwai
On Sat, 15 Jun 2019 02:13:21 +0200, Brian Norris wrote: > > This is clearer than copy/pasting the magic number '+ 2' around, and it > even saves the need for one existing comment. > > Cc: Takashi Iwai > Signed-off-by: Brian Norris Reviewed-by: Takashi Iwai thanks, Takashi

[PATCH 2/2] mwifiex: use 'total_ie_len' in mwifiex_update_bss_desc_with_ie()

2019-06-14 Thread Brian Norris
This is clearer than copy/pasting the magic number '+ 2' around, and it even saves the need for one existing comment. Cc: Takashi Iwai Signed-off-by: Brian Norris --- drivers/net/wireless/marvell/mwifiex/scan.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git