Re: [PATCH 2/2] net: phy: leds: Fix truncated LED trigger names

2017-01-25 Thread Geert Uytterhoeven
Hi Andrew, On Tue, Jan 24, 2017 at 9:03 PM, Andrew Lunn wrote: >> diff --git a/include/linux/phy.h b/include/linux/phy.h >> index 5c9d2529685fe215..f6ab919528ab3627 100644 >> --- a/include/linux/phy.h >> +++ b/include/linux/phy.h >> @@ -25,7 +25,6 @@ >> #include >> #include

Re: [PATCH 2/2] net: phy: leds: Fix truncated LED trigger names

2017-01-25 Thread Geert Uytterhoeven
Hi Andrew, On Tue, Jan 24, 2017 at 9:03 PM, Andrew Lunn wrote: >> diff --git a/include/linux/phy.h b/include/linux/phy.h >> index 5c9d2529685fe215..f6ab919528ab3627 100644 >> --- a/include/linux/phy.h >> +++ b/include/linux/phy.h >> @@ -25,7 +25,6 @@ >> #include >> #include >> #include >>

Re: [PATCH 2/2] net: phy: leds: Fix truncated LED trigger names

2017-01-24 Thread Andrew Lunn
> diff --git a/include/linux/phy.h b/include/linux/phy.h > index 5c9d2529685fe215..f6ab919528ab3627 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > > #include > > @@ -339,6 +338,8 @@ struct

Re: [PATCH 2/2] net: phy: leds: Fix truncated LED trigger names

2017-01-24 Thread Andrew Lunn
> diff --git a/include/linux/phy.h b/include/linux/phy.h > index 5c9d2529685fe215..f6ab919528ab3627 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > > #include > > @@ -339,6 +338,8 @@ struct

[PATCH 2/2] net: phy: leds: Fix truncated LED trigger names

2017-01-24 Thread Geert Uytterhoeven
Commit 4567d686f5c6d955 ("phy: increase size of MII_BUS_ID_SIZE and bus_id") increased the size of MII bus IDs, but forgot to update the private definition in . This may cause: 1. Truncation of LED trigger names, 2. Duplicate LED trigger names, 3. Failures registering LED triggers, 4.

[PATCH 2/2] net: phy: leds: Fix truncated LED trigger names

2017-01-24 Thread Geert Uytterhoeven
Commit 4567d686f5c6d955 ("phy: increase size of MII_BUS_ID_SIZE and bus_id") increased the size of MII bus IDs, but forgot to update the private definition in . This may cause: 1. Truncation of LED trigger names, 2. Duplicate LED trigger names, 3. Failures registering LED triggers, 4.