Re: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-06 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 06, 2015 at 05:27:06PM +0800, Wangnan (F) escreveu: > On 2015/11/6 16:30, Wangnan (F) wrote: > >On 2015/11/6 15:12, 平松雅巳 / HIRAMATU,MASAMI wrote: > >>From: a...@kernel.org [mailto:a...@kernel.org] > Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: >

Re: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-06 Thread Wangnan (F)
On 2015/11/6 16:30, Wangnan (F) wrote: On 2015/11/6 15:12, 平松雅巳 / HIRAMATU,MASAMI wrote: From: a...@kernel.org [mailto:a...@kernel.org] Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: From: Wang Nan [mailto:wangn...@huawei.com] [SNIP] Ah, finally I got what

Re: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-06 Thread Wangnan (F)
On 2015/11/6 15:12, 平松雅巳 / HIRAMATU,MASAMI wrote: From: a...@kernel.org [mailto:a...@kernel.org] Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: From: Wang Nan [mailto:wangn...@huawei.com] It is possible that find_perf_probe_point_from_map() fails to find symbol

Re: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-06 Thread Wangnan (F)
On 2015/11/6 15:12, 平松雅巳 / HIRAMATU,MASAMI wrote: From: a...@kernel.org [mailto:a...@kernel.org] Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: From: Wang Nan [mailto:wangn...@huawei.com] It is possible that find_perf_probe_point_from_map() fails to find symbol

Re: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-06 Thread Wangnan (F)
On 2015/11/6 16:30, Wangnan (F) wrote: On 2015/11/6 15:12, 平松雅巳 / HIRAMATU,MASAMI wrote: From: a...@kernel.org [mailto:a...@kernel.org] Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: From: Wang Nan [mailto:wangn...@huawei.com] [SNIP] Ah, finally I got what

Re: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-06 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 06, 2015 at 05:27:06PM +0800, Wangnan (F) escreveu: > On 2015/11/6 16:30, Wangnan (F) wrote: > >On 2015/11/6 15:12, 平松雅巳 / HIRAMATU,MASAMI wrote: > >>From: a...@kernel.org [mailto:a...@kernel.org] > Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: >

RE: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread 平松雅巳 / HIRAMATU,MASAMI
From: a...@kernel.org [mailto:a...@kernel.org] >> >>Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: >>> From: Wang Nan [mailto:wangn...@huawei.com] >>> > >>> >It is possible that find_perf_probe_point_from_map() fails to find >>> >symbol but still returns 0 because of an

RE: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread 平松雅巳 / HIRAMATU,MASAMI
From: a...@kernel.org [mailto:a...@kernel.org] > >Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: >> From: Wang Nan [mailto:wangn...@huawei.com] >> > >> >It is possible that find_perf_probe_point_from_map() fails to find >> >symbol but still returns 0 because of an small

Re: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread a...@kernel.org
Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: > From: Wang Nan [mailto:wangn...@huawei.com] > > > >It is possible that find_perf_probe_point_from_map() fails to find > >symbol but still returns 0 because of an small error when coding: >

RE: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread 平松雅巳 / HIRAMATU,MASAMI
From: Wang Nan [mailto:wangn...@huawei.com] > >It is possible that find_perf_probe_point_from_map() fails to find >symbol but still returns 0 because of an small error when coding: >find_perf_probe_point_from_map() set 'ret' to error code at first, >but also use it to hold return value of

[PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread Wang Nan
It is possible that find_perf_probe_point_from_map() fails to find symbol but still returns 0 because of an small error when coding: find_perf_probe_point_from_map() set 'ret' to error code at first, but also use it to hold return value of kernel_get_symbol_address_by_name(). This patch resets

[PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread Wang Nan
It is possible that find_perf_probe_point_from_map() fails to find symbol but still returns 0 because of an small error when coding: find_perf_probe_point_from_map() set 'ret' to error code at first, but also use it to hold return value of kernel_get_symbol_address_by_name(). This patch resets

Re: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread a...@kernel.org
Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: > From: Wang Nan [mailto:wangn...@huawei.com] > > > >It is possible that find_perf_probe_point_from_map() fails to find > >symbol but still returns 0 because of an small error when coding: >

RE: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread 平松雅巳 / HIRAMATU,MASAMI
From: a...@kernel.org [mailto:a...@kernel.org] > >Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: >> From: Wang Nan [mailto:wangn...@huawei.com] >> > >> >It is possible that find_perf_probe_point_from_map() fails to find >> >symbol but still returns 0 because of an small

RE: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread 平松雅巳 / HIRAMATU,MASAMI
From: a...@kernel.org [mailto:a...@kernel.org] >> >>Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: >>> From: Wang Nan [mailto:wangn...@huawei.com] >>> > >>> >It is possible that find_perf_probe_point_from_map() fails to find >>> >symbol but still returns 0 because of an

RE: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread 平松雅巳 / HIRAMATU,MASAMI
From: Wang Nan [mailto:wangn...@huawei.com] > >It is possible that find_perf_probe_point_from_map() fails to find >symbol but still returns 0 because of an small error when coding: >find_perf_probe_point_from_map() set 'ret' to error code at first, >but also use it to hold return value of