Re: [PATCH 2/2] pipe: do not return POLLERR for fifo_poll

2005-08-26 Thread Manfred Spraul
Pekka J Enberg wrote: FWIW I have been running on this for few days now without any noticeable regressions. We get a solved FIXME in return but like I said I am a happy to remove the redundant abstraction if this is too risky. I would prefer just to remove the abstraction, together with

Re: [PATCH 2/2] pipe: do not return POLLERR for fifo_poll

2005-08-26 Thread Pekka J Enberg
Pekka Enberg <[EMAIL PROTECTED]> wrote: > > This patch changes fifo_poll not to return POLLERR to take care of a FIXME > > in fs/pipe.c stating that "Most unices do not set POLLERR for fifos." The > > comment has been there since 2.3.99-pre3 so either apply this patch or > > alternatively, I can

Re: [PATCH 2/2] pipe: do not return POLLERR for fifo_poll

2005-08-26 Thread Pekka J Enberg
Pekka Enberg [EMAIL PROTECTED] wrote: This patch changes fifo_poll not to return POLLERR to take care of a FIXME in fs/pipe.c stating that Most unices do not set POLLERR for fifos. The comment has been there since 2.3.99-pre3 so either apply this patch or alternatively, I can send a new

Re: [PATCH 2/2] pipe: do not return POLLERR for fifo_poll

2005-08-26 Thread Manfred Spraul
Pekka J Enberg wrote: FWIW I have been running on this for few days now without any noticeable regressions. We get a solved FIXME in return but like I said I am a happy to remove the redundant abstraction if this is too risky. I would prefer just to remove the abstraction, together with

Re: [PATCH 2/2] pipe: do not return POLLERR for fifo_poll

2005-08-25 Thread Andrew Morton
Pekka Enberg <[EMAIL PROTECTED]> wrote: > > This patch changes fifo_poll not to return POLLERR to take care of a FIXME > in fs/pipe.c stating that "Most unices do not set POLLERR for fifos." The > comment has been there since 2.3.99-pre3 so either apply this patch or > alternatively, I can send a

Re: [PATCH 2/2] pipe: do not return POLLERR for fifo_poll

2005-08-25 Thread Andrew Morton
Pekka Enberg [EMAIL PROTECTED] wrote: This patch changes fifo_poll not to return POLLERR to take care of a FIXME in fs/pipe.c stating that Most unices do not set POLLERR for fifos. The comment has been there since 2.3.99-pre3 so either apply this patch or alternatively, I can send a new one