Re: [EXTERNAL] Re: [PATCH 2/2] power: supply: bq25980: Moves properties from battery node

2021-02-10 Thread Ricardo Rivera-Matos
On 2/10/21 2:23 AM, Krzysztof Kozlowski wrote: On Wed, 10 Feb 2021 at 00:52, Ricardo Rivera-Matos wrote: fix: exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT on the charger node Why is this a fix? Why is exposing this property wrong? What is the problem here? Why do you start sentences

Re: [PATCH 2/2] power: supply: bq25980: Moves properties from battery node

2021-02-10 Thread Krzysztof Kozlowski
On Wed, 10 Feb 2021 at 00:52, Ricardo Rivera-Matos wrote: > > fix: exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT on the > > charger node Why is this a fix? Why is exposing this property wrong? What is the problem here? Why do you start sentences with a small letter? Your commit message

[PATCH 2/2] power: supply: bq25980: Moves properties from battery node

2021-02-09 Thread Ricardo Rivera-Matos
fix: exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT on the charger node fix: exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE on the charger node fix: eliminates unnecessary set_property for the battery node Fixes: 5069185fc18e ("power: supply: bq25980: Add support for the BQ259xx