Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-21 Thread Uwe Kleine-König
Hello Thierry, On Mon, Jan 21, 2019 at 12:54:55PM +0100, Thierry Reding wrote: > On Thu, Jan 17, 2019 at 09:19:56AM +0100, Uwe Kleine-König wrote: > > On Wed, Jan 16, 2019 at 11:29:35AM -0800, Paul Walmsley wrote: > > > COMPILE_TEST made slightly more sense before the broad availability of > > >

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-21 Thread Uwe Kleine-König
On Mon, Jan 21, 2019 at 12:30:39PM +0100, Thierry Reding wrote: > On Tue, Jan 15, 2019 at 11:00:46PM +0100, Uwe Kleine-König wrote: > > Hello, > > > > On Fri, Jan 11, 2019 at 01:52:44PM +0530, Yash Shah wrote: > > > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > > >

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-21 Thread Thierry Reding
On Thu, Jan 17, 2019 at 09:19:56AM +0100, Uwe Kleine-König wrote: > Hello Paul, > > On Wed, Jan 16, 2019 at 11:29:35AM -0800, Paul Walmsley wrote: > > COMPILE_TEST made slightly more sense before the broad availability of > > open-source soft cores, SoC integration, and IP; and before powerful,

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-21 Thread Thierry Reding
On Tue, Jan 15, 2019 at 11:00:46PM +0100, Uwe Kleine-König wrote: > Hello, > > On Fri, Jan 11, 2019 at 01:52:44PM +0530, Yash Shah wrote: > > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > > > Signed-off-by: Wesley W. Terpstra > > [Atish: Various fixes and code

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-17 Thread Uwe Kleine-König
Hello Paul, On Wed, Jan 16, 2019 at 11:29:35AM -0800, Paul Walmsley wrote: > COMPILE_TEST made slightly more sense before the broad availability of > open-source soft cores, SoC integration, and IP; and before powerful, > inexpensive FPGAs and SoCs with FPGA fabrics were common. > > Even back

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-16 Thread Uwe Kleine-König
Hello, On Thu, Jan 17, 2019 at 12:15:38PM +0530, Yash Shah wrote: > On Wed, Jan 16, 2019 at 10:16 PM Uwe Kleine-König > wrote: > > > > Hello, > > > > On Wed, Jan 16, 2019 at 04:40:42PM +0530, Yash Shah wrote: > > > On Wed, Jan 16, 2019 at 3:30 AM Uwe Kleine-König > > > wrote: > > > > On Fri,

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-16 Thread Yash Shah
On Wed, Jan 16, 2019 at 10:16 PM Uwe Kleine-König wrote: > > Hello, > > On Wed, Jan 16, 2019 at 04:40:42PM +0530, Yash Shah wrote: > > On Wed, Jan 16, 2019 at 3:30 AM Uwe Kleine-König > > wrote: > > > On Fri, Jan 11, 2019 at 01:52:44PM +0530, Yash Shah wrote: > > > > Adds a PWM driver for PWM

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-16 Thread Paul Walmsley
On Wed, 16 Jan 2019, Uwe Kleine-König wrote: > On Wed, Jan 16, 2019 at 09:18:45AM -0800, Paul Walmsley wrote: > > On Wed, 16 Jan 2019, Uwe Kleine-König wrote: > > > > > On Wed, Jan 16, 2019 at 04:40:42PM +0530, Yash Shah wrote: > > > > On Wed, Jan 16, 2019 at 3:30 AM Uwe Kleine-König > > > >

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-16 Thread Uwe Kleine-König
On Wed, Jan 16, 2019 at 09:18:45AM -0800, Paul Walmsley wrote: > On Wed, 16 Jan 2019, Uwe Kleine-König wrote: > > > On Wed, Jan 16, 2019 at 04:40:42PM +0530, Yash Shah wrote: > > > On Wed, Jan 16, 2019 at 3:30 AM Uwe Kleine-König > > > wrote: > > > > On Fri, Jan 11, 2019 at 01:52:44PM +0530,

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-16 Thread Paul Walmsley
On Wed, 16 Jan 2019, Uwe Kleine-König wrote: > On Wed, Jan 16, 2019 at 04:40:42PM +0530, Yash Shah wrote: > > On Wed, Jan 16, 2019 at 3:30 AM Uwe Kleine-König > > wrote: > > > On Fri, Jan 11, 2019 at 01:52:44PM +0530, Yash Shah wrote: > > > > diff --git a/drivers/pwm/Kconfig

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-16 Thread Uwe Kleine-König
Hello, On Wed, Jan 16, 2019 at 04:40:42PM +0530, Yash Shah wrote: > On Wed, Jan 16, 2019 at 3:30 AM Uwe Kleine-König > wrote: > > On Fri, Jan 11, 2019 at 01:52:44PM +0530, Yash Shah wrote: > > > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > > > > > Signed-off-by:

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-16 Thread Yash Shah
On Wed, Jan 16, 2019 at 3:30 AM Uwe Kleine-König wrote: > > Hello, > > On Fri, Jan 11, 2019 at 01:52:44PM +0530, Yash Shah wrote: > > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > > > Signed-off-by: Wesley W. Terpstra > > [Atish: Various fixes and code cleanup] > >

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-15 Thread Uwe Kleine-König
Hello, On Fri, Jan 11, 2019 at 01:52:44PM +0530, Yash Shah wrote: > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > Signed-off-by: Wesley W. Terpstra > [Atish: Various fixes and code cleanup] > Signed-off-by: Atish Patra > Signed-off-by: Yash Shah > --- >

Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-15 Thread Christoph Hellwig
>From a general code quality point of view this looks fine to me. I don't really know anything about the PWM subsystem, though: Reviewed-by: Christoph Hellwig

[PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-11 Thread Yash Shah
Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. Signed-off-by: Wesley W. Terpstra [Atish: Various fixes and code cleanup] Signed-off-by: Atish Patra Signed-off-by: Yash Shah --- drivers/pwm/Kconfig | 10 ++ drivers/pwm/Makefile | 1 +