Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On Fri, Jun 09, 2017 at 12:42:06PM +0100, Juri Lelli wrote: > > > > This would also work and avoid unnecessary warning. I missed the check > > to avoid it. https://lkml.org/lkml/2017/3/23/175 was an original patch > > doing it. > > > > By the way, frankly speaking, I don't like accessing the

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On Fri, Jun 09, 2017 at 12:42:06PM +0100, Juri Lelli wrote: > > > > This would also work and avoid unnecessary warning. I missed the check > > to avoid it. https://lkml.org/lkml/2017/3/23/175 was an original patch > > doing it. > > > > By the way, frankly speaking, I don't like accessing the

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On 09/06/17 11:43, Byungchul Park wrote: > On Thu, Jun 08, 2017 at 03:02:43PM +0100, Juri Lelli wrote: > > On 07/06/17 09:14, Byungchul Park wrote: > > > On Wed, Jun 07, 2017 at 08:42:24AM +0900, Byungchul Park wrote: > > > > On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > > > > >

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On 09/06/17 11:43, Byungchul Park wrote: > On Thu, Jun 08, 2017 at 03:02:43PM +0100, Juri Lelli wrote: > > On 07/06/17 09:14, Byungchul Park wrote: > > > On Wed, Jun 07, 2017 at 08:42:24AM +0900, Byungchul Park wrote: > > > > On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > > > > >

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On Thu, Jun 08, 2017 at 03:02:43PM +0100, Juri Lelli wrote: > On 07/06/17 09:14, Byungchul Park wrote: > > On Wed, Jun 07, 2017 at 08:42:24AM +0900, Byungchul Park wrote: > > > On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > > > > Hi, > > > > > > > > On 02/06/17 16:31, Byungchul

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On Thu, Jun 08, 2017 at 03:02:43PM +0100, Juri Lelli wrote: > On 07/06/17 09:14, Byungchul Park wrote: > > On Wed, Jun 07, 2017 at 08:42:24AM +0900, Byungchul Park wrote: > > > On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > > > > Hi, > > > > > > > > On 02/06/17 16:31, Byungchul

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On 07/06/17 09:14, Byungchul Park wrote: > On Wed, Jun 07, 2017 at 08:42:24AM +0900, Byungchul Park wrote: > > On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > > > Hi, > > > > > > On 02/06/17 16:31, Byungchul Park wrote: [...] > > > > > > > > static inline int

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On 07/06/17 09:14, Byungchul Park wrote: > On Wed, Jun 07, 2017 at 08:42:24AM +0900, Byungchul Park wrote: > > On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > > > Hi, > > > > > > On 02/06/17 16:31, Byungchul Park wrote: [...] > > > > > > > > static inline int

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On Wed, Jun 07, 2017 at 08:42:24AM +0900, Byungchul Park wrote: > On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > > Hi, > > > > On 02/06/17 16:31, Byungchul Park wrote: > > > When the heap tree is empty, cp->elements[0].cpu has meaningless value. > > Hi, > > The meaningless value

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On Wed, Jun 07, 2017 at 08:42:24AM +0900, Byungchul Park wrote: > On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > > Hi, > > > > On 02/06/17 16:31, Byungchul Park wrote: > > > When the heap tree is empty, cp->elements[0].cpu has meaningless value. > > Hi, > > The meaningless value

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > Hi, > > On 02/06/17 16:31, Byungchul Park wrote: > > When the heap tree is empty, cp->elements[0].cpu has meaningless value. Hi, The meaningless value is 0. > > We need to consider the case. > > > > Signed-off-by: Byungchul Park

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote: > Hi, > > On 02/06/17 16:31, Byungchul Park wrote: > > When the heap tree is empty, cp->elements[0].cpu has meaningless value. Hi, The meaningless value is 0. > > We need to consider the case. > > > > Signed-off-by: Byungchul Park >

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

Hi, On 02/06/17 16:31, Byungchul Park wrote: > When the heap tree is empty, cp->elements[0].cpu has meaningless value. > We need to consider the case. > > Signed-off-by: Byungchul Park > --- > kernel/sched/cpudeadline.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

Hi, On 02/06/17 16:31, Byungchul Park wrote: > When the heap tree is empty, cp->elements[0].cpu has meaningless value. > We need to consider the case. > > Signed-off-by: Byungchul Park > --- > kernel/sched/cpudeadline.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

[PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

When the heap tree is empty, cp->elements[0].cpu has meaningless value. We need to consider the case. Signed-off-by: Byungchul Park --- kernel/sched/cpudeadline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/cpudeadline.c

[PATCH 2/2] sched/deadline: Don't return invalid cpu in cpudl_maximum_cpu()

When the heap tree is empty, cp->elements[0].cpu has meaningless value. We need to consider the case. Signed-off-by: Byungchul Park --- kernel/sched/cpudeadline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c index