Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-23 Thread Alex Shi
On 01/23/2014 08:32 PM, Morten Rasmussen wrote: > On Thu, Jan 23, 2014 at 10:49:35AM +, Alex Shi wrote: >> On 01/23/2014 05:54 PM, Peter Zijlstra wrote: >>> On Thu, Jan 23, 2014 at 02:49:25PM +0800, Alex Shi wrote: On 01/23/2014 02:10 AM, Jason Low wrote: > P64(avg_idle);

Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-23 Thread Morten Rasmussen
On Thu, Jan 23, 2014 at 10:49:35AM +, Alex Shi wrote: > On 01/23/2014 05:54 PM, Peter Zijlstra wrote: > > On Thu, Jan 23, 2014 at 02:49:25PM +0800, Alex Shi wrote: > >> On 01/23/2014 02:10 AM, Jason Low wrote: > >>> P64(avg_idle); > >>> + P64(max_idle_balance_cost); > >>>

Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-23 Thread Alex Shi
On 01/23/2014 05:54 PM, Peter Zijlstra wrote: > On Thu, Jan 23, 2014 at 02:49:25PM +0800, Alex Shi wrote: >> On 01/23/2014 02:10 AM, Jason Low wrote: >>> P64(avg_idle); >>> + P64(max_idle_balance_cost); >>> #endif >>> P(ttwu_count); > > Not also the

Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-23 Thread Peter Zijlstra
On Thu, Jan 23, 2014 at 02:49:25PM +0800, Alex Shi wrote: > On 01/23/2014 02:10 AM, Jason Low wrote: > >>> > > P64(avg_idle); > >>> > > + P64(max_idle_balance_cost); > >>> > > #endif > >>> > > P(ttwu_count); > >> > > >> > Not also the per-sd value in sd_alloc_ctl_domain_table() ?

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-23 Thread Peter Zijlstra
On Thu, Jan 23, 2014 at 02:49:25PM +0800, Alex Shi wrote: On 01/23/2014 02:10 AM, Jason Low wrote: P64(avg_idle); + P64(max_idle_balance_cost); #endif P(ttwu_count); Not also the per-sd value in sd_alloc_ctl_domain_table() ? Yeah, tracking the

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-23 Thread Alex Shi
On 01/23/2014 05:54 PM, Peter Zijlstra wrote: On Thu, Jan 23, 2014 at 02:49:25PM +0800, Alex Shi wrote: On 01/23/2014 02:10 AM, Jason Low wrote: P64(avg_idle); + P64(max_idle_balance_cost); #endif P(ttwu_count); Not also the per-sd value in

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-23 Thread Morten Rasmussen
On Thu, Jan 23, 2014 at 10:49:35AM +, Alex Shi wrote: On 01/23/2014 05:54 PM, Peter Zijlstra wrote: On Thu, Jan 23, 2014 at 02:49:25PM +0800, Alex Shi wrote: On 01/23/2014 02:10 AM, Jason Low wrote: P64(avg_idle); + P64(max_idle_balance_cost); #endif

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-23 Thread Alex Shi
On 01/23/2014 08:32 PM, Morten Rasmussen wrote: On Thu, Jan 23, 2014 at 10:49:35AM +, Alex Shi wrote: On 01/23/2014 05:54 PM, Peter Zijlstra wrote: On Thu, Jan 23, 2014 at 02:49:25PM +0800, Alex Shi wrote: On 01/23/2014 02:10 AM, Jason Low wrote: P64(avg_idle); +

Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-22 Thread Alex Shi
On 01/23/2014 02:10 AM, Jason Low wrote: >>> > > P64(avg_idle); >>> > > + P64(max_idle_balance_cost); >>> > > #endif >>> > > P(ttwu_count); >> > >> > Not also the per-sd value in sd_alloc_ctl_domain_table() ? > Yeah, tracking the sd->max_newidle_lb_cost can also be useful.

Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-22 Thread Jason Low
On Wed, 2014-01-22 at 17:09 +0100, Peter Zijlstra wrote: > On Wed, Jan 22, 2014 at 04:24:13PM +0800, Alex Shi wrote: > > From: Alex Shi > > Date: Tue, 21 Jan 2014 13:28:55 +0800 > > Subject: [RFC PATCH] sched: add statistic for rq->max_idle_balance_cost > > > > It's useful to track this value in

Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-22 Thread Peter Zijlstra
On Wed, Jan 22, 2014 at 04:24:13PM +0800, Alex Shi wrote: > From: Alex Shi > Date: Tue, 21 Jan 2014 13:28:55 +0800 > Subject: [RFC PATCH] sched: add statistic for rq->max_idle_balance_cost > > It's useful to track this value in debug mode. > > Signed-off-by: Alex Shi > --- >

Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-22 Thread Alex Shi
On 01/21/2014 03:43 PM, Jason Low wrote: > On Mon, Jan 20, 2014 at 9:33 PM, Alex Shi wrote: >> It's useful to track this value in debug mode. >> >> Signed-off-by: Alex Shi >> --- >> kernel/sched/debug.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/sched/debug.c

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-22 Thread Alex Shi
On 01/21/2014 03:43 PM, Jason Low wrote: On Mon, Jan 20, 2014 at 9:33 PM, Alex Shi alex@linaro.org wrote: It's useful to track this value in debug mode. Signed-off-by: Alex Shi alex@linaro.org --- kernel/sched/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-22 Thread Peter Zijlstra
On Wed, Jan 22, 2014 at 04:24:13PM +0800, Alex Shi wrote: From: Alex Shi alex@linaro.org Date: Tue, 21 Jan 2014 13:28:55 +0800 Subject: [RFC PATCH] sched: add statistic for rq-max_idle_balance_cost It's useful to track this value in debug mode. Signed-off-by: Alex Shi

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-22 Thread Jason Low
On Wed, 2014-01-22 at 17:09 +0100, Peter Zijlstra wrote: On Wed, Jan 22, 2014 at 04:24:13PM +0800, Alex Shi wrote: From: Alex Shi alex@linaro.org Date: Tue, 21 Jan 2014 13:28:55 +0800 Subject: [RFC PATCH] sched: add statistic for rq-max_idle_balance_cost It's useful to track this

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-22 Thread Alex Shi
On 01/23/2014 02:10 AM, Jason Low wrote: P64(avg_idle); + P64(max_idle_balance_cost); #endif P(ttwu_count); Not also the per-sd value in sd_alloc_ctl_domain_table() ? Yeah, tracking the sd-max_newidle_lb_cost can also be useful. Thanks for suggestion!

Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-21 Thread Alex Shi
On 01/21/2014 03:43 PM, Jason Low wrote: > On Mon, Jan 20, 2014 at 9:33 PM, Alex Shi wrote: >> It's useful to track this value in debug mode. >> >> Signed-off-by: Alex Shi >> --- >> kernel/sched/debug.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/sched/debug.c

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-21 Thread Alex Shi
On 01/21/2014 03:43 PM, Jason Low wrote: On Mon, Jan 20, 2014 at 9:33 PM, Alex Shi alex@linaro.org wrote: It's useful to track this value in debug mode. Signed-off-by: Alex Shi alex@linaro.org --- kernel/sched/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-20 Thread Jason Low
On Mon, Jan 20, 2014 at 9:33 PM, Alex Shi wrote: > It's useful to track this value in debug mode. > > Signed-off-by: Alex Shi > --- > kernel/sched/debug.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c > index 1e43e70..f5c529a 100644 > ---

[PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost

2014-01-20 Thread Alex Shi
It's useful to track this value in debug mode. Signed-off-by: Alex Shi --- kernel/sched/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 1e43e70..f5c529a 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -315,6 +315,7 @@

[PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-20 Thread Alex Shi
It's useful to track this value in debug mode. Signed-off-by: Alex Shi alex@linaro.org --- kernel/sched/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 1e43e70..f5c529a 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c

Re: [PATCH 2/2] sched: add statistic for rq-max_idle_balance_cost

2014-01-20 Thread Jason Low
On Mon, Jan 20, 2014 at 9:33 PM, Alex Shi alex@linaro.org wrote: It's useful to track this value in debug mode. Signed-off-by: Alex Shi alex@linaro.org --- kernel/sched/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index