Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-14 Thread Rafał Miłecki
On 14.12.2020 18:32, Florian Fainelli wrote: On 12/14/20 4:24 AM, Rafał Miłecki wrote: On 11.12.2020 23:08, Florian Fainelli wrote: On 12/11/20 1:59 PM, Rafał Miłecki wrote: From: Rafał Miłecki PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). It's needed to power on and

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-14 Thread Florian Fainelli
On 12/14/20 4:24 AM, Rafał Miłecki wrote: > On 11.12.2020 23:08, Florian Fainelli wrote: >> On 12/11/20 1:59 PM, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). >>> It's needed to power on and off SoC blocks like PCIe,

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-14 Thread Rafał Miłecki
On 11.12.2020 23:08, Florian Fainelli wrote: On 12/11/20 1:59 PM, Rafał Miłecki wrote: From: Rafał Miłecki PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). It's needed to power on and off SoC blocks like PCIe, SATA, USB. Signed-off-by: Rafał Miłecki I will do a more

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-14 Thread Rafał Miłecki
On 12.12.2020 04:26, Florian Fainelli wrote: + +static const struct bcm_pmb_pd_data bcm_pmb_bcm4908_data[] = { + { .name = "pcie2", .id = BCM_PMB_PCIE2, .bus = 0, .device = 2, }, + { .name = "pcie0", .id = BCM_PMB_PCIE0, .bus = 1, .device = 14, }, + { .name = "pcie1", .id =

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-11 Thread Florian Fainelli
On 12/11/2020 1:59 PM, Rafał Miłecki wrote: > From: Rafał Miłecki > > PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). > It's needed to power on and off SoC blocks like PCIe, SATA, USB. > > Signed-off-by: Rafał Miłecki This looks good to me, just a few nipicks below.

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-11 Thread Rafał Miłecki
On 11.12.2020 22:59, Rafał Miłecki wrote: @@ -13,6 +13,14 @@ config BCM2835_POWER firmware means that Linux usage of the same power domain must be accessed using the RASPBERRYPI_POWER driver +config BCM_PMB + bool "Broadcom PMB (Power Management Bus) driver" +

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-11 Thread Rafał Miłecki
On Fri, 11 Dec 2020 at 23:08, Florian Fainelli wrote: > On 12/11/20 1:59 PM, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). > > It's needed to power on and off SoC blocks like PCIe, SATA, USB. > > > > Signed-off-by: Rafał

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-11 Thread Florian Fainelli
On 12/11/20 1:59 PM, Rafał Miłecki wrote: > From: Rafał Miłecki > > PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). > It's needed to power on and off SoC blocks like PCIe, SATA, USB. > > Signed-off-by: Rafał Miłecki I will do a more thorough review tonight, however do you

[PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-11 Thread Rafał Miłecki
From: Rafał Miłecki PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). It's needed to power on and off SoC blocks like PCIe, SATA, USB. Signed-off-by: Rafał Miłecki --- drivers/soc/bcm/Kconfig | 8 + drivers/soc/bcm/Makefile | 1 + drivers/soc/bcm/bcm-pmb.c | 335