Re: [PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-26 Thread Ingo Molnar
* John Stultz wrote: > On 07/19/2012 02:33 AM, Ingo Molnar wrote: > >* John Stultz wrote: > > > >>+static void tk_set_sleep_time(struct timekeeper *tk, struct timespec t) > >>+{ > >>+ /* Verify consistency before modifying */ > >>+ WARN_ON_ONCE(tk->offs_boot.tv64 != > >>+

Re: [PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-26 Thread Ingo Molnar
* John Stultz john.stu...@linaro.org wrote: On 07/19/2012 02:33 AM, Ingo Molnar wrote: * John Stultz john.stu...@linaro.org wrote: +static void tk_set_sleep_time(struct timekeeper *tk, struct timespec t) +{ + /* Verify consistency before modifying */ + WARN_ON_ONCE(tk-offs_boot.tv64

Re: [PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-23 Thread John Stultz
On 07/19/2012 02:33 AM, Ingo Molnar wrote: * John Stultz wrote: +static void tk_set_sleep_time(struct timekeeper *tk, struct timespec t) +{ + /* Verify consistency before modifying */ + WARN_ON_ONCE(tk->offs_boot.tv64 != +

Re: [PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-23 Thread John Stultz
On 07/19/2012 02:33 AM, Ingo Molnar wrote: * John Stultz john.stu...@linaro.org wrote: +static void tk_set_sleep_time(struct timekeeper *tk, struct timespec t) +{ + /* Verify consistency before modifying */ + WARN_ON_ONCE(tk-offs_boot.tv64 != +

Re: [PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-19 Thread Prarit Bhargava
On 07/18/2012 09:19 PM, John Stultz wrote: > For performance reasons, we maintain ktime_t based duplicates of > wall_to_monotonic (offs_real) and total_sleep_time (offs_boot). > > Since large problems could occur (such as the resume regression > on 3.5-rc7, or the leapsecond hrtimer issue) if

Re: [PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-19 Thread Ingo Molnar
* John Stultz wrote: > For performance reasons, we maintain ktime_t based duplicates of > wall_to_monotonic (offs_real) and total_sleep_time (offs_boot). > > Since large problems could occur (such as the resume regression > on 3.5-rc7, or the leapsecond hrtimer issue) if these value pairs >

Re: [PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-19 Thread Ingo Molnar
* John Stultz john.stu...@linaro.org wrote: For performance reasons, we maintain ktime_t based duplicates of wall_to_monotonic (offs_real) and total_sleep_time (offs_boot). Since large problems could occur (such as the resume regression on 3.5-rc7, or the leapsecond hrtimer issue) if these

Re: [PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-19 Thread Prarit Bhargava
On 07/18/2012 09:19 PM, John Stultz wrote: For performance reasons, we maintain ktime_t based duplicates of wall_to_monotonic (offs_real) and total_sleep_time (offs_boot). Since large problems could occur (such as the resume regression on 3.5-rc7, or the leapsecond hrtimer issue) if these

[PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-18 Thread John Stultz
For performance reasons, we maintain ktime_t based duplicates of wall_to_monotonic (offs_real) and total_sleep_time (offs_boot). Since large problems could occur (such as the resume regression on 3.5-rc7, or the leapsecond hrtimer issue) if these value pairs were to be inconsistently updated,

[PATCH 2/2] time: Cleanup offs_real/wall_to_mono and offs_boot/total_sleep_time updates

2012-07-18 Thread John Stultz
For performance reasons, we maintain ktime_t based duplicates of wall_to_monotonic (offs_real) and total_sleep_time (offs_boot). Since large problems could occur (such as the resume regression on 3.5-rc7, or the leapsecond hrtimer issue) if these value pairs were to be inconsistently updated,