Re: Re: [PATCH 2/2] tracing/probes: Fix basic print type functions

2013-11-22 Thread Masami Hiramatsu
(2013/11/22 15:05), Namhyung Kim wrote: > Hi Oleg, > > On Wed, 20 Nov 2013 16:22:45 +0100, Oleg Nesterov wrote: >> On 11/18, Namhyung Kim wrote: >>> >>> -DEFINE_BASIC_PRINT_TYPE_FUNC(u8, "%x", unsigned int) >>> -DEFINE_BASIC_PRINT_TYPE_FUNC(u16, "%x", unsigned int) >>>

Re: Re: [PATCH 2/2] tracing/probes: Fix basic print type functions

2013-11-22 Thread Masami Hiramatsu
(2013/11/22 15:05), Namhyung Kim wrote: Hi Oleg, On Wed, 20 Nov 2013 16:22:45 +0100, Oleg Nesterov wrote: On 11/18, Namhyung Kim wrote: -DEFINE_BASIC_PRINT_TYPE_FUNC(u8, %x, unsigned int) -DEFINE_BASIC_PRINT_TYPE_FUNC(u16, %x, unsigned int) -DEFINE_BASIC_PRINT_TYPE_FUNC(u32, %lx, unsigned

Re: [PATCH 2/2] tracing/probes: Fix basic print type functions

2013-11-21 Thread Namhyung Kim
Hi Oleg, On Wed, 20 Nov 2013 16:22:45 +0100, Oleg Nesterov wrote: > On 11/18, Namhyung Kim wrote: >> >> -DEFINE_BASIC_PRINT_TYPE_FUNC(u8, "%x", unsigned int) >> -DEFINE_BASIC_PRINT_TYPE_FUNC(u16, "%x", unsigned int) >> -DEFINE_BASIC_PRINT_TYPE_FUNC(u32, "%lx", unsigned long) >>

Re: [PATCH 2/2] tracing/probes: Fix basic print type functions

2013-11-21 Thread Namhyung Kim
Hi Oleg, On Wed, 20 Nov 2013 16:22:45 +0100, Oleg Nesterov wrote: On 11/18, Namhyung Kim wrote: -DEFINE_BASIC_PRINT_TYPE_FUNC(u8, %x, unsigned int) -DEFINE_BASIC_PRINT_TYPE_FUNC(u16, %x, unsigned int) -DEFINE_BASIC_PRINT_TYPE_FUNC(u32, %lx, unsigned long) +DEFINE_BASIC_PRINT_TYPE_FUNC(u8 ,

Re: [PATCH 2/2] tracing/probes: Fix basic print type functions

2013-11-20 Thread Oleg Nesterov
On 11/18, Namhyung Kim wrote: > > -DEFINE_BASIC_PRINT_TYPE_FUNC(u8, "%x", unsigned int) > -DEFINE_BASIC_PRINT_TYPE_FUNC(u16, "%x", unsigned int) > -DEFINE_BASIC_PRINT_TYPE_FUNC(u32, "%lx", unsigned long) > +DEFINE_BASIC_PRINT_TYPE_FUNC(u8 , "%x", unsigned char) > +DEFINE_BASIC_PRINT_TYPE_FUNC(u16,

Re: [PATCH 2/2] tracing/probes: Fix basic print type functions

2013-11-20 Thread Oleg Nesterov
On 11/18, Namhyung Kim wrote: -DEFINE_BASIC_PRINT_TYPE_FUNC(u8, %x, unsigned int) -DEFINE_BASIC_PRINT_TYPE_FUNC(u16, %x, unsigned int) -DEFINE_BASIC_PRINT_TYPE_FUNC(u32, %lx, unsigned long) +DEFINE_BASIC_PRINT_TYPE_FUNC(u8 , %x, unsigned char) +DEFINE_BASIC_PRINT_TYPE_FUNC(u16, %x, unsigned

[PATCH 2/2] tracing/probes: Fix basic print type functions

2013-11-17 Thread Namhyung Kim
From: Namhyung Kim The print format of s32 type was "ld" and it's casted to "long". So it turned out to print 4294967295 for "-1" on 64-bit systems. Not sure whether it worked well on 32-bit systems. Anyway, it'd be better if we have exact format and type cast for each types on both of 32-

[PATCH 2/2] tracing/probes: Fix basic print type functions

2013-11-17 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com The print format of s32 type was ld and it's casted to long. So it turned out to print 4294967295 for -1 on 64-bit systems. Not sure whether it worked well on 32-bit systems. Anyway, it'd be better if we have exact format and type cast for each types on