Re: [PATCH 2/2] workqueue: remove the argument @wakeup from worker_set_flags()

2014-07-18 Thread Tejun Heo
On Fri, Jul 18, 2014 at 06:38:26PM -0400, Tejun Heo wrote: > On Wed, Jul 16, 2014 at 06:09:59PM +0800, Lai Jiangshan wrote: > > worker_set_flags() doesn't necessarily wake next worker and the @wakeup > > can be removed, the caller can use the following conbination instead > > when needed: > > > >

Re: [PATCH 2/2] workqueue: remove the argument @wakeup from worker_set_flags()

2014-07-18 Thread Tejun Heo
On Wed, Jul 16, 2014 at 06:09:59PM +0800, Lai Jiangshan wrote: > worker_set_flags() doesn't necessarily wake next worker and the @wakeup > can be removed, the caller can use the following conbination instead > when needed: > > worker_set_flags(); > if (need_more_worker(pool)) >

Re: [PATCH 2/2] workqueue: remove the argument @wakeup from worker_set_flags()

2014-07-18 Thread Tejun Heo
On Wed, Jul 16, 2014 at 06:09:59PM +0800, Lai Jiangshan wrote: worker_set_flags() doesn't necessarily wake next worker and the @wakeup can be removed, the caller can use the following conbination instead when needed: worker_set_flags(); if (need_more_worker(pool))

Re: [PATCH 2/2] workqueue: remove the argument @wakeup from worker_set_flags()

2014-07-18 Thread Tejun Heo
On Fri, Jul 18, 2014 at 06:38:26PM -0400, Tejun Heo wrote: On Wed, Jul 16, 2014 at 06:09:59PM +0800, Lai Jiangshan wrote: worker_set_flags() doesn't necessarily wake next worker and the @wakeup can be removed, the caller can use the following conbination instead when needed:

[PATCH 2/2] workqueue: remove the argument @wakeup from worker_set_flags()

2014-07-16 Thread Lai Jiangshan
worker_set_flags() doesn't necessarily wake next worker and the @wakeup can be removed, the caller can use the following conbination instead when needed: worker_set_flags(); if (need_more_worker(pool)) wake_up_worker(pool); Signed-off-by: Lai Jiangshan

[PATCH 2/2] workqueue: remove the argument @wakeup from worker_set_flags()

2014-07-16 Thread Lai Jiangshan
worker_set_flags() doesn't necessarily wake next worker and the @wakeup can be removed, the caller can use the following conbination instead when needed: worker_set_flags(); if (need_more_worker(pool)) wake_up_worker(pool); Signed-off-by: Lai Jiangshan