Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Dave Hansen
Feel free to add to the pair: Acked-by: Dave Hansen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 11:14 PM, Paul E. McKenney wrote: > On Sat, Feb 07, 2015 at 04:52:05PM -0500, Steven Rostedt wrote: >> On Sat, 7 Feb 2015 12:09:48 -0800 >> "Paul E. McKenney" wrote: >> >> >The tag sequence has the meaning of: >> > git cherry-pick a1f84a3 >> > git cherry-pick

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Paul E. McKenney
On Sat, Feb 07, 2015 at 04:52:05PM -0500, Steven Rostedt wrote: > On Sat, 7 Feb 2015 12:09:48 -0800 > "Paul E. McKenney" wrote: > > >The tag sequence has the meaning of: > > git cherry-pick a1f84a3 > > git cherry-pick 1b9508f > > git cherry-pick fd21073 > > git

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Steven Rostedt
On Sat, 7 Feb 2015 12:09:48 -0800 "Paul E. McKenney" wrote: >The tag sequence has the meaning of: > git cherry-pick a1f84a3 > git cherry-pick 1b9508f > git cherry-pick fd21073 > git cherry-pick > > Does that do what you need? Note, for this case it really doesn't

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 9:09 PM, Paul E. McKenney wrote: > On Sat, Feb 07, 2015 at 10:20:02AM -0500, Steven Rostedt wrote: >> On Sat, 7 Feb 2015 09:01:34 +0100 >> Sedat Dilek wrote: >> >> >> > - Tested-by's >> > - Reference of 2/2 to 1/2 >> >> The two are together in the series and fix two

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Paul E. McKenney
On Sat, Feb 07, 2015 at 10:20:02AM -0500, Steven Rostedt wrote: > On Sat, 7 Feb 2015 09:01:34 +0100 > Sedat Dilek wrote: > > > > - Tested-by's > > - Reference of 2/2 to 1/2 > > The two are together in the series and fix two different bugs. They do > not need to reference each other. > > > -

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 4:20 PM, Steven Rostedt wrote: > On Sat, 7 Feb 2015 09:01:34 +0100 > Sedat Dilek wrote: > > >> - Tested-by's >> - Reference of 2/2 to 1/2 > > The two are together in the series and fix two different bugs. They do > not need to reference each other. > >> - CC: stable

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Steven Rostedt
On Sat, 7 Feb 2015 09:13:23 +0100 Sedat Dilek wrote: I fell over this w/o having any experiences in using the tracing > system within the Linux-kernel. > Can you give a brief introduction? > Or can describe how you made your tests? > Did you use trace-cmd in your tests? > > Some of the tests

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Steven Rostedt
On Sat, 7 Feb 2015 09:01:34 +0100 Sedat Dilek wrote: > - Tested-by's > - Reference of 2/2 to 1/2 The two are together in the series and fix two different bugs. They do not need to reference each other. > - CC: stable v3.17+/v3.18+ ? (1/2 has a hint for backporting in case > of 3.17+ which is

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 5:02 AM, Steven Rostedt wrote: > On Fri, 6 Feb 2015 15:27:54 -0800 > "Paul E. McKenney" wrote: > >> > Reported-by: Sedat Dilek >> > Suggested-by: Paul E. McKenney >> > Signed-off-by: Steven Rostedt >> >> Acked-by: Paul E. McKenney > > Both patches survived all my

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 5:02 AM, Steven Rostedt wrote: > On Fri, 6 Feb 2015 15:27:54 -0800 > "Paul E. McKenney" wrote: > >> > Reported-by: Sedat Dilek >> > Suggested-by: Paul E. McKenney >> > Signed-off-by: Steven Rostedt >> >> Acked-by: Paul E. McKenney > > Both patches survived all my

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 5:02 AM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 6 Feb 2015 15:27:54 -0800 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Reported-by: Sedat Dilek sedat.di...@gmail.com Suggested-by: Paul E. McKenney paul...@linux.vnet.ibm.com Signed-off-by: Steven

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 5:02 AM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 6 Feb 2015 15:27:54 -0800 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Reported-by: Sedat Dilek sedat.di...@gmail.com Suggested-by: Paul E. McKenney paul...@linux.vnet.ibm.com Signed-off-by: Steven

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Steven Rostedt
On Sat, 7 Feb 2015 09:01:34 +0100 Sedat Dilek sedat.di...@gmail.com wrote: - Tested-by's - Reference of 2/2 to 1/2 The two are together in the series and fix two different bugs. They do not need to reference each other. - CC: stable v3.17+/v3.18+ ? (1/2 has a hint for backporting in case

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Steven Rostedt
On Sat, 7 Feb 2015 09:13:23 +0100 Sedat Dilek sedat.di...@gmail.com wrote: I fell over this w/o having any experiences in using the tracing system within the Linux-kernel. Can you give a brief introduction? Or can describe how you made your tests? Did you use trace-cmd in your tests? Some

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 4:20 PM, Steven Rostedt rost...@goodmis.org wrote: On Sat, 7 Feb 2015 09:01:34 +0100 Sedat Dilek sedat.di...@gmail.com wrote: - Tested-by's - Reference of 2/2 to 1/2 The two are together in the series and fix two different bugs. They do not need to reference each

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Paul E. McKenney
On Sat, Feb 07, 2015 at 10:20:02AM -0500, Steven Rostedt wrote: On Sat, 7 Feb 2015 09:01:34 +0100 Sedat Dilek sedat.di...@gmail.com wrote: - Tested-by's - Reference of 2/2 to 1/2 The two are together in the series and fix two different bugs. They do not need to reference each other.

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 9:09 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Sat, Feb 07, 2015 at 10:20:02AM -0500, Steven Rostedt wrote: On Sat, 7 Feb 2015 09:01:34 +0100 Sedat Dilek sedat.di...@gmail.com wrote: - Tested-by's - Reference of 2/2 to 1/2 The two are together in

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Sedat Dilek
On Sat, Feb 7, 2015 at 11:14 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Sat, Feb 07, 2015 at 04:52:05PM -0500, Steven Rostedt wrote: On Sat, 7 Feb 2015 12:09:48 -0800 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: The tag sequence has the meaning of: git

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Paul E. McKenney
On Sat, Feb 07, 2015 at 04:52:05PM -0500, Steven Rostedt wrote: On Sat, 7 Feb 2015 12:09:48 -0800 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: The tag sequence has the meaning of: git cherry-pick a1f84a3 git cherry-pick 1b9508f git cherry-pick fd21073 git

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Dave Hansen
Feel free to add to the pair: Acked-by: Dave Hansen d...@sr71.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-07 Thread Steven Rostedt
On Sat, 7 Feb 2015 12:09:48 -0800 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: The tag sequence has the meaning of: git cherry-pick a1f84a3 git cherry-pick 1b9508f git cherry-pick fd21073 git cherry-pick this commit Does that do what you need? Note, for this

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 15:27:54 -0800 "Paul E. McKenney" wrote: > > Reported-by: Sedat Dilek > > Suggested-by: Paul E. McKenney > > Signed-off-by: Steven Rostedt > > Acked-by: Paul E. McKenney Both patches survived all my tests, now I just need an ack by from Dave and/or Peter, and I'll push

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Paul E. McKenney
On Fri, Feb 06, 2015 at 03:06:55PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > When taking a CPU down for suspend and resume, a tracepoint may be called > when the CPU has been designated offline. As tracepoints require RCU for > protection, they must not be called if the

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Sedat Dilek
On Fri, Feb 6, 2015 at 10:42 PM, Steven Rostedt wrote: > On Fri, 6 Feb 2015 22:39:52 +0100 > Sedat Dilek wrote: > >> Man man man you write and test your stuff still on ancient x85 arch. >> What's coming next... revive/reinclude i386 code? > > Real mode for Real men! Yeah Baby! > I hope you

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 22:39:52 +0100 Sedat Dilek wrote: > Man man man you write and test your stuff still on ancient x85 arch. > What's coming next... revive/reinclude i386 code? Real mode for Real men! Yeah Baby! -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Sedat Dilek
On Fri, Feb 6, 2015 at 10:34 PM, Steven Rostedt wrote: > On Fri, 6 Feb 2015 21:11:57 +0100 > Sedat Dilek wrote: > >> On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt wrote: >> > From: "Steven Rostedt (Red Hat)" >> > >> >> Subject: x86/tbl/trace: ---> .../tlb/... >> > > But you missed that the

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 21:11:57 +0100 Sedat Dilek wrote: > On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > Subject: x86/tbl/trace: ---> .../tlb/... > But you missed that the cover letter was for x85 ;-) (I did too, it was pointed out to me on

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 21:23:13 +0100 Sedat Dilek wrote: > On Fri, Feb 6, 2015 at 9:21 PM, Steven Rostedt wrote: > > On Fri, 6 Feb 2015 21:11:57 +0100 > > Sedat Dilek wrote: > > > >> On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt wrote: > >> > From: "Steven Rostedt (Red Hat)" > >> > > >> > >>

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Sedat Dilek
On Fri, Feb 6, 2015 at 9:21 PM, Steven Rostedt wrote: > On Fri, 6 Feb 2015 21:11:57 +0100 > Sedat Dilek wrote: > >> On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt wrote: >> > From: "Steven Rostedt (Red Hat)" >> > >> >> Subject: x86/tbl/trace: ---> .../tlb/... >> > > But I wanted "To Be Loved".

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 21:11:57 +0100 Sedat Dilek wrote: > On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > Subject: x86/tbl/trace: ---> .../tlb/... > But I wanted "To Be Loved". -- Steve -- To unsubscribe from this list: send the line

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Sedat Dilek
On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > Subject: x86/tbl/trace: ---> .../tlb/... - Sedat - > When taking a CPU down for suspend and resume, a tracepoint may be called > when the CPU has been designated offline. As tracepoints require RCU for

[PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" When taking a CPU down for suspend and resume, a tracepoint may be called when the CPU has been designated offline. As tracepoints require RCU for protection, they must not be called if the current CPU is offline. Unfortunately, trace_tlb_flush() is called in

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 21:11:57 +0100 Sedat Dilek sedat.di...@gmail.com wrote: On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Subject: x86/tbl/trace: --- .../tlb/... But I wanted To Be Loved. -- Steve -- To

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Sedat Dilek
On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Subject: x86/tbl/trace: --- .../tlb/... - Sedat - When taking a CPU down for suspend and resume, a tracepoint may be called when the CPU has been designated offline.

[PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
From: Steven Rostedt (Red Hat) rost...@goodmis.org When taking a CPU down for suspend and resume, a tracepoint may be called when the CPU has been designated offline. As tracepoints require RCU for protection, they must not be called if the current CPU is offline. Unfortunately,

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 21:23:13 +0100 Sedat Dilek sedat.di...@gmail.com wrote: On Fri, Feb 6, 2015 at 9:21 PM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 6 Feb 2015 21:11:57 +0100 Sedat Dilek sedat.di...@gmail.com wrote: On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Sedat Dilek
On Fri, Feb 6, 2015 at 9:21 PM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 6 Feb 2015 21:11:57 +0100 Sedat Dilek sedat.di...@gmail.com wrote: On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Subject:

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Sedat Dilek
On Fri, Feb 6, 2015 at 10:34 PM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 6 Feb 2015 21:11:57 +0100 Sedat Dilek sedat.di...@gmail.com wrote: On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Subject:

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Sedat Dilek
On Fri, Feb 6, 2015 at 10:42 PM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 6 Feb 2015 22:39:52 +0100 Sedat Dilek sedat.di...@gmail.com wrote: Man man man you write and test your stuff still on ancient x85 arch. What's coming next... revive/reinclude i386 code? Real mode for Real

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Paul E. McKenney
On Fri, Feb 06, 2015 at 03:06:55PM -0500, Steven Rostedt wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org When taking a CPU down for suspend and resume, a tracepoint may be called when the CPU has been designated offline. As tracepoints require RCU for protection, they must not be

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 21:11:57 +0100 Sedat Dilek sedat.di...@gmail.com wrote: On Fri, Feb 6, 2015 at 9:06 PM, Steven Rostedt rost...@goodmis.org wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Subject: x86/tbl/trace: --- .../tlb/... But you missed that the cover letter was for

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 22:39:52 +0100 Sedat Dilek sedat.di...@gmail.com wrote: Man man man you write and test your stuff still on ancient x85 arch. What's coming next... revive/reinclude i386 code? Real mode for Real men! Yeah Baby! -- Steve -- To unsubscribe from this list: send the line

Re: [PATCH 2/2] x86/tbl/trace: Do not trace on CPU that is offline

2015-02-06 Thread Steven Rostedt
On Fri, 6 Feb 2015 15:27:54 -0800 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Reported-by: Sedat Dilek sedat.di...@gmail.com Suggested-by: Paul E. McKenney paul...@linux.vnet.ibm.com Signed-off-by: Steven Rostedt rost...@goodmis.org Acked-by: Paul E. McKenney