Re: [PATCH 2/2 v2] rseq/selftests: test MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU

2020-08-07 Thread Mathieu Desnoyers
- On Aug 7, 2020, at 2:47 PM, Peter Oskolkov p...@posk.io wrote: > On Fri, Aug 7, 2020 at 11:25 AM Mathieu Desnoyers > wrote: >> >> - On Aug 7, 2020, at 1:55 PM, Peter Oskolkov p...@posk.io wrote: >> >> > On Thu, Aug 6, 2020 at 5:27 PM Boqun Feng wrote: >> [...] >> >> What if the manager

Re: [PATCH 2/2 v2] rseq/selftests: test MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU

2020-08-07 Thread Peter Oskolkov
On Fri, Aug 7, 2020 at 11:25 AM Mathieu Desnoyers wrote: > > - On Aug 7, 2020, at 1:55 PM, Peter Oskolkov p...@posk.io wrote: > > > On Thu, Aug 6, 2020 at 5:27 PM Boqun Feng wrote: > [...] > >> What if the manager thread update ->percpu_list_ptr and call > >> membarrier() here? I.e. > >> > >>

Re: [PATCH 2/2 v2] rseq/selftests: test MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU

2020-08-07 Thread Mathieu Desnoyers
- On Aug 7, 2020, at 1:55 PM, Peter Oskolkov p...@posk.io wrote: > On Thu, Aug 6, 2020 at 5:27 PM Boqun Feng wrote: [...] >> What if the manager thread update ->percpu_list_ptr and call >> membarrier() here? I.e. >> >> CPU0CPU1 >> li

Re: [PATCH 2/2 v2] rseq/selftests: test MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU

2020-08-07 Thread Peter Oskolkov
On Thu, Aug 6, 2020 at 5:27 PM Boqun Feng wrote: > > On Thu, Aug 06, 2020 at 10:05:44AM -0700, Peter Oskolkov wrote: > > Based on Google-internal RSEQ work done by > > Paul Turner and Andrew Hunter. > > > > This patch adds a selftest for MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU. > > The test qui

Re: [PATCH 2/2 v2] rseq/selftests: test MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU

2020-08-07 Thread Mathieu Desnoyers
- On Aug 6, 2020, at 8:27 PM, Boqun Feng boqun.f...@gmail.com wrote: > On Thu, Aug 06, 2020 at 10:05:44AM -0700, Peter Oskolkov wrote: >> Based on Google-internal RSEQ work done by >> Paul Turner and Andrew Hunter. >> >> This patch adds a selftest for MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CP

Re: [PATCH 2/2 v2] rseq/selftests: test MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU

2020-08-06 Thread Boqun Feng
On Thu, Aug 06, 2020 at 10:05:44AM -0700, Peter Oskolkov wrote: > Based on Google-internal RSEQ work done by > Paul Turner and Andrew Hunter. > > This patch adds a selftest for MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU. > The test quite often fails without the previous patch in this patchset, > b

[PATCH 2/2 v2] rseq/selftests: test MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU

2020-08-06 Thread Peter Oskolkov
Based on Google-internal RSEQ work done by Paul Turner and Andrew Hunter. This patch adds a selftest for MEMBARRIER_CMD_PRIVATE_RESTART_RSEQ_ON_CPU. The test quite often fails without the previous patch in this patchset, but consistently passes with it. Signed-off-by: Peter Oskolkov --- .../sel