Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-19 Thread Ricardo Ribalda Delgado
Hello Joe Thanks again for your comments. Since some the of the issues that you point are also in the other parts of the file I will fix them in a follow up patch for the whole driver. On Thu, May 15, 2014 at 8:40 PM, Joe Perches wrote: > On Thu, 2014-05-15 at 14:28 +0200, Ricardo Ribalda

Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-19 Thread Ricardo Ribalda Delgado
Hello Joe Thanks again for your comments. Since some the of the issues that you point are also in the other parts of the file I will fix them in a follow up patch for the whole driver. On Thu, May 15, 2014 at 8:40 PM, Joe Perches j...@perches.com wrote: On Thu, 2014-05-15 at 14:28 +0200,

Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-15 Thread Alan Stern
On Thu, 15 May 2014, Felipe Balbi wrote: > On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote: > > This patch adds support for the PLX USB3380 and USB3382. > > > > This driver is based on the driver from the manufacturer. > > > > Since USB338X is register compatible with

Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-15 Thread Joe Perches
On Thu, 2014-05-15 at 14:28 +0200, Ricardo Ribalda Delgado wrote: > This patch adds support for the PLX USB3380 and USB3382. A few more trivial notes, all can be addressed as follow-on patches or perhaps even ignored altogether. > diff --git a/drivers/usb/gadget/net2280.c

Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-15 Thread Ricardo Ribalda Delgado
On 15 May 2014 18:07, "Felipe Balbi" wrote: > > On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote: > > This patch adds support for the PLX USB3380 and USB3382. > > > > This driver is based on the driver from the manufacturer. > > > > Since USB338X is register compatible with

Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-15 Thread Felipe Balbi
On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote: > This patch adds support for the PLX USB3380 and USB3382. > > This driver is based on the driver from the manufacturer. > > Since USB338X is register compatible with NET2280, I thought that it > would be better to include

Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-15 Thread Felipe Balbi
On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote: This patch adds support for the PLX USB3380 and USB3382. This driver is based on the driver from the manufacturer. Since USB338X is register compatible with NET2280, I thought that it would be better to include this

Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-15 Thread Ricardo Ribalda Delgado
On 15 May 2014 18:07, Felipe Balbi ba...@ti.com wrote: On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote: This patch adds support for the PLX USB3380 and USB3382. This driver is based on the driver from the manufacturer. Since USB338X is register compatible with

Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-15 Thread Joe Perches
On Thu, 2014-05-15 at 14:28 +0200, Ricardo Ribalda Delgado wrote: This patch adds support for the PLX USB3380 and USB3382. A few more trivial notes, all can be addressed as follow-on patches or perhaps even ignored altogether. diff --git a/drivers/usb/gadget/net2280.c

Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

2014-05-15 Thread Alan Stern
On Thu, 15 May 2014, Felipe Balbi wrote: On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote: This patch adds support for the PLX USB3380 and USB3382. This driver is based on the driver from the manufacturer. Since USB338X is register compatible with NET2280, I