Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-25 Thread Mika Westerberg
On Fri, Jul 21, 2017 at 02:40:49PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > To prepare for a subsequent change and make the code somewhat easier > to follow, do the following in the ACPI device wakeup handling code: > > * Replace

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-25 Thread Mika Westerberg
On Fri, Jul 21, 2017 at 02:40:49PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > To prepare for a subsequent change and make the code somewhat easier > to follow, do the following in the ACPI device wakeup handling code: > > * Replace wakeup.flags.enabled under struct

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Rafael J. Wysocki
On Saturday, July 22, 2017 12:31:14 AM Andy Shevchenko wrote: > On Sat, Jul 22, 2017 at 12:16 AM, Rafael J. Wysocki > wrote: > > On Saturday, July 22, 2017 12:19:51 AM Andy Shevchenko wrote: > >> On Fri, Jul 21, 2017 at 11:49 PM, Rafael J. Wysocki > >>

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Rafael J. Wysocki
On Saturday, July 22, 2017 12:31:14 AM Andy Shevchenko wrote: > On Sat, Jul 22, 2017 at 12:16 AM, Rafael J. Wysocki > wrote: > > On Saturday, July 22, 2017 12:19:51 AM Andy Shevchenko wrote: > >> On Fri, Jul 21, 2017 at 11:49 PM, Rafael J. Wysocki > >> wrote: > >> > On Friday, July 21, 2017

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Andy Shevchenko
On Sat, Jul 22, 2017 at 12:16 AM, Rafael J. Wysocki wrote: > On Saturday, July 22, 2017 12:19:51 AM Andy Shevchenko wrote: >> On Fri, Jul 21, 2017 at 11:49 PM, Rafael J. Wysocki >> wrote: >> > On Friday, July 21, 2017 06:27:39 PM Andy Shevchenko wrote:

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Andy Shevchenko
On Sat, Jul 22, 2017 at 12:16 AM, Rafael J. Wysocki wrote: > On Saturday, July 22, 2017 12:19:51 AM Andy Shevchenko wrote: >> On Fri, Jul 21, 2017 at 11:49 PM, Rafael J. Wysocki >> wrote: >> > On Friday, July 21, 2017 06:27:39 PM Andy Shevchenko wrote: >> >> I prefer more self-explaining

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Rafael J. Wysocki
On Saturday, July 22, 2017 12:19:51 AM Andy Shevchenko wrote: > On Fri, Jul 21, 2017 at 11:49 PM, Rafael J. Wysocki > wrote: > > On Friday, July 21, 2017 06:27:39 PM Andy Shevchenko wrote: > >> On Fri, Jul 21, 2017 at 3:40 PM, Rafael J. Wysocki > >>

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Rafael J. Wysocki
On Saturday, July 22, 2017 12:19:51 AM Andy Shevchenko wrote: > On Fri, Jul 21, 2017 at 11:49 PM, Rafael J. Wysocki > wrote: > > On Friday, July 21, 2017 06:27:39 PM Andy Shevchenko wrote: > >> On Fri, Jul 21, 2017 at 3:40 PM, Rafael J. Wysocki > >> wrote: > > >> I prefer more self-explaining

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Andy Shevchenko
On Fri, Jul 21, 2017 at 11:49 PM, Rafael J. Wysocki wrote: > On Friday, July 21, 2017 06:27:39 PM Andy Shevchenko wrote: >> On Fri, Jul 21, 2017 at 3:40 PM, Rafael J. Wysocki >> wrote: >> I prefer more self-explaining labels, though it's minor here > >

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Andy Shevchenko
On Fri, Jul 21, 2017 at 11:49 PM, Rafael J. Wysocki wrote: > On Friday, July 21, 2017 06:27:39 PM Andy Shevchenko wrote: >> On Fri, Jul 21, 2017 at 3:40 PM, Rafael J. Wysocki >> wrote: >> I prefer more self-explaining labels, though it's minor here > > Well, I prefer shorter ones. > >> To be

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Rafael J. Wysocki
On Friday, July 21, 2017 06:27:39 PM Andy Shevchenko wrote: > On Fri, Jul 21, 2017 at 3:40 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > To prepare for a subsequent change and make the code somewhat easier > > to follow, do the

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Rafael J. Wysocki
On Friday, July 21, 2017 06:27:39 PM Andy Shevchenko wrote: > On Fri, Jul 21, 2017 at 3:40 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > To prepare for a subsequent change and make the code somewhat easier > > to follow, do the following in the ACPI device wakeup handling

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Andy Shevchenko
On Fri, Jul 21, 2017 at 3:40 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > To prepare for a subsequent change and make the code somewhat easier > to follow, do the following in the ACPI device wakeup handling code: > > * Replace

Re: [PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Andy Shevchenko
On Fri, Jul 21, 2017 at 3:40 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > To prepare for a subsequent change and make the code somewhat easier > to follow, do the following in the ACPI device wakeup handling code: > > * Replace wakeup.flags.enabled under struct acpi_device with >

[PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Rafael J. Wysocki
From: Rafael J. Wysocki To prepare for a subsequent change and make the code somewhat easier to follow, do the following in the ACPI device wakeup handling code: * Replace wakeup.flags.enabled under struct acpi_device with wakeup.enable_count as that will be

[PATCH 2/3] ACPI / PM: Split acpi_device_wakeup()

2017-07-21 Thread Rafael J. Wysocki
From: Rafael J. Wysocki To prepare for a subsequent change and make the code somewhat easier to follow, do the following in the ACPI device wakeup handling code: * Replace wakeup.flags.enabled under struct acpi_device with wakeup.enable_count as that will be necessary going forward. For