> >
> > I don't understand the reason for adding dwapb_read and dwapb_write here.
> > The rest of the driver is using readl and writel. I'd rather not see
> > two different methods being used in the same driver for register access.
> > Maybe I'm missing something, but if we need to add
I don't understand the reason for adding dwapb_read and dwapb_write here.
The rest of the driver is using readl and writel. I'd rather not see
two different methods being used in the same driver for register access.
Maybe I'm missing something, but if we need to add dwapb_read/write,
On Thu, 2014-08-28 at 10:11 -0500, atull wrote:
> On Wed, 27 Aug 2014, Weike Chen wrote:
[]
> > +static inline u32 dwapb_read(struct dwapb_gpio *gpio, unsigned int offset)
> > +{
> > + struct bgpio_chip *bgc = >ports[0].bgc;
> > + void __iomem *reg_base = gpio->regs;
> > +
> > + return
On Thu, 2014-08-28 at 10:11 -0500, atull wrote:
On Wed, 27 Aug 2014, Weike Chen wrote:
[]
+static inline u32 dwapb_read(struct dwapb_gpio *gpio, unsigned int offset)
+{
+ struct bgpio_chip *bgc = gpio-ports[0].bgc;
+ void __iomem *reg_base = gpio-regs;
+
+ return
On Wed, 27 Aug 2014, Weike Chen wrote:
> This patch enables 'debounce' for the designware GPIO, and
> it is based on Josef Ahmad's previous work.
>
> Reviewed-by: Hock Leong Kweh
> Reviewed-by: Shevchenko, Andriy
> Signed-off-by: Weike Chen
> ---
> drivers/gpio/gpio-dwapb.c | 42
On Wed, 27 Aug 2014, Weike Chen wrote:
This patch enables 'debounce' for the designware GPIO, and
it is based on Josef Ahmad's previous work.
Reviewed-by: Hock Leong Kweh hock.leong.k...@intel.com
Reviewed-by: Shevchenko, Andriy andriy.shevche...@intel.com
Signed-off-by: Weike Chen
This patch enables 'debounce' for the designware GPIO, and
it is based on Josef Ahmad's previous work.
Reviewed-by: Hock Leong Kweh
Reviewed-by: Shevchenko, Andriy
Signed-off-by: Weike Chen
---
drivers/gpio/gpio-dwapb.c | 42 ++
1 file changed, 42
This patch enables 'debounce' for the designware GPIO, and
it is based on Josef Ahmad's previous work.
Reviewed-by: Hock Leong Kweh hock.leong.k...@intel.com
Reviewed-by: Shevchenko, Andriy andriy.shevche...@intel.com
Signed-off-by: Weike Chen alvin.c...@intel.com
---
drivers/gpio/gpio-dwapb.c |
8 matches
Mail list logo