RE: [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

2014-08-31 Thread Chen, Alvin
> > > > I don't understand the reason for adding dwapb_read and dwapb_write here. > > The rest of the driver is using readl and writel. I'd rather not see > > two different methods being used in the same driver for register access. > > Maybe I'm missing something, but if we need to add

RE: [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

2014-08-31 Thread Chen, Alvin
I don't understand the reason for adding dwapb_read and dwapb_write here. The rest of the driver is using readl and writel. I'd rather not see two different methods being used in the same driver for register access. Maybe I'm missing something, but if we need to add dwapb_read/write,

Re: [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

2014-08-29 Thread Shevchenko, Andriy
On Thu, 2014-08-28 at 10:11 -0500, atull wrote: > On Wed, 27 Aug 2014, Weike Chen wrote: [] > > +static inline u32 dwapb_read(struct dwapb_gpio *gpio, unsigned int offset) > > +{ > > + struct bgpio_chip *bgc = >ports[0].bgc; > > + void __iomem *reg_base = gpio->regs; > > + > > + return

Re: [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

2014-08-29 Thread Shevchenko, Andriy
On Thu, 2014-08-28 at 10:11 -0500, atull wrote: On Wed, 27 Aug 2014, Weike Chen wrote: [] +static inline u32 dwapb_read(struct dwapb_gpio *gpio, unsigned int offset) +{ + struct bgpio_chip *bgc = gpio-ports[0].bgc; + void __iomem *reg_base = gpio-regs; + + return

Re: [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

2014-08-28 Thread atull
On Wed, 27 Aug 2014, Weike Chen wrote: > This patch enables 'debounce' for the designware GPIO, and > it is based on Josef Ahmad's previous work. > > Reviewed-by: Hock Leong Kweh > Reviewed-by: Shevchenko, Andriy > Signed-off-by: Weike Chen > --- > drivers/gpio/gpio-dwapb.c | 42

Re: [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

2014-08-28 Thread atull
On Wed, 27 Aug 2014, Weike Chen wrote: This patch enables 'debounce' for the designware GPIO, and it is based on Josef Ahmad's previous work. Reviewed-by: Hock Leong Kweh hock.leong.k...@intel.com Reviewed-by: Shevchenko, Andriy andriy.shevche...@intel.com Signed-off-by: Weike Chen

[PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

2014-08-27 Thread Weike Chen
This patch enables 'debounce' for the designware GPIO, and it is based on Josef Ahmad's previous work. Reviewed-by: Hock Leong Kweh Reviewed-by: Shevchenko, Andriy Signed-off-by: Weike Chen --- drivers/gpio/gpio-dwapb.c | 42 ++ 1 file changed, 42

[PATCH 2/3] GPIO: gpio-dwapb: Support Debounce

2014-08-27 Thread Weike Chen
This patch enables 'debounce' for the designware GPIO, and it is based on Josef Ahmad's previous work. Reviewed-by: Hock Leong Kweh hock.leong.k...@intel.com Reviewed-by: Shevchenko, Andriy andriy.shevche...@intel.com Signed-off-by: Weike Chen alvin.c...@intel.com --- drivers/gpio/gpio-dwapb.c |