RE: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-18 Thread Jiri Kosina
On Mon, 11 Feb 2013, Pandruvada, Srinivas wrote: > This was added to load sensor hub driver on USB plug in without explicit > modprobe. > But with last few changes to remove vendor and product id, we need to do > modprobe this driver. > So removal is OK. Srinivas, sorry, I have a hard time

RE: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-18 Thread Jiri Kosina
On Mon, 11 Feb 2013, Pandruvada, Srinivas wrote: This was added to load sensor hub driver on USB plug in without explicit modprobe. But with last few changes to remove vendor and product id, we need to do modprobe this driver. So removal is OK. Srinivas, sorry, I have a hard time

Re: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Benjamin Tissoires
On Mon, Feb 11, 2013 at 4:53 PM, Pandruvada, Srinivas wrote: > This was added to load sensor hub driver on USB plug in without explicit > modprobe. > But with last few changes to remove vendor and product id, we need to do > modprobe this driver. > So removal is OK. I just figure your comment

RE: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Pandruvada, Srinivas
...@linux.intel.com] Sent: Monday, February 11, 2013 2:31 AM To: linux-kernel@vger.kernel.org Cc: Jiri Kosina; Benjamin Tissoires; linux-in...@vger.kernel.org; Pandruvada, Srinivas; Mika Westerberg Subject: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table This table

Re: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Benjamin Tissoires
On Mon, Feb 11, 2013 at 11:31 AM, Mika Westerberg wrote: > This table is not used anywhere in the driver so kill it. > > Signed-off-by: Mika Westerberg > --- Yep, it's rather strange that the compiler didn't complained... Anyway, Reviewed-by: Benjamin Tissoires Cheers, Benjamin -- To

[PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Mika Westerberg
This table is not used anywhere in the driver so kill it. Signed-off-by: Mika Westerberg --- drivers/hid/hid-sensor-hub.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index c06e933..2643bce9 100644 ---

[PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Mika Westerberg
This table is not used anywhere in the driver so kill it. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/hid/hid-sensor-hub.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index c06e933..2643bce9

Re: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Benjamin Tissoires
On Mon, Feb 11, 2013 at 11:31 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: This table is not used anywhere in the driver so kill it. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- Yep, it's rather strange that the compiler didn't complained... Anyway,

RE: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Pandruvada, Srinivas
...@linux.intel.com] Sent: Monday, February 11, 2013 2:31 AM To: linux-kernel@vger.kernel.org Cc: Jiri Kosina; Benjamin Tissoires; linux-in...@vger.kernel.org; Pandruvada, Srinivas; Mika Westerberg Subject: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table This table

Re: [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Benjamin Tissoires
On Mon, Feb 11, 2013 at 4:53 PM, Pandruvada, Srinivas srinivas.pandruv...@intel.com wrote: This was added to load sensor hub driver on USB plug in without explicit modprobe. But with last few changes to remove vendor and product id, we need to do modprobe this driver. So removal is OK. I