Re: [PATCH 2/3] Keys: Use RCU to manage session keyring pointer

2005-04-12 Thread Paul E. McKenney
On Tue, Apr 12, 2005 at 10:11:50AM +0100, David Howells wrote: > Paul E. McKenney <[EMAIL PROTECTED]> wrote: > > > > spin_lock_irqsave(&tsk->sighand->siglock, flags); > > > - old = tsk->signal->session_keyring; > > > - tsk->signal->session_keyring = keyring; > > > + old = rcu_dereference(tsk->si

Re: [PATCH 2/3] Keys: Use RCU to manage session keyring pointer

2005-04-12 Thread David Howells
Paul E. McKenney <[EMAIL PROTECTED]> wrote: > > spin_lock_irqsave(&tsk->sighand->siglock, flags); > > - old = tsk->signal->session_keyring; > > - tsk->signal->session_keyring = keyring; > > + old = rcu_dereference(tsk->signal->session_keyring); > > I don't understand why rcu_dereference

Re: [PATCH 2/3] Keys: Use RCU to manage session keyring pointer

2005-04-11 Thread Paul E. McKenney
On Wed, Mar 23, 2005 at 08:55:46PM +, David Howells wrote: > > The attached patch uses RCU to manage the session keyring pointer in struct > signal_struct. This means that searching need not disable interrupts and get a > the sighand spinlock to access this pointer. Furthermore, by judicious u

Re: [PATCH 2/3] Keys: Use RCU to manage session keyring pointer

2005-03-23 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > David Howells <[EMAIL PROTECTED]> wrote: > > > > The attached patch uses RCU to manage the session keyring pointer in struct > > signal_struct. > > So are these patches dependent upon the > keys-use-rcu-to-manage-session-keyring-pointer work? This pat

Re: [PATCH 2/3] Keys: Use RCU to manage session keyring pointer

2005-03-23 Thread Andrew Morton
David Howells <[EMAIL PROTECTED]> wrote: > > The attached patch uses RCU to manage the session keyring pointer in struct > signal_struct. So are these patches dependent upon the keys-use-rcu-to-manage-session-keyring-pointer work? - To unsubscribe from this list: send the line "unsubscribe linux-

[PATCH 2/3] Keys: Use RCU to manage session keyring pointer

2005-03-23 Thread David Howells
The attached patch uses RCU to manage the session keyring pointer in struct signal_struct. This means that searching need not disable interrupts and get a the sighand spinlock to access this pointer. Furthermore, by judicious use of rcu_read_(un)lock(), this patch also avoids the need to take and

Re: [PATCH 2/3] Keys: Use RCU to manage session keyring pointer

2005-03-23 Thread David Howells
The attached patch uses RCU to manage the session keyring pointer in struct signal_struct. This means that searching need not disable interrupts and get a the sighand spinlock to access this pointer. Furthermore, by judicious use of rcu_read_(un)lock(), this patch also avoids the need to take and