Re: [PATCH 2/3] PCI: iproc: Stop using generic config read/write functions

2020-07-30 Thread Bjorn Helgaas
On Thu, Jul 30, 2020 at 10:58:03PM +, Mark Tomlinson wrote: > On Thu, 2020-07-30 at 11:09 -0500, Bjorn Helgaas wrote: > > I think it would be better to have a warning once per device, so if > > XYZ device has a problem and we look at the dmesg log, we would find a > > single message for device

Re: [PATCH 2/3] PCI: iproc: Stop using generic config read/write functions

2020-07-30 Thread Mark Tomlinson
On Thu, 2020-07-30 at 11:09 -0500, Bjorn Helgaas wrote: > I think it would be better to have a warning once per device, so if > XYZ device has a problem and we look at the dmesg log, we would find a > single message for device XYZ as a hint. Would that reduce the > nuisance level enough? We

Re: [PATCH 2/3] PCI: iproc: Stop using generic config read/write functions

2020-07-30 Thread Bjorn Helgaas
On Thu, Jul 30, 2020 at 09:36:14AM -0700, Ray Jui wrote: > On 7/30/2020 9:09 AM, Bjorn Helgaas wrote: > > On Thu, Jul 30, 2020 at 03:37:46PM +1200, Mark Tomlinson wrote: > >> The pci_generic_config_write32() function will give warning messages > >> whenever writing less than 4 bytes at a time. As

Re: [PATCH 2/3] PCI: iproc: Stop using generic config read/write functions

2020-07-30 Thread Ray Jui
On 7/30/2020 9:09 AM, Bjorn Helgaas wrote: > [+cc Lorenzo, Rob] > > On Thu, Jul 30, 2020 at 03:37:46PM +1200, Mark Tomlinson wrote: >> The pci_generic_config_write32() function will give warning messages >> whenever writing less than 4 bytes at a time. As there is nothing we can >> do about

Re: [PATCH 2/3] PCI: iproc: Stop using generic config read/write functions

2020-07-30 Thread Bjorn Helgaas
[+cc Lorenzo, Rob] On Thu, Jul 30, 2020 at 03:37:46PM +1200, Mark Tomlinson wrote: > The pci_generic_config_write32() function will give warning messages > whenever writing less than 4 bytes at a time. As there is nothing we can > do about this without changing the hardware, the message is just a

[PATCH 2/3] PCI: iproc: Stop using generic config read/write functions

2020-07-29 Thread Mark Tomlinson
The pci_generic_config_write32() function will give warning messages whenever writing less than 4 bytes at a time. As there is nothing we can do about this without changing the hardware, the message is just a nuisance. So instead of using the generic functions, use the functions that have already