Re: [PATCH 2/3] firmware: arm_scmi: Remove unneeded __packed attribute

2020-07-15 Thread Steven Price
On 13/07/2020 14:07, Cristian Marussi wrote: Hi Steven thanks for the review. On Mon, Jul 13, 2020 at 12:20:43PM +0100, Steven Price wrote: On 10/07/2020 14:39, Cristian Marussi wrote: Remove __packed attribute from struct scmi_event_header. Signed-off-by: Cristian Marussi A drive-by

Re: [PATCH 2/3] firmware: arm_scmi: Remove unneeded __packed attribute

2020-07-13 Thread Cristian Marussi
Hi Steven thanks for the review. On Mon, Jul 13, 2020 at 12:20:43PM +0100, Steven Price wrote: > On 10/07/2020 14:39, Cristian Marussi wrote: > >Remove __packed attribute from struct scmi_event_header. > > > >Signed-off-by: Cristian Marussi > > A drive-by review. But this doesn't look safe to

Re: [PATCH 2/3] firmware: arm_scmi: Remove unneeded __packed attribute

2020-07-13 Thread Steven Price
On 10/07/2020 14:39, Cristian Marussi wrote: Remove __packed attribute from struct scmi_event_header. Signed-off-by: Cristian Marussi A drive-by review. But this doesn't look safe to me. sizeof(struct scmi_event_header) is used in several places and this change will modify that from 13 to

Re: [PATCH 2/3] firmware: arm_scmi: Remove unneeded __packed attribute

2020-07-13 Thread Steven Price
On 10/07/2020 14:39, Cristian Marussi wrote: Remove __packed attribute from struct scmi_event_header. Signed-off-by: Cristian Marussi A drive-by review. But this doesn't look safe to me. sizeof(struct scmi_event_header) is used in several places and this change will modify that from 13 to

[PATCH 2/3] firmware: arm_scmi: Remove unneeded __packed attribute

2020-07-10 Thread Cristian Marussi
Remove __packed attribute from struct scmi_event_header. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/notify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/notify.c b/drivers/firmware/arm_scmi/notify.c index