dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <anson.hu...@nxp.com>
---
 drivers/iio/light/isl29018.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/light/isl29018.c b/drivers/iio/light/isl29018.c
index ac8ad0f..2689867 100644
--- a/drivers/iio/light/isl29018.c
+++ b/drivers/iio/light/isl29018.c
@@ -746,12 +746,9 @@ static int isl29018_probe(struct i2c_client *client,
        chip->suspended = false;
 
        chip->vcc_reg = devm_regulator_get(&client->dev, "vcc");
-       if (IS_ERR(chip->vcc_reg)) {
-               err = PTR_ERR(chip->vcc_reg);
-               if (err != -EPROBE_DEFER)
-                       dev_err(&client->dev, "failed to get VCC regulator!\n");
-               return err;
-       }
+       if (IS_ERR(chip->vcc_reg))
+               return dev_err_probe(&client->dev, PTR_ERR(chip->vcc_reg),
+                                    "failed to get VCC regulator!\n");
 
        err = regulator_enable(chip->vcc_reg);
        if (err) {
-- 
2.7.4

Reply via email to