Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-25 Thread Jason Wang
On 08/25/2015 11:04 AM, Jason Wang wrote: [...] > @@ -900,10 +899,11 @@ kvm_deassign_ioeventfd(struct kvm *kvm, struct > kvm_ioeventfd *args) > if (!p->wildcard && p->datamatch != args->datamatch) > continue; > > -

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-25 Thread Jason Wang
On 08/25/2015 11:04 AM, Jason Wang wrote: [...] @@ -900,10 +899,11 @@ kvm_deassign_ioeventfd(struct kvm *kvm, struct kvm_ioeventfd *args) if (!p-wildcard p-datamatch != args-datamatch) continue; -kvm_io_bus_unregister_dev(kvm, bus_idx,

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-24 Thread Jason Wang
On 08/24/2015 10:05 PM, Cornelia Huck wrote: > On Mon, 24 Aug 2015 11:29:29 +0800 > Jason Wang wrote: > >> On 08/21/2015 05:29 PM, Cornelia Huck wrote: >>> On Fri, 21 Aug 2015 16:03:52 +0800 >>> Jason Wang wrote: @@ -850,9 +845,15 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-24 Thread Cornelia Huck
On Mon, 24 Aug 2015 11:29:29 +0800 Jason Wang wrote: > On 08/21/2015 05:29 PM, Cornelia Huck wrote: > > On Fri, 21 Aug 2015 16:03:52 +0800 > > Jason Wang wrote: > >> @@ -850,9 +845,15 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct > >> kvm_ioeventfd *args) > > Unfortunately snipped by diff,

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-24 Thread Cornelia Huck
On Mon, 24 Aug 2015 11:29:29 +0800 Jason Wang jasow...@redhat.com wrote: On 08/21/2015 05:29 PM, Cornelia Huck wrote: On Fri, 21 Aug 2015 16:03:52 +0800 Jason Wang jasow...@redhat.com wrote: @@ -850,9 +845,15 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct kvm_ioeventfd *args)

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-24 Thread Jason Wang
On 08/24/2015 10:05 PM, Cornelia Huck wrote: On Mon, 24 Aug 2015 11:29:29 +0800 Jason Wang jasow...@redhat.com wrote: On 08/21/2015 05:29 PM, Cornelia Huck wrote: On Fri, 21 Aug 2015 16:03:52 +0800 Jason Wang jasow...@redhat.com wrote: @@ -850,9 +845,15 @@ kvm_assign_ioeventfd(struct kvm

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-23 Thread Jason Wang
On 08/21/2015 05:29 PM, Cornelia Huck wrote: > On Fri, 21 Aug 2015 16:03:52 +0800 > Jason Wang wrote: > > >> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c >> index 9ff4193..834a409 100644 >> --- a/virt/kvm/eventfd.c >> +++ b/virt/kvm/eventfd.c >> @@ -838,11 +838,6 @@

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-23 Thread Jason Wang
On 08/21/2015 05:29 PM, Cornelia Huck wrote: On Fri, 21 Aug 2015 16:03:52 +0800 Jason Wang jasow...@redhat.com wrote: diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c index 9ff4193..834a409 100644 --- a/virt/kvm/eventfd.c +++ b/virt/kvm/eventfd.c @@ -838,11 +838,6 @@

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-21 Thread Cornelia Huck
On Fri, 21 Aug 2015 16:03:52 +0800 Jason Wang wrote: > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > index 9ff4193..834a409 100644 > --- a/virt/kvm/eventfd.c > +++ b/virt/kvm/eventfd.c > @@ -838,11 +838,6 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct > kvm_ioeventfd *args) > >

[PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-21 Thread Jason Wang
We register wildcard mmio eventfd on two buses, one for KVM_MMIO_BUS and another is KVM_FAST_MMIO_BUS. This leads to issue: - kvm_io_bus_destroy() knows nothing about the devices on two buses points to a single dev. Which will lead double free [1] during exit. - wildcard eventfd ignores data

[PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-21 Thread Jason Wang
We register wildcard mmio eventfd on two buses, one for KVM_MMIO_BUS and another is KVM_FAST_MMIO_BUS. This leads to issue: - kvm_io_bus_destroy() knows nothing about the devices on two buses points to a single dev. Which will lead double free [1] during exit. - wildcard eventfd ignores data

Re: [PATCH 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses

2015-08-21 Thread Cornelia Huck
On Fri, 21 Aug 2015 16:03:52 +0800 Jason Wang jasow...@redhat.com wrote: diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c index 9ff4193..834a409 100644 --- a/virt/kvm/eventfd.c +++ b/virt/kvm/eventfd.c @@ -838,11 +838,6 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct kvm_ioeventfd