Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-11 Thread Oleg Nesterov
On 04/10, Eric W. Biederman wrote: > > Oleg Nesterov <[EMAIL PROTECTED]> writes: > > > 1. rename reparent_to_init() to reparent_kthread() and export it > > > > 2. use init_pid_ns.child_reaper instead of child_reaper(current) > > > > 3. set ->exit_signal = -1, so init can't see us and we don't use

Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-11 Thread Oleg Nesterov
On 04/10, Eric W. Biederman wrote: Oleg Nesterov [EMAIL PROTECTED] writes: 1. rename reparent_to_init() to reparent_kthread() and export it 2. use init_pid_ns.child_reaper instead of child_reaper(current) 3. set -exit_signal = -1, so init can't see us and we don't use it to reap

Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > 1. rename reparent_to_init() to reparent_kthread() and export it > > 2. use init_pid_ns.child_reaper instead of child_reaper(current) > > 3. set ->exit_signal = -1, so init can't see us and we don't use >it to reap the task. > > 4. add

Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Eric W. Biederman
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > Quoting Oleg Nesterov ([EMAIL PROTECTED]): >> 1. rename reparent_to_init() to reparent_kthread() and export it >> >> 2. use init_pid_ns.child_reaper instead of child_reaper(current) > > Each of these patches looks good to me, but this part in

Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Serge E. Hallyn
Quoting Oleg Nesterov ([EMAIL PROTECTED]): > 1. rename reparent_to_init() to reparent_kthread() and export it > > 2. use init_pid_ns.child_reaper instead of child_reaper(current) Each of these patches looks good to me, but this part in particular is a must-have bugfix. Just started some tests,

[PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Oleg Nesterov
1. rename reparent_to_init() to reparent_kthread() and export it 2. use init_pid_ns.child_reaper instead of child_reaper(current) 3. set ->exit_signal = -1, so init can't see us and we don't use it to reap the task. 4. add reparent_kthread() to kthread() and stopmachine() See also

[PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Oleg Nesterov
1. rename reparent_to_init() to reparent_kthread() and export it 2. use init_pid_ns.child_reaper instead of child_reaper(current) 3. set -exit_signal = -1, so init can't see us and we don't use it to reap the task. 4. add reparent_kthread() to kthread() and stopmachine() See also

Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Serge E. Hallyn
Quoting Oleg Nesterov ([EMAIL PROTECTED]): 1. rename reparent_to_init() to reparent_kthread() and export it 2. use init_pid_ns.child_reaper instead of child_reaper(current) Each of these patches looks good to me, but this part in particular is a must-have bugfix. Just started some tests, if

Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Eric W. Biederman
Serge E. Hallyn [EMAIL PROTECTED] writes: Quoting Oleg Nesterov ([EMAIL PROTECTED]): 1. rename reparent_to_init() to reparent_kthread() and export it 2. use init_pid_ns.child_reaper instead of child_reaper(current) Each of these patches looks good to me, but this part in particular is a

Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Eric W. Biederman
Oleg Nesterov [EMAIL PROTECTED] writes: 1. rename reparent_to_init() to reparent_kthread() and export it 2. use init_pid_ns.child_reaper instead of child_reaper(current) 3. set -exit_signal = -1, so init can't see us and we don't use it to reap the task. 4. add reparent_kthread() to